<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[12865] CalendarServer/branches/users/sagen/move2who-2</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.calendarserver.org//changeset/12865">12865</a></dd>
<dt>Author</dt> <dd>sagen@apple.com</dd>
<dt>Date</dt> <dd>2014-03-10 11:19:32 -0700 (Mon, 10 Mar 2014)</dd>
</dl>

<h3>Log Message</h3>
<pre>Start moving older unit tests over to new directory API</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#CalendarServerbranchesuserssagenmove2who2twistedcaldavdirectorytestaccountsxml">CalendarServer/branches/users/sagen/move2who-2/twistedcaldav/directory/test/accounts.xml</a></li>
<li><a href="#CalendarServerbranchesuserssagenmove2who2twistedcaldavtestutilpy">CalendarServer/branches/users/sagen/move2who-2/twistedcaldav/test/util.py</a></li>
<li><a href="#CalendarServerbranchesuserssagenmove2who2txdavdpsserverpy">CalendarServer/branches/users/sagen/move2who-2/txdav/dps/server.py</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="CalendarServerbranchesuserssagenmove2who2twistedcaldavdirectorytestaccountsxml"></a>
<div class="modfile"><h4>Modified: CalendarServer/branches/users/sagen/move2who-2/twistedcaldav/directory/test/accounts.xml (12864 => 12865)</h4>
<pre class="diff"><span>
<span class="info">--- CalendarServer/branches/users/sagen/move2who-2/twistedcaldav/directory/test/accounts.xml        2014-03-10 17:52:25 UTC (rev 12864)
+++ CalendarServer/branches/users/sagen/move2who-2/twistedcaldav/directory/test/accounts.xml        2014-03-10 18:19:32 UTC (rev 12865)
</span><span class="lines">@@ -18,279 +18,261 @@
</span><span class="cx"> 
</span><span class="cx"> &lt;!DOCTYPE accounts SYSTEM &quot;../../../conf/auth/accounts.dtd&quot;&gt;
</span><span class="cx"> 
</span><del>-&lt;accounts realm=&quot;Test&quot;&gt;
-  &lt;user&gt;
-    &lt;uid&gt;admin&lt;/uid&gt;
-    &lt;guid&gt;D11F03A0-97EA-48AF-9A6C-FAC7F3975766&lt;/guid&gt;
</del><ins>+&lt;directory realm=&quot;Test&quot;&gt;
+  &lt;record type=&quot;user&quot;&gt;
+    &lt;short-name&gt;admin&lt;/short-name&gt;
+    &lt;uid&gt;D11F03A0-97EA-48AF-9A6C-FAC7F3975766&lt;/uid&gt;
</ins><span class="cx">     &lt;password&gt;nimda&lt;/password&gt;
</span><del>-    &lt;name&gt;Administrators&lt;/name&gt;
-  &lt;/user&gt;
-  &lt;user&gt;
-    &lt;uid&gt;wsanchez&lt;/uid&gt;
-    &lt;guid&gt;6423F94A-6B76-4A3A-815B-D52CFD77935D&lt;/guid&gt;
</del><ins>+    &lt;full-name&gt;Administrators&lt;/full-name&gt;
+  &lt;/record&gt;
+  &lt;record type=&quot;user&quot;&gt;
+    &lt;short-name&gt;wsanchez&lt;/short-name&gt;
+    &lt;uid&gt;6423F94A-6B76-4A3A-815B-D52CFD77935D&lt;/uid&gt;
</ins><span class="cx">     &lt;password&gt;zehcnasw&lt;/password&gt;
</span><del>-    &lt;name&gt;Wilfredo Sanchez&lt;/name&gt;
-    &lt;email-address&gt;wsanchez@example.com&lt;/email-address&gt;
-  &lt;/user&gt;
-  &lt;user&gt;
-    &lt;uid&gt;cdaboo&lt;/uid&gt;
-    &lt;guid&gt;5A985493-EE2C-4665-94CF-4DFEA3A89500&lt;/guid&gt;
</del><ins>+    &lt;full-name&gt;Wilfredo Sanchez&lt;/full-name&gt;
+    &lt;email&gt;wsanchez@example.com&lt;/email&gt;
+  &lt;/record&gt;
+  &lt;record type=&quot;user&quot;&gt;
+    &lt;short-name&gt;cdaboo&lt;/short-name&gt;
+    &lt;uid&gt;5A985493-EE2C-4665-94CF-4DFEA3A89500&lt;/uid&gt;
</ins><span class="cx">     &lt;password&gt;oobadc&lt;/password&gt;
</span><del>-    &lt;name&gt;Cyrus Daboo&lt;/name&gt;
-    &lt;email-address&gt;cdaboo@example.com&lt;/email-address&gt;
-  &lt;/user&gt;
-  &lt;user&gt;
-    &lt;uid&gt;lecroy&lt;/uid&gt;
-    &lt;guid&gt;8B4288F6-CC82-491D-8EF9-642EF4F3E7D0&lt;/guid&gt;
</del><ins>+    &lt;full-name&gt;Cyrus Daboo&lt;/full-name&gt;
+    &lt;email&gt;cdaboo@example.com&lt;/email&gt;
+  &lt;/record&gt;
+  &lt;record type=&quot;user&quot;&gt;
+    &lt;short-name&gt;lecroy&lt;/short-name&gt;
+    &lt;uid&gt;8B4288F6-CC82-491D-8EF9-642EF4F3E7D0&lt;/uid&gt;
</ins><span class="cx">     &lt;password&gt;yorcel&lt;/password&gt;
</span><del>-    &lt;name&gt;Chris Lecroy&lt;/name&gt;
-    &lt;email-address&gt;lecroy@example.com&lt;/email-address&gt;
-  &lt;/user&gt;
-  &lt;user&gt;
-    &lt;uid&gt;dreid&lt;/uid&gt;
-    &lt;guid&gt;5FF60DAD-0BDE-4508-8C77-15F0CA5C8DD1&lt;/guid&gt;
</del><ins>+    &lt;full-name&gt;Chris Lecroy&lt;/full-name&gt;
+    &lt;email&gt;lecroy@example.com&lt;/email&gt;
+  &lt;/record&gt;
+  &lt;record type=&quot;user&quot;&gt;
+    &lt;short-name&gt;dreid&lt;/short-name&gt;
+    &lt;uid&gt;5FF60DAD-0BDE-4508-8C77-15F0CA5C8DD1&lt;/uid&gt;
</ins><span class="cx">     &lt;password&gt;dierd&lt;/password&gt;
</span><del>-    &lt;name&gt;David Reid&lt;/name&gt;
-    &lt;email-address&gt;dreid@example.com&lt;/email-address&gt;
-  &lt;/user&gt;
-  &lt;user&gt;
-    &lt;uid&gt;doublequotes&lt;/uid&gt;
-    &lt;guid&gt;8E04787E-336D-41ED-A70B-D233AD0DCE6F&lt;/guid&gt;
</del><ins>+    &lt;full-name&gt;David Reid&lt;/full-name&gt;
+    &lt;email&gt;dreid@example.com&lt;/email&gt;
+  &lt;/record&gt;
+  &lt;record type=&quot;user&quot;&gt;
+    &lt;short-name&gt;doublequotes&lt;/short-name&gt;
+    &lt;uid&gt;8E04787E-336D-41ED-A70B-D233AD0DCE6F&lt;/uid&gt;
</ins><span class="cx">     &lt;password&gt;setouqelbuod&lt;/password&gt;
</span><del>-    &lt;name&gt;Double &quot;quotey&quot; Quotes&lt;/name&gt;
-    &lt;email-address&gt;doublequotes@example.com&lt;/email-address&gt;
-  &lt;/user&gt;
-  &lt;user&gt;
-    &lt;uid&gt;nocalendar&lt;/uid&gt;
-    &lt;guid&gt;543D28BA-F74F-4D5F-9243-B3E3A61171E5&lt;/guid&gt;
</del><ins>+    &lt;full-name&gt;Double &quot;quotey&quot; Quotes&lt;/full-name&gt;
+    &lt;email&gt;doublequotes@example.com&lt;/email&gt;
+  &lt;/record&gt;
+  &lt;record type=&quot;user&quot;&gt;
+    &lt;short-name&gt;nocalendar&lt;/short-name&gt;
+    &lt;uid&gt;543D28BA-F74F-4D5F-9243-B3E3A61171E5&lt;/uid&gt;
</ins><span class="cx">     &lt;password&gt;radnelacon&lt;/password&gt;
</span><del>-    &lt;name&gt;No Calendar&lt;/name&gt;
-    &lt;email-address&gt;nocalendar@example.com&lt;/email-address&gt;
-  &lt;/user&gt;
-  &lt;user&gt;
-    &lt;uid&gt;usera&lt;/uid&gt;
-    &lt;guid&gt;7423F94A-6B76-4A3A-815B-D52CFD77935D&lt;/guid&gt;
</del><ins>+    &lt;full-name&gt;No Calendar&lt;/full-name&gt;
+    &lt;email&gt;nocalendar@example.com&lt;/email&gt;
+  &lt;/record&gt;
+  &lt;record type=&quot;user&quot;&gt;
+    &lt;short-name&gt;usera&lt;/short-name&gt;
+    &lt;uid&gt;7423F94A-6B76-4A3A-815B-D52CFD77935D&lt;/uid&gt;
</ins><span class="cx">     &lt;password&gt;a&lt;/password&gt;
</span><del>-    &lt;name&gt;a&lt;/name&gt;
-    &lt;email-address&gt;a@example.com&lt;/email-address&gt;
-  &lt;/user&gt;
-  &lt;user&gt;
-    &lt;uid&gt;userb&lt;/uid&gt;
-    &lt;guid&gt;8A985493-EE2C-4665-94CF-4DFEA3A89500&lt;/guid&gt;
</del><ins>+    &lt;full-name&gt;a&lt;/full-name&gt;
+    &lt;email&gt;a@example.com&lt;/email&gt;
+  &lt;/record&gt;
+  &lt;record type=&quot;user&quot;&gt;
+    &lt;short-name&gt;userb&lt;/short-name&gt;
+    &lt;uid&gt;8A985493-EE2C-4665-94CF-4DFEA3A89500&lt;/uid&gt;
</ins><span class="cx">     &lt;password&gt;b&lt;/password&gt;
</span><del>-    &lt;name&gt;b&lt;/name&gt;
-    &lt;email-address&gt;b@example.com&lt;/email-address&gt;
-  &lt;/user&gt;
-  &lt;user&gt;
-    &lt;uid&gt;userc&lt;/uid&gt;
-    &lt;guid&gt;9FF60DAD-0BDE-4508-8C77-15F0CA5C8DD2&lt;/guid&gt;
</del><ins>+    &lt;full-name&gt;b&lt;/full-name&gt;
+    &lt;email&gt;b@example.com&lt;/email&gt;
+  &lt;/record&gt;
+  &lt;record type=&quot;user&quot;&gt;
+    &lt;short-name&gt;userc&lt;/short-name&gt;
+    &lt;uid&gt;9FF60DAD-0BDE-4508-8C77-15F0CA5C8DD2&lt;/uid&gt;
</ins><span class="cx">     &lt;password&gt;c&lt;/password&gt;
</span><del>-    &lt;name&gt;c&lt;/name&gt;
-    &lt;email-address&gt;c@example.com&lt;/email-address&gt;
-  &lt;/user&gt;
-  &lt;user&gt;
-    &lt;uid&gt;usercalonly&lt;/uid&gt;
-    &lt;guid&gt;9E1FFAC4-3CCD-45A1-8272-D161C92D2EEE&lt;/guid&gt;
</del><ins>+    &lt;full-name&gt;c&lt;/full-name&gt;
+    &lt;email&gt;c@example.com&lt;/email&gt;
+  &lt;/record&gt;
+  &lt;record type=&quot;user&quot;&gt;
+    &lt;short-name&gt;usercalonly&lt;/short-name&gt;
+    &lt;uid&gt;9E1FFAC4-3CCD-45A1-8272-D161C92D2EEE&lt;/uid&gt;
</ins><span class="cx">     &lt;password&gt;a&lt;/password&gt;
</span><del>-    &lt;name&gt;a calonly&lt;/name&gt;
-    &lt;email-address&gt;a-calonly@example.com&lt;/email-address&gt;
-  &lt;/user&gt;
-  &lt;user&gt;
-    &lt;uid&gt;useradbkonly&lt;/uid&gt;
-    &lt;guid&gt;7678EC8A-A069-4E82-9066-7279C6718507&lt;/guid&gt;
</del><ins>+    &lt;full-name&gt;a calonly&lt;/full-name&gt;
+    &lt;email&gt;a-calonly@example.com&lt;/email&gt;
+  &lt;/record&gt;
+  &lt;record type=&quot;user&quot;&gt;
+    &lt;short-name&gt;useradbkonly&lt;/short-name&gt;
+    &lt;uid&gt;7678EC8A-A069-4E82-9066-7279C6718507&lt;/uid&gt;
</ins><span class="cx">     &lt;password&gt;a&lt;/password&gt;
</span><del>-    &lt;name&gt;a adbkonly&lt;/name&gt;
-    &lt;email-address&gt;a-adbkonly@example.com&lt;/email-address&gt;
-  &lt;/user&gt;
-  &lt;user&gt;
-    &lt;uid&gt;nonascii&lt;/uid&gt;
-    &lt;uid&gt;nonascii佐藤&lt;/uid&gt;
-    &lt;guid&gt;320B73A1-46E2-4180-9563-782DFDBE1F63&lt;/guid&gt;
</del><ins>+    &lt;full-name&gt;a adbkonly&lt;/full-name&gt;
+    &lt;email&gt;a-adbkonly@example.com&lt;/email&gt;
+  &lt;/record&gt;
+  &lt;record type=&quot;user&quot;&gt;
+    &lt;short-name&gt;nonascii&lt;/short-name&gt;
+    &lt;short-name&gt;nonascii佐藤&lt;/short-name&gt;
+    &lt;uid&gt;320B73A1-46E2-4180-9563-782DFDBE1F63&lt;/uid&gt;
</ins><span class="cx">     &lt;password&gt;a&lt;/password&gt;
</span><del>-    &lt;name&gt;佐藤佐藤佐藤&lt;/name&gt;
-    &lt;email-address&gt;nonascii@example.com&lt;/email-address&gt;
-  &lt;/user&gt;
-  &lt;user&gt;
-    &lt;uid&gt;delegator&lt;/uid&gt;
-    &lt;guid&gt;FC465590-E9E9-4746-ACE8-6C756A49FE4D&lt;/guid&gt;
</del><ins>+    &lt;full-name&gt;佐藤佐藤佐藤&lt;/full-name&gt;
+    &lt;email&gt;nonascii@example.com&lt;/email&gt;
+  &lt;/record&gt;
+  &lt;record type=&quot;user&quot;&gt;
+    &lt;short-name&gt;delegator&lt;/short-name&gt;
+    &lt;uid&gt;FC465590-E9E9-4746-ACE8-6C756A49FE4D&lt;/uid&gt;
</ins><span class="cx">     &lt;password&gt;a&lt;/password&gt;
</span><del>-    &lt;name&gt;Calendar Delegator&lt;/name&gt;
-    &lt;email-address&gt;calendardelegator@example.com&lt;/email-address&gt;
-  &lt;/user&gt;
-  &lt;user&gt;
-    &lt;uid&gt;occasionaldelegate&lt;/uid&gt;
-    &lt;guid&gt;EC465590-E9E9-4746-ACE8-6C756A49FE4D&lt;/guid&gt;
</del><ins>+    &lt;full-name&gt;Calendar Delegator&lt;/full-name&gt;
+    &lt;email&gt;calendardelegator@example.com&lt;/email&gt;
+  &lt;/record&gt;
+  &lt;record type=&quot;user&quot;&gt;
+    &lt;short-name&gt;occasionaldelegate&lt;/short-name&gt;
+    &lt;uid&gt;EC465590-E9E9-4746-ACE8-6C756A49FE4D&lt;/uid&gt;
</ins><span class="cx">     &lt;password&gt;a&lt;/password&gt;
</span><del>-    &lt;name&gt;Occasional Delegate&lt;/name&gt;
-    &lt;email-address&gt;occasional@example.com&lt;/email-address&gt;
-  &lt;/user&gt;
-    &lt;user&gt;
-    &lt;uid&gt;delegateviagroup&lt;/uid&gt;
-    &lt;guid&gt;46D9D716-CBEE-490F-907A-66FA6C3767FF&lt;/guid&gt;
</del><ins>+    &lt;full-name&gt;Occasional Delegate&lt;/full-name&gt;
+    &lt;email&gt;occasional@example.com&lt;/email&gt;
+  &lt;/record&gt;
+    &lt;record type=&quot;user&quot;&gt;
+    &lt;short-name&gt;delegateviagroup&lt;/short-name&gt;
+    &lt;uid&gt;46D9D716-CBEE-490F-907A-66FA6C3767FF&lt;/uid&gt;
</ins><span class="cx">     &lt;password&gt;a&lt;/password&gt;
</span><del>-    &lt;name&gt;Delegate Via Group&lt;/name&gt;
-    &lt;email-address&gt;delegateviagroup@example.com&lt;/email-address&gt;
-  &lt;/user&gt;
-  &lt;group&gt;
-    &lt;uid&gt;delegategroup&lt;/uid&gt;
-    &lt;guid&gt;00599DAF-3E75-42DD-9DB7-52617E79943F&lt;/guid&gt;
-    &lt;name&gt;Delegate Group&lt;/name&gt;
-    &lt;members&gt;
-      &lt;member type=&quot;users&quot;&gt;delegateviagroup&lt;/member&gt;
-    &lt;/members&gt;
-  &lt;/group&gt;
</del><ins>+    &lt;full-name&gt;Delegate Via Group&lt;/full-name&gt;
+    &lt;email&gt;delegateviagroup@example.com&lt;/email&gt;
+  &lt;/record&gt;
+  &lt;record type=&quot;group&quot;&gt;
+    &lt;short-name&gt;delegategroup&lt;/short-name&gt;
+    &lt;uid&gt;00599DAF-3E75-42DD-9DB7-52617E79943F&lt;/uid&gt;
+    &lt;full-name&gt;Delegate Group&lt;/full-name&gt;
+      &lt;member-uid&gt;delegateviagroup&lt;/member-uid&gt;
+  &lt;/record&gt;
</ins><span class="cx">   &lt;user repeat=&quot;100&quot;&gt;
</span><ins>+    &lt;short-name&gt;user%02d&lt;/short-name&gt;
</ins><span class="cx">     &lt;uid&gt;user%02d&lt;/uid&gt;
</span><del>-    &lt;guid&gt;user%02d&lt;/guid&gt;
</del><span class="cx">     &lt;password&gt;%02duser&lt;/password&gt;
</span><del>-    &lt;name&gt;~35 User %02d&lt;/name&gt;
</del><ins>+    &lt;full-name&gt;~35 User %02d&lt;/full-name&gt;
</ins><span class="cx">     &lt;first-name&gt;~5&lt;/first-name&gt;
</span><span class="cx">     &lt;last-name&gt;~9 User %02d&lt;/last-name&gt;
</span><del>-    &lt;email-address&gt;~10@example.com&lt;/email-address&gt;
</del><ins>+    &lt;email&gt;~10@example.com&lt;/email&gt;
</ins><span class="cx">   &lt;/user&gt;
</span><del>-  &lt;group&gt;
-    &lt;uid&gt;managers&lt;/uid&gt;
-    &lt;guid&gt;9FF60DAD-0BDE-4508-8C77-15F0CA5C8DD1&lt;/guid&gt;
</del><ins>+  &lt;record type=&quot;group&quot;&gt;
+    &lt;short-name&gt;managers&lt;/short-name&gt;
+    &lt;uid&gt;9FF60DAD-0BDE-4508-8C77-15F0CA5C8DD1&lt;/uid&gt;
</ins><span class="cx">     &lt;password&gt;managers&lt;/password&gt;
</span><del>-    &lt;name&gt;Managers&lt;/name&gt;
-    &lt;members&gt;
-      &lt;member type=&quot;users&quot;&gt;lecroy&lt;/member&gt;
-    &lt;/members&gt;
-  &lt;/group&gt;
-  &lt;group&gt;
</del><ins>+    &lt;full-name&gt;Managers&lt;/full-name&gt;
+      &lt;member-uid&gt;lecroy&lt;/member-uid&gt;
+  &lt;/record&gt;
+  &lt;record type=&quot;group&quot;&gt;
+    &lt;short-name&gt;admin&lt;/short-name&gt;
</ins><span class="cx">     &lt;uid&gt;admin&lt;/uid&gt;
</span><del>-    &lt;guid&gt;admin&lt;/guid&gt;
</del><span class="cx">     &lt;password&gt;admin&lt;/password&gt;
</span><del>-    &lt;name&gt;Administrators&lt;/name&gt;
-    &lt;members&gt;
-      &lt;member type=&quot;groups&quot;&gt;managers&lt;/member&gt;
-    &lt;/members&gt;
-  &lt;/group&gt;
-  &lt;group&gt;
</del><ins>+    &lt;full-name&gt;Administrators&lt;/full-name&gt;
+      &lt;member-uid&gt;managers&lt;/member-uid&gt;
+  &lt;/record&gt;
+  &lt;record type=&quot;group&quot;&gt;
+    &lt;short-name&gt;grunts&lt;/short-name&gt;
</ins><span class="cx">     &lt;uid&gt;grunts&lt;/uid&gt;
</span><del>-    &lt;guid&gt;grunts&lt;/guid&gt;
</del><span class="cx">     &lt;password&gt;grunts&lt;/password&gt;
</span><del>-    &lt;name&gt;We do all the work&lt;/name&gt;
-    &lt;members&gt;
-      &lt;member&gt;wsanchez&lt;/member&gt;
-      &lt;member&gt;cdaboo&lt;/member&gt;
-      &lt;member&gt;dreid&lt;/member&gt;
-    &lt;/members&gt;
-  &lt;/group&gt;
-  &lt;group&gt;
</del><ins>+    &lt;full-name&gt;We do all the work&lt;/full-name&gt;
+      &lt;member-uid&gt;wsanchez&lt;/member-uid&gt;
+      &lt;member-uid&gt;cdaboo&lt;/member-uid&gt;
+      &lt;member-uid&gt;dreid&lt;/member-uid&gt;
+  &lt;/record&gt;
+  &lt;record type=&quot;group&quot;&gt;
+    &lt;short-name&gt;right_coast&lt;/short-name&gt;
</ins><span class="cx">     &lt;uid&gt;right_coast&lt;/uid&gt;
</span><del>-    &lt;guid&gt;right_coast&lt;/guid&gt;
</del><span class="cx">     &lt;password&gt;right_coast&lt;/password&gt;
</span><del>-    &lt;name&gt;East Coast&lt;/name&gt;
-    &lt;members&gt;
-      &lt;member&gt;cdaboo&lt;/member&gt;
-    &lt;/members&gt;
-  &lt;/group&gt;
-  &lt;group&gt;
</del><ins>+    &lt;full-name&gt;East Coast&lt;/full-name&gt;
+      &lt;member-uid&gt;cdaboo&lt;/member-uid&gt;
+  &lt;/record&gt;
+  &lt;record type=&quot;group&quot;&gt;
+    &lt;short-name&gt;left_coast&lt;/short-name&gt;
</ins><span class="cx">     &lt;uid&gt;left_coast&lt;/uid&gt;
</span><del>-    &lt;guid&gt;left_coast&lt;/guid&gt;
</del><span class="cx">     &lt;password&gt;left_coast&lt;/password&gt;
</span><del>-    &lt;name&gt;West Coast&lt;/name&gt;
-    &lt;members&gt;
-      &lt;member&gt;wsanchez&lt;/member&gt;
-      &lt;member&gt;lecroy&lt;/member&gt;
-      &lt;member&gt;dreid&lt;/member&gt;
-    &lt;/members&gt;
-  &lt;/group&gt;
-  &lt;group&gt;
</del><ins>+    &lt;full-name&gt;West Coast&lt;/full-name&gt;
+      &lt;member-uid&gt;wsanchez&lt;/member-uid&gt;
+      &lt;member-uid&gt;lecroy&lt;/member-uid&gt;
+      &lt;member-uid&gt;dreid&lt;/member-uid&gt;
+  &lt;/record&gt;
+  &lt;record type=&quot;group&quot;&gt;
+    &lt;short-name&gt;both_coasts&lt;/short-name&gt;
</ins><span class="cx">     &lt;uid&gt;both_coasts&lt;/uid&gt;
</span><del>-    &lt;guid&gt;both_coasts&lt;/guid&gt;
</del><span class="cx">     &lt;password&gt;both_coasts&lt;/password&gt;
</span><del>-    &lt;name&gt;Both Coasts&lt;/name&gt;
-    &lt;members&gt;
-      &lt;member type=&quot;groups&quot;&gt;right_coast&lt;/member&gt;
-      &lt;member type=&quot;groups&quot;&gt;left_coast&lt;/member&gt;
-    &lt;/members&gt;
-  &lt;/group&gt;
-  &lt;group&gt;
</del><ins>+    &lt;full-name&gt;Both Coasts&lt;/full-name&gt;
+      &lt;member-uid&gt;right_coast&lt;/member-uid&gt;
+      &lt;member-uid&gt;left_coast&lt;/member-uid&gt;
+  &lt;/record&gt;
+  &lt;record type=&quot;group&quot;&gt;
+    &lt;short-name&gt;recursive1_coasts&lt;/short-name&gt;
</ins><span class="cx">     &lt;uid&gt;recursive1_coasts&lt;/uid&gt;
</span><del>-    &lt;guid&gt;recursive1_coasts&lt;/guid&gt;
</del><span class="cx">     &lt;password&gt;recursive1_coasts&lt;/password&gt;
</span><del>-    &lt;name&gt;Recursive1 Coasts&lt;/name&gt;
-    &lt;members&gt;
-      &lt;member type=&quot;groups&quot;&gt;recursive2_coasts&lt;/member&gt;
-      &lt;member&gt;wsanchez&lt;/member&gt;
-    &lt;/members&gt;
-  &lt;/group&gt;
-  &lt;group&gt;
</del><ins>+    &lt;full-name&gt;Recursive1 Coasts&lt;/full-name&gt;
+      &lt;member-uid&gt;recursive2_coasts&lt;/member-uid&gt;
+      &lt;member-uid&gt;wsanchez&lt;/member-uid&gt;
+  &lt;/record&gt;
+  &lt;record type=&quot;group&quot;&gt;
+    &lt;short-name&gt;recursive2_coasts&lt;/short-name&gt;
</ins><span class="cx">     &lt;uid&gt;recursive2_coasts&lt;/uid&gt;
</span><del>-    &lt;guid&gt;recursive2_coasts&lt;/guid&gt;
</del><span class="cx">     &lt;password&gt;recursive2_coasts&lt;/password&gt;
</span><del>-    &lt;name&gt;Recursive2 Coasts&lt;/name&gt;
-    &lt;members&gt;
-      &lt;member type=&quot;groups&quot;&gt;recursive1_coasts&lt;/member&gt;
-      &lt;member&gt;cdaboo&lt;/member&gt;
-    &lt;/members&gt;
-  &lt;/group&gt;
-  &lt;group&gt;
</del><ins>+    &lt;full-name&gt;Recursive2 Coasts&lt;/full-name&gt;
+      &lt;member-uid&gt;recursive1_coasts&lt;/member-uid&gt;
+      &lt;member-uid&gt;cdaboo&lt;/member-uid&gt;
+  &lt;/record&gt;
+  &lt;record type=&quot;group&quot;&gt;
+    &lt;short-name&gt;non_calendar_group&lt;/short-name&gt;
</ins><span class="cx">     &lt;uid&gt;non_calendar_group&lt;/uid&gt;
</span><del>-    &lt;guid&gt;non_calendar_group&lt;/guid&gt;
</del><span class="cx">     &lt;password&gt;non_calendar_group&lt;/password&gt;
</span><del>-    &lt;name&gt;Non-calendar group&lt;/name&gt;
-    &lt;members&gt;
-      &lt;member&gt;cdaboo&lt;/member&gt;
-      &lt;member&gt;lecroy&lt;/member&gt;
-    &lt;/members&gt;
-  &lt;/group&gt;
</del><ins>+    &lt;full-name&gt;Non-calendar group&lt;/full-name&gt;
+      &lt;member-uid&gt;cdaboo&lt;/member-uid&gt;
+      &lt;member-uid&gt;lecroy&lt;/member-uid&gt;
+  &lt;/record&gt;
+  &lt;!--
</ins><span class="cx">   &lt;location&gt;
</span><span class="cx">     &lt;uid&gt;mercury&lt;/uid&gt;
</span><del>-    &lt;guid&gt;mercury&lt;/guid&gt;
</del><ins>+    &lt;uid&gt;mercury&lt;/uid&gt;
</ins><span class="cx">     &lt;password&gt;mercury&lt;/password&gt;
</span><span class="cx">     &lt;name&gt;Mercury Seven&lt;/name&gt;
</span><span class="cx">     &lt;email-address&gt;mercury@example.com&lt;/email-address&gt;
</span><span class="cx">   &lt;/location&gt;
</span><span class="cx">   &lt;location&gt;
</span><span class="cx">     &lt;uid&gt;gemini&lt;/uid&gt;
</span><del>-    &lt;guid&gt;gemini&lt;/guid&gt;
</del><ins>+    &lt;uid&gt;gemini&lt;/uid&gt;
</ins><span class="cx">     &lt;password&gt;gemini&lt;/password&gt;
</span><span class="cx">     &lt;name&gt;Gemini Twelve&lt;/name&gt;
</span><span class="cx">     &lt;email-address&gt;gemini@example.com&lt;/email-address&gt;
</span><span class="cx">   &lt;/location&gt;
</span><span class="cx">   &lt;location&gt;
</span><span class="cx">     &lt;uid&gt;apollo&lt;/uid&gt;
</span><del>-    &lt;guid&gt;apollo&lt;/guid&gt;
</del><ins>+    &lt;uid&gt;apollo&lt;/uid&gt;
</ins><span class="cx">     &lt;password&gt;apollo&lt;/password&gt;
</span><span class="cx">     &lt;name&gt;Apollo Eleven&lt;/name&gt;
</span><span class="cx">     &lt;email-address&gt;apollo@example.com&lt;/email-address&gt;
</span><span class="cx">   &lt;/location&gt;
</span><span class="cx">   &lt;location&gt;
</span><span class="cx">     &lt;uid&gt;orion&lt;/uid&gt;
</span><del>-    &lt;guid&gt;orion&lt;/guid&gt;
</del><ins>+    &lt;uid&gt;orion&lt;/uid&gt;
</ins><span class="cx">     &lt;password&gt;orion&lt;/password&gt;
</span><span class="cx">     &lt;name&gt;Orion&lt;/name&gt;
</span><span class="cx">     &lt;email-address&gt;orion@example.com&lt;/email-address&gt;
</span><span class="cx">   &lt;/location&gt;
</span><span class="cx">   &lt;resource&gt;
</span><span class="cx">     &lt;uid&gt;transporter&lt;/uid&gt;
</span><del>-    &lt;guid&gt;transporter&lt;/guid&gt;
</del><ins>+    &lt;uid&gt;transporter&lt;/uid&gt;
</ins><span class="cx">     &lt;password&gt;transporter&lt;/password&gt;
</span><span class="cx">     &lt;name&gt;Mass Transporter&lt;/name&gt;
</span><span class="cx">     &lt;email-address&gt;transporter@example.com&lt;/email-address&gt;
</span><span class="cx">   &lt;/resource&gt;
</span><span class="cx">   &lt;resource&gt;
</span><span class="cx">     &lt;uid&gt;ftlcpu&lt;/uid&gt;
</span><del>-    &lt;guid&gt;ftlcpu&lt;/guid&gt;
</del><ins>+    &lt;uid&gt;ftlcpu&lt;/uid&gt;
</ins><span class="cx">     &lt;password&gt;ftlcpu&lt;/password&gt;
</span><span class="cx">     &lt;name&gt;Faster-Than-Light Microprocessor&lt;/name&gt;
</span><span class="cx">     &lt;email-address&gt;ftlcpu@example.com&lt;/email-address&gt;
</span><span class="cx">   &lt;/resource&gt;
</span><span class="cx">   &lt;resource&gt;
</span><span class="cx">     &lt;uid&gt;non_calendar_proxy&lt;/uid&gt;
</span><del>-    &lt;guid&gt;non_calendar_proxy&lt;/guid&gt;
</del><ins>+    &lt;uid&gt;non_calendar_proxy&lt;/uid&gt;
</ins><span class="cx">     &lt;password&gt;non_calendar_proxy&lt;/password&gt;
</span><span class="cx">     &lt;name&gt;Non-calendar proxy&lt;/name&gt;
</span><span class="cx">     &lt;email-address&gt;non_calendar_proxy@example.com&lt;/email-address&gt;
</span><span class="cx">   &lt;/resource&gt;
</span><span class="cx">   &lt;resource&gt;
</span><span class="cx">     &lt;uid&gt;disabled&lt;/uid&gt;
</span><del>-    &lt;guid&gt;disabled&lt;/guid&gt;
</del><ins>+    &lt;uid&gt;disabled&lt;/uid&gt;
</ins><span class="cx">     &lt;password&gt;disabled&lt;/password&gt;
</span><span class="cx">     &lt;name&gt;Disabled Record&lt;/name&gt;
</span><span class="cx">     &lt;email-address&gt;disabled@example.com&lt;/email-address&gt;
</span><span class="cx">   &lt;/resource&gt;
</span><del>-&lt;/accounts&gt;
</del><ins>+--&gt;
+&lt;/directory&gt;
</ins></span></pre></div>
<a id="CalendarServerbranchesuserssagenmove2who2twistedcaldavtestutilpy"></a>
<div class="modfile"><h4>Modified: CalendarServer/branches/users/sagen/move2who-2/twistedcaldav/test/util.py (12864 => 12865)</h4>
<pre class="diff"><span>
<span class="info">--- CalendarServer/branches/users/sagen/move2who-2/twistedcaldav/test/util.py        2014-03-10 17:52:25 UTC (rev 12864)
+++ CalendarServer/branches/users/sagen/move2who-2/twistedcaldav/test/util.py        2014-03-10 18:19:32 UTC (rev 12865)
</span><span class="lines">@@ -17,46 +17,41 @@
</span><span class="cx"> from __future__ import with_statement
</span><span class="cx"> 
</span><span class="cx"> import os
</span><del>-import xattr
</del><span class="cx"> 
</span><del>-from twistedcaldav.stdconfig import config
-
-from twisted.python.failure import Failure
</del><ins>+from calendarserver.provision.root import RootResource
+from calendarserver.tap.util import getRootResource
+from twext.python.filepath import CachingFilePath as FilePath
+from twext.python.log import Logger
</ins><span class="cx"> from twisted.internet.base import DelayedCall
</span><span class="cx"> from twisted.internet.defer import succeed, fail, inlineCallbacks, returnValue
</span><span class="cx"> from twisted.internet.protocol import ProcessProtocol
</span><del>-
-from twext.python.filepath import CachingFilePath as FilePath
-import txweb2.dav.test.util
-from txdav.xml import element as davxml, element
-from txweb2.http import HTTPError, StatusResponse
-
</del><ins>+from twisted.python.failure import Failure
</ins><span class="cx"> from twistedcaldav import memcacher
</span><del>-from twistedcaldav.memcacheclient import ClientFactory
</del><span class="cx"> from twistedcaldav.bind import doBind
</span><span class="cx"> from twistedcaldav.directory import augment
</span><span class="cx"> from twistedcaldav.directory.addressbook import DirectoryAddressBookHomeProvisioningResource
</span><ins>+from twistedcaldav.directory.aggregate import AggregateDirectoryService
</ins><span class="cx"> from twistedcaldav.directory.calendar import (
</span><span class="cx">     DirectoryCalendarHomeProvisioningResource
</span><span class="cx"> )
</span><ins>+from twistedcaldav.directory.directory import DirectoryService
</ins><span class="cx"> from twistedcaldav.directory.principal import (
</span><span class="cx">     DirectoryPrincipalProvisioningResource)
</span><del>-from twistedcaldav.directory.aggregate import AggregateDirectoryService
</del><ins>+from twistedcaldav.directory.util import transactionFromRequest
</ins><span class="cx"> from twistedcaldav.directory.xmlfile import XMLDirectoryService
</span><del>-
</del><ins>+from twistedcaldav.memcacheclient import ClientFactory
+from twistedcaldav.stdconfig import config
+from txdav.caldav.datastore.test.util import buildCalendarStore
+from txdav.common.datastore.file import CommonDataStore
</ins><span class="cx"> from txdav.common.datastore.test.util import deriveQuota, CommonCommonTests
</span><del>-from txdav.common.datastore.file import CommonDataStore
</del><ins>+from txdav.dps.server import directoryFromConfig
+from txdav.xml import element as davxml, element
+from txweb2.dav.test.util import SimpleRequest
+import txweb2.dav.test.util
+from txweb2.http import HTTPError, StatusResponse
+import xattr
</ins><span class="cx"> 
</span><del>-from calendarserver.provision.root import RootResource
</del><span class="cx"> 
</span><del>-from twext.python.log import Logger
-from calendarserver.tap.util import getRootResource
-from txweb2.dav.test.util import SimpleRequest
-from twistedcaldav.directory.util import transactionFromRequest
-from twistedcaldav.directory.directory import DirectoryService
-from txdav.caldav.datastore.test.util import buildCalendarStore
-from txdav.dps.server import directoryFromConfig
-
</del><span class="cx"> log = Logger()
</span><span class="cx"> 
</span><span class="cx"> 
</span><span class="lines">@@ -68,10 +63,12 @@
</span><span class="cx"> ]
</span><span class="cx"> DelayedCall.debug = True
</span><span class="cx"> 
</span><ins>+
</ins><span class="cx"> def _todo(f, why):
</span><span class="cx">     f.todo = why
</span><span class="cx">     return f
</span><span class="cx"> 
</span><ins>+
</ins><span class="cx"> featureUnimplemented = lambda f: _todo(f, &quot;Feature unimplemented&quot;)
</span><span class="cx"> testUnimplemented = lambda f: _todo(f, &quot;Test unimplemented&quot;)
</span><span class="cx"> todo = lambda why: lambda f: _todo(f, why)
</span><span class="lines">@@ -199,9 +196,13 @@
</span><span class="cx"> 
</span><span class="cx">         self.configure()
</span><span class="cx"> 
</span><del>-        self._sqlCalendarStore = yield buildCalendarStore(self, self.notifierFactory, directoryFromConfig(config))
</del><ins>+        self._sqlCalendarStore = yield buildCalendarStore(
+            self, self.notifierFactory, None
+        )
+        self.directory = directoryFromConfig(config, self._sqlCalendarStore)
+        self._sqlCalendarStore.setDirectoryService(self.directory)
+
</ins><span class="cx">         self.rootResource = getRootResource(config, self._sqlCalendarStore)
</span><del>-        self.directory = self._sqlCalendarStore.directoryService()
</del><span class="cx"> 
</span><span class="cx">         self.principalsResource = DirectoryPrincipalProvisioningResource(&quot;/principals/&quot;, self.directory)
</span><span class="cx">         self.site.resource.putChild(&quot;principals&quot;, self.principalsResource)
</span><span class="lines">@@ -289,11 +290,16 @@
</span><span class="cx">         &quot;&quot;&quot;
</span><span class="cx">         self.xmlFile = FilePath(config.DataRoot).child(&quot;accounts.xml&quot;)
</span><span class="cx">         self.xmlFile.setContent(xmlFile.getContent())
</span><del>-        self.directoryFixture.addDirectoryService(XMLDirectoryService({
-            &quot;xmlFile&quot;: &quot;accounts.xml&quot;,
-            &quot;augmentService&quot;:
-                augment.AugmentXMLDB(xmlFiles=(augmentsFile.path,)),
-        }))
</del><ins>+        self.directoryFixture.addDirectoryService(
+            XMLDirectoryService(
+                {
+                    &quot;xmlFile&quot;: &quot;accounts.xml&quot;,
+                    &quot;augmentService&quot;: augment.AugmentXMLDB(
+                        xmlFiles=(augmentsFile.path,)
+                    ),
+                }
+            )
+        )
</ins><span class="cx"> 
</span><span class="cx"> 
</span><span class="cx">     def setupCalendars(self):
</span><span class="lines">@@ -309,6 +315,8 @@
</span><span class="cx">         L{TestCase.directoryFixture.addDirectoryService}.
</span><span class="cx">         &quot;&quot;&quot;
</span><span class="cx">         newStore = self.createDataStore()
</span><ins>+
+
</ins><span class="cx">         @self.directoryFixture.whenDirectoryServiceChanges
</span><span class="cx">         def putAllChildren(ds):
</span><span class="cx">             self.calendarCollection = (
</span><span class="lines">@@ -507,7 +515,7 @@
</span><span class="cx">                                     print(&quot;Xattr mismatch:&quot;, childPath, attr)
</span><span class="cx">                                     print((xattr.getxattr(childPath, attr), &quot; != &quot;, value))
</span><span class="cx">                                     return False
</span><del>-                            else: # method
</del><ins>+                            else:  # method
</ins><span class="cx">                                 if not value(xattr.getxattr(childPath, attr)):
</span><span class="cx">                                     return False
</span><span class="cx"> 
</span><span class="lines">@@ -557,6 +565,8 @@
</span><span class="cx">         &quot;&quot;&quot;
</span><span class="cx">         super(HomeTestCase, self).setUp()
</span><span class="cx">         self.createStockDirectoryService()
</span><ins>+
+
</ins><span class="cx">         @self.directoryFixture.whenDirectoryServiceChanges
</span><span class="cx">         def addHomeProvisioner(ds):
</span><span class="cx">             self.homeProvisioner = DirectoryCalendarHomeProvisioningResource(
</span><span class="lines">@@ -641,6 +651,8 @@
</span><span class="cx">         &quot;&quot;&quot;
</span><span class="cx">         super(AddressBookHomeTestCase, self).setUp()
</span><span class="cx">         self.createStockDirectoryService()
</span><ins>+
+
</ins><span class="cx">         @self.directoryFixture.whenDirectoryServiceChanges
</span><span class="cx">         def addHomeProvisioner(ds):
</span><span class="cx">             self.homeProvisioner = DirectoryAddressBookHomeProvisioningResource(
</span></span></pre></div>
<a id="CalendarServerbranchesuserssagenmove2who2txdavdpsserverpy"></a>
<div class="modfile"><h4>Modified: CalendarServer/branches/users/sagen/move2who-2/txdav/dps/server.py (12864 => 12865)</h4>
<pre class="diff"><span>
<span class="info">--- CalendarServer/branches/users/sagen/move2who-2/txdav/dps/server.py        2014-03-10 17:52:25 UTC (rev 12864)
+++ CalendarServer/branches/users/sagen/move2who-2/txdav/dps/server.py        2014-03-10 18:19:32 UTC (rev 12865)
</span><span class="lines">@@ -34,7 +34,7 @@
</span><span class="cx"> from twisted.python.filepath import FilePath
</span><span class="cx"> from twisted.python.reflect import namedClass
</span><span class="cx"> from twisted.python.usage import Options, UsageError
</span><del>-from twistedcaldav.config import config
</del><ins>+from twistedcaldav.config import config, fullServerPath
</ins><span class="cx"> from twistedcaldav.stdconfig import DEFAULT_CONFIG, DEFAULT_CONFIG_FILE
</span><span class="cx"> from txdav.dps.commands import (
</span><span class="cx">     RecordWithShortNameCommand, RecordWithUIDCommand, RecordWithGUIDCommand,
</span><span class="lines">@@ -421,44 +421,64 @@
</span><span class="cx"> 
</span><span class="cx"> def directoryFromConfig(config, store=None):
</span><span class="cx">     &quot;&quot;&quot;
</span><del>-    Return a directory service based on the config
</del><ins>+    Return a directory service based on the config.  If you want to go through
+    AMP to talk to one of these as a client, instantiate
+    txdav.dps.client.DirectoryService
</ins><span class="cx">     &quot;&quot;&quot;
</span><del>-    directoryType = config.DirectoryProxy.DirectoryType
-    args = config.DirectoryProxy.Arguments
-    kwds = config.DirectoryProxy.Keywords
</del><span class="cx"> 
</span><del>-    # FIXME: this needs to talk to its own separate database
</del><ins>+    # FIXME: this needs to talk to its own separate database.  In fact,
+    # don't pass store=None if you already have called storeFromConfig()
+    # within this process.  Pass the existing store in here.
</ins><span class="cx">     pool, txnFactory = getDBPool(config)
</span><span class="cx">     if store is None:
</span><span class="cx">         store = storeFromConfig(config, txnFactory, None)
</span><span class="cx"> 
</span><del>-    if directoryType == &quot;OD&quot;:
-        from twext.who.opendirectory import DirectoryService as ODDirectoryService
-        primaryDirectory = ODDirectoryService(*args, **kwds)
</del><ins>+    # directoryType = config.DirectoryProxy.DirectoryType
+    directoryType = config.DirectoryService.type
</ins><span class="cx"> 
</span><del>-    elif directoryType == &quot;LDAP&quot;:
-        authDN = kwds.pop(&quot;authDN&quot;, &quot;&quot;)
-        password = kwds.pop(&quot;password&quot;, &quot;&quot;)
-        if authDN and password:
-            creds = UsernamePassword(authDN, password)
-        else:
-            creds = None
-        kwds[&quot;credentials&quot;] = creds
-        debug = kwds.pop(&quot;debug&quot;, &quot;&quot;)
-        primaryDirectory = LDAPDirectoryService(
-            *args, _debug=debug, **kwds
-        )
</del><ins>+    if &quot;XML&quot; in directoryType:
+        xmlFile = config.DirectoryService.params.xmlFile
+        xmlFile = fullServerPath(config.DataRoot, xmlFile)
+        # path = kwds.pop(&quot;path&quot;, &quot;&quot;)
+        if not xmlFile or not os.path.exists(xmlFile):
+            log.error(&quot;Path not found for XML directory: {p}&quot;, p=xmlFile)
+        fp = FilePath(xmlFile)
+        primaryDirectory = XMLDirectoryService(fp)
</ins><span class="cx"> 
</span><del>-    elif directoryType == &quot;XML&quot;:
-        path = kwds.pop(&quot;path&quot;, &quot;&quot;)
-        if not path or not os.path.exists(path):
-            log.error(&quot;Path not found for XML directory: {p}&quot;, p=path)
-        fp = FilePath(path)
-        primaryDirectory = XMLDirectoryService(fp, *args, **kwds)
</del><span class="cx"> 
</span><del>-    else:
-        log.error(&quot;Invalid DirectoryType: {dt}&quot;, dt=directoryType)
</del><ins>+    # FIXME: implement the other service types
</ins><span class="cx"> 
</span><ins>+    # args = config.DirectoryProxy.Arguments
+    # kwds = config.DirectoryProxy.Keywords
+
+
+    # if directoryType == &quot;OD&quot;:
+    #     from twext.who.opendirectory import DirectoryService as ODDirectoryService
+    #     primaryDirectory = ODDirectoryService(*args, **kwds)
+
+    # elif directoryType == &quot;LDAP&quot;:
+    #     authDN = kwds.pop(&quot;authDN&quot;, &quot;&quot;)
+    #     password = kwds.pop(&quot;password&quot;, &quot;&quot;)
+    #     if authDN and password:
+    #         creds = UsernamePassword(authDN, password)
+    #     else:
+    #         creds = None
+    #     kwds[&quot;credentials&quot;] = creds
+    #     debug = kwds.pop(&quot;debug&quot;, &quot;&quot;)
+    #     primaryDirectory = LDAPDirectoryService(
+    #         *args, _debug=debug, **kwds
+    #     )
+
+    # elif directoryType == &quot;XML&quot;:
+    #     path = kwds.pop(&quot;path&quot;, &quot;&quot;)
+    #     if not path or not os.path.exists(path):
+    #         log.error(&quot;Path not found for XML directory: {p}&quot;, p=path)
+    #     fp = FilePath(path)
+    #     primaryDirectory = XMLDirectoryService(fp, *args, **kwds)
+
+    # else:
+    #     log.error(&quot;Invalid DirectoryType: {dt}&quot;, dt=directoryType)
+
</ins><span class="cx">     #
</span><span class="cx">     # Setup the Augment Service
</span><span class="cx">     #
</span><span class="lines">@@ -522,15 +542,12 @@
</span><span class="cx">             setproctitle(&quot;CalendarServer Directory Proxy Service&quot;)
</span><span class="cx"> 
</span><span class="cx">         try:
</span><del>-            print(&quot;XZZZY AAA&quot;)
</del><span class="cx">             directory = directoryFromConfig(config)
</span><del>-            print(&quot;XZZZY BBB&quot;)
</del><span class="cx">         except Exception as e:
</span><span class="cx">             log.error(&quot;Failed to create directory service&quot;, error=e)
</span><span class="cx">             raise
</span><span class="cx"> 
</span><span class="cx">         log.info(&quot;Created directory service&quot;)
</span><del>-        print(&quot;XZZZY CCCC&quot;)
</del><span class="cx"> 
</span><span class="cx">         return strPortsService(
</span><span class="cx">             &quot;unix:{path}:mode=660&quot;.format(
</span></span></pre>
</div>
</div>

</body>
</html>