<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[11877] CalendarServer/trunk/twext/who/test/test_directory.py</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.calendarserver.org//changeset/11877">11877</a></dd>
<dt>Author</dt> <dd>wsanchez@apple.com</dd>
<dt>Date</dt> <dd>2013-11-01 16:55:30 -0700 (Fri, 01 Nov 2013)</dd>
</dl>
<h3>Log Message</h3>
<pre>_testRecord -> makeRecord</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#CalendarServertrunktwextwhotesttest_directorypy">CalendarServer/trunk/twext/who/test/test_directory.py</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="CalendarServertrunktwextwhotesttest_directorypy"></a>
<div class="modfile"><h4>Modified: CalendarServer/trunk/twext/who/test/test_directory.py (11876 => 11877)</h4>
<pre class="diff"><span>
<span class="info">--- CalendarServer/trunk/twext/who/test/test_directory.py 2013-11-01 23:54:27 UTC (rev 11876)
+++ CalendarServer/trunk/twext/who/test/test_directory.py 2013-11-01 23:55:30 UTC (rev 11877)
</span><span class="lines">@@ -237,7 +237,7 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx">
</span><del>- def _testRecord(self, fields=None, service=None):
</del><ins>+ def makeRecord(self, fields=None, service=None):
</ins><span class="cx"> if fields is None:
</span><span class="cx"> fields = self.fields_wsanchez
</span><span class="cx"> if service is None:
</span><span class="lines">@@ -246,7 +246,7 @@
</span><span class="cx">
</span><span class="cx">
</span><span class="cx"> def test_interface(self):
</span><del>- record = self._testRecord()
</del><ins>+ record = self.makeRecord()
</ins><span class="cx"> try:
</span><span class="cx"> verifyObject(IDirectoryRecord, record)
</span><span class="cx"> except BrokenMethodImplementation as e:
</span><span class="lines">@@ -255,7 +255,7 @@
</span><span class="cx">
</span><span class="cx"> def test_init(self):
</span><span class="cx"> service = self.service()
</span><del>- wsanchez = self._testRecord(self.fields_wsanchez, service=service)
</del><ins>+ wsanchez = self.makeRecord(self.fields_wsanchez, service=service)
</ins><span class="cx">
</span><span class="cx"> self.assertEquals(wsanchez.service, service)
</span><span class="cx"> self.assertEquals(wsanchez.fields, self.fields_wsanchez)
</span><span class="lines">@@ -264,49 +264,49 @@
</span><span class="cx"> def test_initWithNoUID(self):
</span><span class="cx"> fields = self.fields_wsanchez.copy()
</span><span class="cx"> del fields[FieldName.uid]
</span><del>- self.assertRaises(ValueError, self._testRecord, fields)
</del><ins>+ self.assertRaises(ValueError, self.makeRecord, fields)
</ins><span class="cx">
</span><span class="cx"> fields = self.fields_wsanchez.copy()
</span><span class="cx"> fields[FieldName.uid] = ""
</span><del>- self.assertRaises(ValueError, self._testRecord, fields)
</del><ins>+ self.assertRaises(ValueError, self.makeRecord, fields)
</ins><span class="cx">
</span><span class="cx">
</span><span class="cx"> def test_initWithNoRecordType(self):
</span><span class="cx"> fields = self.fields_wsanchez.copy()
</span><span class="cx"> del fields[FieldName.recordType]
</span><del>- self.assertRaises(ValueError, self._testRecord, fields)
</del><ins>+ self.assertRaises(ValueError, self.makeRecord, fields)
</ins><span class="cx">
</span><span class="cx"> fields = self.fields_wsanchez.copy()
</span><span class="cx"> fields[FieldName.recordType] = ""
</span><del>- self.assertRaises(ValueError, self._testRecord, fields)
</del><ins>+ self.assertRaises(ValueError, self.makeRecord, fields)
</ins><span class="cx">
</span><span class="cx">
</span><span class="cx"> def test_initWithNoShortNames(self):
</span><span class="cx"> fields = self.fields_wsanchez.copy()
</span><span class="cx"> del fields[FieldName.shortNames]
</span><del>- self.assertRaises(ValueError, self._testRecord, fields)
</del><ins>+ self.assertRaises(ValueError, self.makeRecord, fields)
</ins><span class="cx">
</span><span class="cx"> fields = self.fields_wsanchez.copy()
</span><span class="cx"> fields[FieldName.shortNames] = ()
</span><del>- self.assertRaises(ValueError, self._testRecord, fields)
</del><ins>+ self.assertRaises(ValueError, self.makeRecord, fields)
</ins><span class="cx">
</span><span class="cx"> fields = self.fields_wsanchez.copy()
</span><span class="cx"> fields[FieldName.shortNames] = ("",)
</span><del>- self.assertRaises(ValueError, self._testRecord, fields)
</del><ins>+ self.assertRaises(ValueError, self.makeRecord, fields)
</ins><span class="cx">
</span><span class="cx"> fields = self.fields_wsanchez.copy()
</span><span class="cx"> fields[FieldName.shortNames] = ("wsanchez", "")
</span><del>- self.assertRaises(ValueError, self._testRecord, fields)
</del><ins>+ self.assertRaises(ValueError, self.makeRecord, fields)
</ins><span class="cx">
</span><span class="cx">
</span><span class="cx"> def test_initWithBogusRecordType(self):
</span><span class="cx"> fields = self.fields_wsanchez.copy()
</span><span class="cx"> fields[FieldName.recordType] = object()
</span><del>- self.assertRaises(ValueError, self._testRecord, fields)
</del><ins>+ self.assertRaises(ValueError, self.makeRecord, fields)
</ins><span class="cx">
</span><span class="cx">
</span><span class="cx"> def test_initNormalize(self):
</span><del>- sagen = self._testRecord(self.fields_sagen)
</del><ins>+ sagen = self.makeRecord(self.fields_sagen)
</ins><span class="cx">
</span><span class="cx"> self.assertEquals(
</span><span class="cx"> sagen.fields[FieldName.emailAddresses],
</span><span class="lines">@@ -320,10 +320,10 @@
</span><span class="cx">
</span><span class="cx"> plugh = DirectoryService("plugh")
</span><span class="cx">
</span><del>- wsanchez = self._testRecord(self.fields_wsanchez)
- wsanchezmod = self._testRecord(self.fields_wsanchez, plugh)
- glyph = self._testRecord(self.fields_glyph)
- glyphmod = self._testRecord(fields_glyphmod)
</del><ins>+ wsanchez = self.makeRecord(self.fields_wsanchez)
+ wsanchezmod = self.makeRecord(self.fields_wsanchez, plugh)
+ glyph = self.makeRecord(self.fields_glyph)
+ glyphmod = self.makeRecord(fields_glyphmod)
</ins><span class="cx">
</span><span class="cx"> self.assertEquals(wsanchez, wsanchez)
</span><span class="cx"> self.assertNotEqual(wsanchez, glyph)
</span><span class="lines">@@ -333,7 +333,7 @@
</span><span class="cx">
</span><span class="cx">
</span><span class="cx"> def test_attributeAccess(self):
</span><del>- wsanchez = self._testRecord(self.fields_wsanchez)
</del><ins>+ wsanchez = self.makeRecord(self.fields_wsanchez)
</ins><span class="cx">
</span><span class="cx"> self.assertEquals(
</span><span class="cx"> wsanchez.recordType,
</span><span class="lines">@@ -355,7 +355,7 @@
</span><span class="cx">
</span><span class="cx"> @inlineCallbacks
</span><span class="cx"> def test_members(self):
</span><del>- wsanchez = self._testRecord(self.fields_wsanchez)
</del><ins>+ wsanchez = self.makeRecord(self.fields_wsanchez)
</ins><span class="cx"> self.assertEquals(
</span><span class="cx"> set((yield wsanchez.members())),
</span><span class="cx"> set()
</span><span class="lines">@@ -371,16 +371,16 @@
</span><span class="cx">
</span><span class="cx"> class DirectoryRecordTest(unittest.TestCase, BaseDirectoryRecordTest):
</span><span class="cx"> def test_members(self):
</span><del>- wsanchez = self._testRecord(self.fields_wsanchez)
</del><ins>+ wsanchez = self.makeRecord(self.fields_wsanchez)
</ins><span class="cx"> self.assertEquals(
</span><span class="cx"> set((yield wsanchez.members())),
</span><span class="cx"> set()
</span><span class="cx"> )
</span><span class="cx">
</span><del>- staff = self._testRecord(self.fields_staff)
</del><ins>+ staff = self.makeRecord(self.fields_staff)
</ins><span class="cx"> self.assertFailure(staff.members(), NotImplementedError)
</span><span class="cx">
</span><span class="cx">
</span><span class="cx"> def test_groups(self):
</span><del>- wsanchez = self._testRecord(self.fields_wsanchez)
</del><ins>+ wsanchez = self.makeRecord(self.fields_wsanchez)
</ins><span class="cx"> self.assertFailure(wsanchez.groups(), NotImplementedError)
</span></span></pre>
</div>
</div>
</body>
</html>