<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[12664] CalendarServer/trunk/calendarserver/webadmin/logs.py</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.calendarserver.org//changeset/12664">12664</a></dd>
<dt>Author</dt> <dd>wsanchez@apple.com</dd>
<dt>Date</dt> <dd>2014-02-11 18:06:50 -0800 (Tue, 11 Feb 2014)</dd>
</dl>

<h3>Log Message</h3>
<pre>Try to be event-based.  Fail.</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#CalendarServertrunkcalendarserverwebadminlogspy">CalendarServer/trunk/calendarserver/webadmin/logs.py</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="CalendarServertrunkcalendarserverwebadminlogspy"></a>
<div class="modfile"><h4>Modified: CalendarServer/trunk/calendarserver/webadmin/logs.py (12663 => 12664)</h4>
<pre class="diff"><span>
<span class="info">--- CalendarServer/trunk/calendarserver/webadmin/logs.py        2014-02-12 00:30:58 UTC (rev 12663)
+++ CalendarServer/trunk/calendarserver/webadmin/logs.py        2014-02-12 02:06:50 UTC (rev 12664)
</span><span class="lines">@@ -31,8 +31,7 @@
</span><span class="cx"> from zope.interface import implementer
</span><span class="cx"> 
</span><span class="cx"> from twisted.python.log import FileLogObserver
</span><del>-from twisted.internet.defer import succeed
-from twisted.internet.task import deferLater
</del><ins>+from twisted.internet.defer import Deferred, succeed
</ins><span class="cx"> 
</span><span class="cx"> from txweb2.stream import IByteStream, fallbackSplit
</span><span class="cx"> from txweb2.resource import Resource
</span><span class="lines">@@ -92,20 +91,20 @@
</span><span class="cx">     def __init__(self):
</span><span class="cx">         Resource.__init__(self)
</span><span class="cx"> 
</span><ins>+        events = deque(maxlen=400)
</ins><span class="cx"> 
</span><del>-    @property
-    def events(self):
-        if not hasattr(self, &quot;_buffer&quot;):
-            buffer = deque(maxlen=400)
</del><ins>+        observers = (
+            AccessLogObserver(events),
+            BufferingLogObserver(events),
+        )
</ins><span class="cx"> 
</span><del>-            AccessLogObserver(buffer).start()
-            BufferingLogObserver(buffer).start()
</del><ins>+        for observer in observers:
+            observer.start()
</ins><span class="cx"> 
</span><del>-            self._buffer = buffer
</del><ins>+        self.events = events
+        self.observers = observers
</ins><span class="cx"> 
</span><del>-        return self._buffer
</del><span class="cx"> 
</span><del>-
</del><span class="cx">     def render(self, request):
</span><span class="cx">         start = request.headers.getRawHeaders(&quot;last-event-id&quot;)
</span><span class="cx"> 
</span><span class="lines">@@ -116,7 +115,7 @@
</span><span class="cx">                 start = None
</span><span class="cx"> 
</span><span class="cx">         response = Response()
</span><del>-        response.stream = LogEventStream(self, start)
</del><ins>+        response.stream = LogEventStream(self, start=start)
</ins><span class="cx">         response.headers.setHeader(
</span><span class="cx">             &quot;content-type&quot;, MimeType.fromString(&quot;text/event-stream&quot;)
</span><span class="cx">         )
</span><span class="lines">@@ -190,9 +189,20 @@
</span><span class="cx">                 textAsEvent(marker, eventID=0, eventClass=u&quot;server&quot;)
</span><span class="cx">             )
</span><span class="cx"> 
</span><del>-        return deferLater(self._reactor, 1, self.read, _retrying=True)
</del><ins>+        return succeed(None)
</ins><span class="cx"> 
</span><ins>+        # def readAgain(_):
+        #     return self.read()
</ins><span class="cx"> 
</span><ins>+        # d = Deferred()
+        # d.addCallback(readAgain)
+
+        # for observer in self._source.observers:
+        #     observer.registerDeferred(d)
+
+        # return d
+
+
</ins><span class="cx">     def split(self, point):
</span><span class="cx">         return fallbackSplit(self, point)
</span><span class="cx"> 
</span><span class="lines">@@ -214,6 +224,8 @@
</span><span class="cx"> 
</span><span class="cx"> 
</span><span class="cx">     def __init__(self, buffer):
</span><ins>+        self._junk = file(&quot;/tmp/junk&quot;, &quot;a&quot;)
+
</ins><span class="cx">         class FooIO(object):
</span><span class="cx">             def write(_, s):
</span><span class="cx">                 self._lastMessage = s
</span><span class="lines">@@ -225,19 +237,37 @@
</span><span class="cx"> 
</span><span class="cx">         self.lastMessage = None
</span><span class="cx">         self._buffer = buffer
</span><ins>+        self._waiting = []
</ins><span class="cx"> 
</span><span class="cx"> 
</span><span class="cx">     def emit(self, event):
</span><span class="cx">         self._buffer.append((self, u&quot;server&quot;, event))
</span><span class="cx"> 
</span><ins>+        self._junk.write(&quot;emit: {0!r} on {1}\n&quot;.format(self._waiting, self))
+        self._junk.flush()
</ins><span class="cx"> 
</span><ins>+        while self._waiting:
+            d = self._waiting.pop(0)
+            self._junk.write(&quot;calling: {0}\n&quot;.format(d))
+            self._junk.flush()
+            d.callback(None)
+            self._junk.write(&quot;called: {0}\n&quot;.format(d))
+            self._junk.flush()
+
+
</ins><span class="cx">     def formatEvent(self, event):
</span><span class="cx">         self._lastMessage = None
</span><span class="cx">         FileLogObserver.emit(self, event)
</span><span class="cx">         return self._lastMessage
</span><span class="cx"> 
</span><span class="cx"> 
</span><ins>+    def registerDeferred(self, d):
+        self._waiting.append(d)
+        self._junk.write(&quot;Registered: {0} on {1}\n&quot;.format(self._waiting, self))
+        self._junk.flush()
</ins><span class="cx"> 
</span><ins>+
+
</ins><span class="cx"> class AccessLogObserver(CommonAccessLoggingObserverExtensions):
</span><span class="cx">     &quot;&quot;&quot;
</span><span class="cx">     Log observer that captures apache-style access log text entries in a
</span><span class="lines">@@ -261,7 +291,11 @@
</span><span class="cx">         self._buffer.append((self, u&quot;access&quot;, event))
</span><span class="cx"> 
</span><span class="cx"> 
</span><ins>+    def registerDeferred(self, d):
+        pass
</ins><span class="cx"> 
</span><ins>+
+
</ins><span class="cx"> def textAsEvent(text, eventID=None, eventClass=None):
</span><span class="cx">     event = []
</span><span class="cx"> 
</span></span></pre>
</div>
</div>

</body>
</html>