<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[11976] CalendarServer/trunk/twext/who/test/test_directory.py</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.calendarserver.org//changeset/11976">11976</a></dd>
<dt>Author</dt> <dd>wsanchez@apple.com</dd>
<dt>Date</dt> <dd>2013-11-19 14:51:43 -0800 (Tue, 19 Nov 2013)</dd>
</dl>

<h3>Log Message</h3>
<pre>More refactor</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#CalendarServertrunktwextwhotesttest_directorypy">CalendarServer/trunk/twext/who/test/test_directory.py</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="CalendarServertrunktwextwhotesttest_directorypy"></a>
<div class="modfile"><h4>Modified: CalendarServer/trunk/twext/who/test/test_directory.py (11975 => 11976)</h4>
<pre class="diff"><span>
<span class="info">--- CalendarServer/trunk/twext/who/test/test_directory.py        2013-11-19 22:38:56 UTC (rev 11975)
+++ CalendarServer/trunk/twext/who/test/test_directory.py        2013-11-19 22:51:43 UTC (rev 11976)
</span><span class="lines">@@ -36,6 +36,54 @@
</span><span class="cx"> 
</span><span class="cx"> 
</span><span class="cx"> 
</span><ins>+class StubDirectoryService(DirectoryService):
+    &quot;&quot;&quot;
+    Stub directory service with some built-in records and an implementation
+    of C{recordsFromNonCompoundExpression}.
+    &quot;&quot;&quot;
+
+    def __init__(self, realmName):
+        DirectoryService.__init__(self, realmName)
+
+        self.records = RecordStorage(self, DirectoryRecord)
+
+
+    def recordsFromExpression(self, expression):
+        self.seenExpressions = []
+
+        return DirectoryService.recordsFromExpression(self, expression)
+
+
+    def recordsFromNonCompoundExpression(self, expression, records=None):
+        &quot;&quot;&quot;
+        This implementation handles three expressions:
+
+        The expression C{u&quot;None&quot;} will match no records.
+
+        The expressions C{u&quot;twistedmatrix.com&quot;} and C{u&quot;calendarserver.org&quot;}
+        will match records that have an email address ending with the
+        given expression.
+        &quot;&quot;&quot;
+        self.seenExpressions.append(expression)
+
+        if expression == u&quot;None&quot;:
+            return succeed([])
+
+        if expression in (u&quot;twistedmatrix.com&quot;, u&quot;calendarserver.org&quot;):
+            result = []
+            for record in self.records:
+                for email in record.emailAddresses:
+                    if email.endswith(expression):
+                        result.append(record)
+                        break
+            return succeed(result)
+
+        return DirectoryService.recordsFromNonCompoundExpression(
+            self, expression, records=records
+        )
+
+
+
</ins><span class="cx"> class ServiceMixIn(object):
</span><span class="cx">     &quot;&quot;&quot;
</span><span class="cx">     MixIn that sets up a service appropriate for testing.
</span><span class="lines">@@ -216,7 +264,7 @@
</span><span class="cx">     &quot;&quot;&quot;
</span><span class="cx">     Tests for L{DirectoryService.recordsFromExpression}.
</span><span class="cx">     &quot;&quot;&quot;
</span><del>-    serviceClass = DirectoryService
</del><ins>+    serviceClass = StubDirectoryService
</ins><span class="cx">     directoryRecordClass = DirectoryRecord
</span><span class="cx"> 
</span><span class="cx">     @inlineCallbacks
</span><span class="lines">@@ -775,62 +823,6 @@
</span><span class="cx"> 
</span><span class="cx"> 
</span><span class="cx"> 
</span><del>-class RFNCEMixIn(object):
-    &quot;&quot;&quot;
-    Mixin class that implements C{recordsFromNonCompoundExpression}.
-
-    This class also sets a C{seenExpressions} attribute to C{[]} when
-    C{recordsFromExpression} is called and appends the expressions seen when
-    C{recordsFromNonCompoundExpression} is subsequently called to that list.
-    &quot;&quot;&quot;
-
-    def recordsFromExpression(self, expression):
-        self.seenExpressions = []
-
-        return DirectoryService.recordsFromExpression(self, expression)
-
-
-    def recordsFromNonCompoundExpression(self, expression, records=None):
-        &quot;&quot;&quot;
-        This implementation handles three expressions:
-
-        The expression C{u&quot;None&quot;} will match no records.
-
-        The expressions C{u&quot;twistedmatrix.com&quot;} and C{u&quot;calendarserver.org&quot;}
-        will match records that have an email address ending with the
-        given expression.
-        &quot;&quot;&quot;
-        self.seenExpressions.append(expression)
-
-        if expression == u&quot;None&quot;:
-            return succeed([])
-
-        if expression in (u&quot;twistedmatrix.com&quot;, u&quot;calendarserver.org&quot;):
-            result = []
-            for record in self.records:
-                for email in record.emailAddresses:
-                    if email.endswith(expression):
-                        result.append(record)
-                        break
-            return succeed(result)
-
-        return DirectoryService.recordsFromNonCompoundExpression(
-            self, expression, records=records
-        )
-
-
-class StubDirectoryService(RFNCEMixIn, DirectoryService):
-    &quot;&quot;&quot;
-    Stub directory service with some built-in records and an implementation
-    of C{recordsFromNonCompoundExpression}.
-    &quot;&quot;&quot;
-
-    def __init__(self):
-        DirectoryService.__init__(self, u&quot;Stub&quot;)
-
-        self.records = RecordStorage(self, DirectoryRecord)
-
-
</del><span class="cx"> class RecordStorage(object):
</span><span class="cx">     &quot;&quot;&quot;
</span><span class="cx">     Container for directory records.
</span></span></pre>
</div>
</div>

</body>
</html>