<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[12343] twext/trunk/twext/who/ldap</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.calendarserver.org//changeset/12343">12343</a></dd>
<dt>Author</dt> <dd>wsanchez@apple.com</dd>
<dt>Date</dt> <dd>2014-01-14 15:12:16 -0800 (Tue, 14 Jan 2014)</dd>
</dl>

<h3>Log Message</h3>
<pre>Clean up constants</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#twexttrunktwextwholdap_constantspy">twext/trunk/twext/who/ldap/_constants.py</a></li>
<li><a href="#twexttrunktwextwholdaptesttest_servicepy">twext/trunk/twext/who/ldap/test/test_service.py</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="twexttrunktwextwholdap_constantspy"></a>
<div class="modfile"><h4>Modified: twext/trunk/twext/who/ldap/_constants.py (12342 => 12343)</h4>
<pre class="diff"><span>
<span class="info">--- twext/trunk/twext/who/ldap/_constants.py        2014-01-14 23:10:25 UTC (rev 12342)
+++ twext/trunk/twext/who/ldap/_constants.py        2014-01-14 23:12:16 UTC (rev 12343)
</span><span class="lines">@@ -114,12 +114,14 @@
</span><span class="cx"> 
</span><span class="cx"> class RFC4519Attribute(Values):
</span><span class="cx">     &quot;&quot;&quot;
</span><ins>+    User application attributes.
+
</ins><span class="cx">     See U{RFC 4519, section 2&lt;http://tools.ietf.org/html/rfc4519#section-2&gt;}.
</span><span class="cx">     &quot;&quot;&quot;
</span><span class="cx">     businessCategory = ValueConstant(u&quot;businessCategory&quot;)
</span><span class="cx">     c = ValueConstant(u&quot;c&quot;)  # country name
</span><span class="cx">     cn = ValueConstant(u&quot;cn&quot;)  # common name
</span><del>-    domainComponent = ValueConstant(u&quot;dc&quot;)  # domain component
</del><ins>+    dc = ValueConstant(u&quot;dc&quot;)  # domain component
</ins><span class="cx">     description = ValueConstant(u&quot;description&quot;)
</span><span class="cx">     destinationIndicator = ValueConstant(u&quot;destinationIndicator&quot;)
</span><span class="cx">     distinguishedName = ValueConstant(u&quot;distinguishedName&quot;)
</span><span class="lines">@@ -131,7 +133,7 @@
</span><span class="cx">     houseIdentifier = ValueConstant(u&quot;houseIdentifier&quot;)
</span><span class="cx">     initials = ValueConstant(u&quot;initials&quot;)
</span><span class="cx">     internationalISDNNumber = ValueConstant(u&quot;internationalISDNNumber&quot;)
</span><del>-    l = ValueConstant(u&quot;l&quot;)  # location name
</del><ins>+    l = ValueConstant(u&quot;l&quot;)  # locality name
</ins><span class="cx">     member = ValueConstant(u&quot;member&quot;)
</span><span class="cx">     name = ValueConstant(u&quot;name&quot;)
</span><span class="cx">     o = ValueConstant(u&quot;o&quot;)  # organization name
</span><span class="lines">@@ -164,7 +166,9 @@
</span><span class="cx"> 
</span><span class="cx"> class RFC4519ObjectClass(Values):
</span><span class="cx">     &quot;&quot;&quot;
</span><del>-    See U{RFC 4519, section 3&lt;http://tools.ietf.org/html/rfc4519#section-2&gt;}.
</del><ins>+    User application object classes.
+
+    See U{RFC 4519, section 3&lt;http://tools.ietf.org/html/rfc4519#section-3&gt;}.
</ins><span class="cx">     &quot;&quot;&quot;
</span><span class="cx">     applicationProcess = ValueConstant(u&quot;applicationProcess&quot;)
</span><span class="cx">     country = ValueConstant(u&quot;country&quot;)
</span><span class="lines">@@ -183,14 +187,74 @@
</span><span class="cx"> 
</span><span class="cx"> 
</span><span class="cx"> 
</span><ins>+# class RFC2307Attribute(Values):
+#     &quot;&quot;&quot;
+#     Network Information Service attributes.
+
+#     See U{RFC 2307, section 2.2
+#     &lt;http://tools.ietf.org/html/rfc2307#section-2.2&gt;}.
+#     &quot;&quot;&quot;
+#     uidNumber = ValueConstant(u&quot;uidNumber&quot;)
+#     gidNumber = ValueConstant(u&quot;gidNumber&quot;)
+#     gecos = ValueConstant(u&quot;gecos&quot;)
+#     homeDirectory = ValueConstant(u&quot;homeDirectory&quot;)
+#     loginShell = ValueConstant(u&quot;loginShell&quot;)
+#     shadowLastChange = ValueConstant(u&quot;shadowLastChange&quot;)
+#     shadowMin = ValueConstant(u&quot;shadowMin&quot;)
+#     shadowMax = ValueConstant(u&quot;shadowMax&quot;)
+#     shadowWarning = ValueConstant(u&quot;shadowWarning&quot;)
+#     shadowInactive = ValueConstant(u&quot;shadowInactive&quot;)
+#     shadowExpire = ValueConstant(u&quot;shadowExpire&quot;)
+#     shadowFlag = ValueConstant(u&quot;shadowFlag&quot;)
+#     memberUid = ValueConstant(u&quot;memberUid&quot;)
+#     memberNisNetgroup = ValueConstant(u&quot;memberNisNetgroup&quot;)
+#     nisNetgroupTriple = ValueConstant(u&quot;nisNetgroupTriple&quot;)
+#     ipServicePort = ValueConstant(u&quot;ipServicePort&quot;)
+#     ipServiceProtocol = ValueConstant(u&quot;ipServiceProtocol&quot;)
+#     ipProtocolNumber = ValueConstant(u&quot;ipProtocolNumber&quot;)
+#     oncRpcNumber = ValueConstant(u&quot;oncRpcNumber&quot;)
+#     ipHostNumber = ValueConstant(u&quot;ipHostNumber&quot;)
+#     ipNetworkNumber = ValueConstant(u&quot;ipNetworkNumber&quot;)
+#     ipNetmaskNumber = ValueConstant(u&quot;ipNetmaskNumber&quot;)
+#     macAddress = ValueConstant(u&quot;macAddress&quot;)
+#     bootParameter = ValueConstant(u&quot;bootParameter&quot;)
+#     bootFile = ValueConstant(u&quot;bootFile&quot;)
+#     nisMapName = ValueConstant(u&quot;nisMapName&quot;)
+#     nisMapEntry = ValueConstant(u&quot;nisMapEntry&quot;)
+
+
+
+# class RFC2307ObjectClass(Values):
+#     &quot;&quot;&quot;
+#     Network Information Service object classes.
+
+#     See U{RFC 2307, section 2.3
+#     &lt;http://tools.ietf.org/html/rfc2307#section-2.3&gt;}.
+#     &quot;&quot;&quot;
+#     posixAccount = ValueConstant(u&quot;posixAccount&quot;)
+#     shadowAccount = ValueConstant(u&quot;shadowAccount&quot;)
+#     posixGroup = ValueConstant(u&quot;posixGroup&quot;)
+#     ipService = ValueConstant(u&quot;ipService&quot;)
+#     ipProtocol = ValueConstant(u&quot;ipProtocol&quot;)
+#     oncRpc = ValueConstant(u&quot;oncRpc&quot;)
+#     ipHost = ValueConstant(u&quot;ipHost&quot;)
+#     ipNetwork = ValueConstant(u&quot;ipNetwork&quot;)
+#     nisNetgroup = ValueConstant(u&quot;nisNetgroup&quot;)
+#     nisMap = ValueConstant(u&quot;nisMap&quot;)
+#     nisObject = ValueConstant(u&quot;nisObject&quot;)
+#     ieee802Device = ValueConstant(u&quot;ieee802Device&quot;)
+#     bootableDevice = ValueConstant(u&quot;bootableDevice&quot;)
+
+
+
</ins><span class="cx"> class WhoAttribute(Values):
</span><span class="cx">     &quot;&quot;&quot;
</span><span class="cx">     Attributes needed internally that have no standard name.
</span><span class="cx">     &quot;&quot;&quot;
</span><del>-    who_uid = ValueConstant(u&quot;__who_uid&quot;)
-    generatedUUID = ValueConstant(u&quot;__who_guid&quot;)
-    objectClass = ValueConstant(u&quot;__who_objectClass&quot;)
-    mail = ValueConstant(u&quot;__who_mail&quot;)
</del><ins>+    who_uid = ValueConstant(u&quot;__who_uid__&quot;)
+    generatedUUID = ValueConstant(u&quot;entryUUID&quot;)
+    objectClass = ValueConstant(u&quot;objectClass&quot;)
+    mail = ValueConstant(u&quot;mail&quot;)
</ins><span class="cx"> 
</span><span class="cx"> 
</span><span class="cx"> 
</span><span class="lines">@@ -204,8 +268,7 @@
</span><span class="cx"> ))
</span><span class="cx"> 
</span><span class="cx"> 
</span><del>-# http://tools.ietf.org/html/rfc4524
</del><ins>+# http://tools.ietf.org/html/rfc4524 COSINE
</ins><span class="cx"> # http://tools.ietf.org/html/rfc3112 auth schemes
</span><del>-# http://tools.ietf.org/html/rfc2307
-# http://tools.ietf.org/html/rfc2798
</del><ins>+# http://tools.ietf.org/html/rfc2798 inetOrgPerson
</ins><span class="cx"> # http://tools.ietf.org/html/rfc2739 calendar
</span></span></pre></div>
<a id="twexttrunktwextwholdaptesttest_servicepy"></a>
<div class="modfile"><h4>Modified: twext/trunk/twext/who/ldap/test/test_service.py (12342 => 12343)</h4>
<pre class="diff"><span>
<span class="info">--- twext/trunk/twext/who/ldap/test/test_service.py        2014-01-14 23:10:25 UTC (rev 12342)
+++ twext/trunk/twext/who/ldap/test/test_service.py        2014-01-14 23:12:16 UTC (rev 12343)
</span><span class="lines">@@ -30,9 +30,6 @@
</span><span class="cx"> from twisted.trial import unittest
</span><span class="cx"> 
</span><span class="cx"> from ...idirectory import QueryNotSupportedError, FieldName as BaseFieldName
</span><del>-# from ...expression import (
-#     CompoundExpression, Operand, MatchExpression, MatchType, MatchFlags
-# )
</del><span class="cx"> from .._service import (
</span><span class="cx">     DEFAULT_FIELDNAME_MAP, DEFAULT_RECORDTYPE_MAP,
</span><span class="cx">     LDAPBindAuthError,
</span></span></pre>
</div>
</div>

</body>
</html>