<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[13185] twext/trunk</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.calendarserver.org//changeset/13185">13185</a></dd>
<dt>Author</dt> <dd>wsanchez@apple.com</dd>
<dt>Date</dt> <dd>2014-04-07 17:32:59 -0700 (Mon, 07 Apr 2014)</dd>
</dl>

<h3>Log Message</h3>
<pre>Stop parsing requirements in setup.py, because dstufft says so.</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#twexttrunkbin_buildsh">twext/trunk/bin/_build.sh</a></li>
<li><a href="#twexttrunksetuppy">twext/trunk/setup.py</a></li>
</ul>

<h3>Added Paths</h3>
<ul>
<li><a href="#twexttrunkrequirementstxt">twext/trunk/requirements.txt</a></li>
</ul>

<h3>Removed Paths</h3>
<ul>
<li>twext/trunk/requirements/</li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="twexttrunkbin_buildsh"></a>
<div class="modfile"><h4>Modified: twext/trunk/bin/_build.sh (13184 => 13185)</h4>
<pre class="diff"><span>
<span class="info">--- twext/trunk/bin/_build.sh        2014-04-08 00:08:37 UTC (rev 13184)
+++ twext/trunk/bin/_build.sh        2014-04-08 00:32:59 UTC (rev 13185)
</span><span class="lines">@@ -620,26 +620,21 @@
</span><span class="cx">   if [ -d &quot;${wd}/requirements/cache&quot; ]; then
</span><span class="cx">     pip_install=&quot;pip_install_from_cache&quot;;
</span><span class="cx">   else
</span><del>-    pip_install=&quot;pip_install&quot;;
</del><ins>+    pip_install=&quot;pip_download_and_install&quot;;
</ins><span class="cx">   fi;
</span><span class="cx"> 
</span><del>-  for requirements in &quot;${wd}/requirements/py_&quot;*&quot;.txt&quot;; do
</del><ins>+  local requirements=&quot;${wd}/requirements.txt&quot;;
</ins><span class="cx"> 
</span><del>-    ruler &quot;Preparing Python requirements: ${requirements}&quot;;
-    echo &quot;&quot;;
</del><ins>+  ruler &quot;Preparing Python requirements&quot;;
+  echo &quot;&quot;;
+  &quot;${pip_install}&quot; &quot;--requirement=${requirements}&quot;;
</ins><span class="cx"> 
</span><del>-    if ! &quot;${pip_install}&quot; &quot;${requirements}&quot;; then
-      err=$?;
-      echo &quot;Unable to set up Python requirements: ${requirements}&quot;;
-      if [ &quot;${requirements#${wd}/requirements/py_opt_}&quot; != &quot;${requirements}&quot; ]; then
-        echo &quot;Requirements ${requirements} are optional; continuing.&quot;;
-      else
-        echo &quot;&quot;;
-        echo &quot;pip log: ${dev_home}/pip.log&quot;;
-        return 1;
-      fi;
</del><ins>+  for option in $(&quot;${python}&quot; -c 'import setup; print &quot;\n&quot;.join(setup.extras_requirements.keys())'); do
+    ruler &quot;Preparing Python requirements for optional feature: ${option}&quot;;
+    echo &quot;&quot;;
+    if ! &quot;${pip_install}&quot; &quot;--editable=.[${option}]&quot;; then
+      echo &quot;Feature ${option} is optional; continuing.&quot;;
</ins><span class="cx">     fi;
</span><del>-
</del><span class="cx">   done;
</span><span class="cx"> 
</span><span class="cx">   echo &quot;&quot;;
</span><span class="lines">@@ -647,21 +642,21 @@
</span><span class="cx"> 
</span><span class="cx"> 
</span><span class="cx"> pip_install_from_cache () {
</span><del>-  local requirements=&quot;$1&quot;; shift;
</del><ins>+  local require=&quot;$1&quot;; shift;
</ins><span class="cx"> 
</span><span class="cx">   &quot;${python}&quot; -m pip install                 \
</span><del>-    --requirement=&quot;${requirements}&quot;          \
-    --find-links &quot;${wd}/requirements/cache&quot;  \
</del><ins>+    &quot;${require}&quot;                             \
+    --find-links=&quot;${wd}/requirements/cache&quot;  \
</ins><span class="cx">     --no-index                               \
</span><span class="cx">     --log=&quot;${dev_home}/pip.log&quot;;
</span><span class="cx"> }
</span><span class="cx"> 
</span><span class="cx"> 
</span><del>-pip_install () {
-  local requirements=&quot;$1&quot;; shift;
</del><ins>+pip_download_and_install () {
+  local require=&quot;$1&quot;; shift;
</ins><span class="cx"> 
</span><span class="cx">   &quot;${python}&quot; -m pip install                  \
</span><del>-    --requirement=&quot;${requirements}&quot;           \
</del><ins>+    &quot;${require}&quot;                              \
</ins><span class="cx">     --download-cache=&quot;${dev_home}/pip_cache&quot;  \
</span><span class="cx">     --log=&quot;${dev_home}/pip.log&quot;;
</span><span class="cx"> }
</span></span></pre></div>
<a id="twexttrunkrequirementstxt"></a>
<div class="addfile"><h4>Added: twext/trunk/requirements.txt (0 => 13185)</h4>
<pre class="diff"><span>
<span class="info">--- twext/trunk/requirements.txt                                (rev 0)
+++ twext/trunk/requirements.txt        2014-04-08 00:32:59 UTC (rev 13185)
</span><span class="lines">@@ -0,0 +1,7 @@
</span><ins>+# Get our own dependencies
+-e .
+
+# Additional dependencies for development
+pyflakes
+docutils&gt;=0.11
+mockldap&gt;=0.1.4
</ins><span class="cx">Property changes on: twext/trunk/requirements.txt
</span><span class="cx">___________________________________________________________________
</span></span></pre></div>
<a id="svnmimetype"></a>
<div class="addfile"><h4>Added: svn:mime-type</h4></div>
<a id="twexttrunksetuppy"></a>
<div class="modfile"><h4>Modified: twext/trunk/setup.py (13184 => 13185)</h4>
<pre class="diff"><span>
<span class="info">--- twext/trunk/setup.py        2014-04-08 00:08:37 UTC (rev 13184)
+++ twext/trunk/setup.py        2014-04-08 00:32:59 UTC (rev 13185)
</span><span class="lines">@@ -20,12 +20,9 @@
</span><span class="cx"> 
</span><span class="cx"> import sys
</span><span class="cx"> import errno
</span><del>-from os import listdir, environ as environment
</del><span class="cx"> from os.path import dirname, abspath, join as joinpath
</span><del>-from itertools import chain
</del><span class="cx"> import subprocess
</span><span class="cx"> from setuptools import setup, find_packages as setuptools_find_packages
</span><del>-from pip.req import parse_requirements
</del><span class="cx"> 
</span><span class="cx"> 
</span><span class="cx"> 
</span><span class="lines">@@ -136,45 +133,32 @@
</span><span class="cx"> # Dependencies
</span><span class="cx"> #
</span><span class="cx"> 
</span><del>-reqs_extension = &quot;.txt&quot;
-reqs_opt_prefix = &quot;py_opt_&quot;
</del><ins>+setup_requirements = []
</ins><span class="cx"> 
</span><ins>+install_requirements = [
+    &quot;cffi==0.6&quot;,
+    &quot;twisted&gt;=13.2.0&quot;,
+]
</ins><span class="cx"> 
</span><del>-requirements_dir = joinpath(dirname(__file__), &quot;requirements&quot;)
</del><ins>+extras_requirements = {
+    # Database Abstraction Layer
+    &quot;DAL&quot;: [&quot;sqlparse==0.1.2&quot;],
</ins><span class="cx"> 
</span><ins>+    # LDAP
+    &quot;LDAP&quot;: [&quot;python-ldap&gt;=2.4.13&quot;],
</ins><span class="cx"> 
</span><del>-def read_requirements(reqs_filename):
-    return [
-        str(r.req) for r in
-        parse_requirements(joinpath(requirements_dir, reqs_filename))
-    ]
</del><ins>+    # OpenDirectory
+    &quot;OpenDirectory&quot;: [&quot;pyobjc-framework-OpenDirectory&gt;=2.5.1&quot;],
</ins><span class="cx"> 
</span><ins>+    # Oracle
+    &quot;Oracle&quot;: [&quot;cx_Oracle==5.1.2&quot;],
</ins><span class="cx"> 
</span><del>-setup_requirements = []
</del><ins>+    # Postgres
+    &quot;Postgres&quot;: [&quot;PyGreSQL==4.1.1&quot;],
+}
</ins><span class="cx"> 
</span><del>-install_requirements = read_requirements(&quot;py_base.txt&quot;)
</del><span class="cx"> 
</span><del>-extras_requirements = dict(
-    (
-        reqs_filename[len(reqs_opt_prefix):-len(reqs_extension)],
-        read_requirements(reqs_filename)
-    )
-    for reqs_filename in listdir(requirements_dir)
-    if (
-        reqs_filename.startswith(reqs_opt_prefix) and
-        reqs_filename.endswith(reqs_extension)
-    )
-)
</del><span class="cx"> 
</span><del>-# Requirements for development and testing
-develop_requirements = read_requirements(&quot;py_develop.txt&quot;)
-
-if environment.get(&quot;_DEVELOP_PROJECT_&quot;, None) == name:
-    install_requirements.extend(develop_requirements)
-    install_requirements.extend(chain(*extras_requirements.values()))
-
-
-
</del><span class="cx"> #
</span><span class="cx"> # Set up Extension modules that need to be built
</span><span class="cx"> #
</span></span></pre>
</div>
</div>

</body>
</html>