<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[13478] CalendarServer/trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.calendarserver.org//changeset/13478">13478</a></dd>
<dt>Author</dt> <dd>sagen@apple.com</dd>
<dt>Date</dt> <dd>2014-05-15 11:43:58 -0700 (Thu, 15 May 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Create augments.xml file(s) at startup, but also deal with them not being there if you're simply deleting an augment record.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#CalendarServertrunktwistedcaldavdirectoryaugmentpy">CalendarServer/trunk/twistedcaldav/directory/augment.py</a></li>
<li><a href="#CalendarServertrunktxdavwhotesttest_utilpy">CalendarServer/trunk/txdav/who/test/test_util.py</a></li>
<li><a href="#CalendarServertrunktxdavwhoutilpy">CalendarServer/trunk/txdav/who/util.py</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="CalendarServertrunktwistedcaldavdirectoryaugmentpy"></a>
<div class="modfile"><h4>Modified: CalendarServer/trunk/twistedcaldav/directory/augment.py (13477 => 13478)</h4>
<pre class="diff"><span>
<span class="info">--- CalendarServer/trunk/twistedcaldav/directory/augment.py 2014-05-15 16:09:15 UTC (rev 13477)
+++ CalendarServer/trunk/twistedcaldav/directory/augment.py 2014-05-15 18:43:58 UTC (rev 13478)
</span><span class="lines">@@ -440,7 +440,11 @@
</span><span class="cx">
</span><span class="cx"> def _doRemoveFromFile(self, xmlfile, uids):
</span><span class="cx">
</span><del>- _ignore_etree, augments_node = readXML(xmlfile)
</del><ins>+ try:
+ _ignore_etree, augments_node = readXML(xmlfile)
+ except IOError:
+ # If the file is missing, then removal is a no-op
+ return
</ins><span class="cx">
</span><span class="cx"> # Remove all UIDs present
</span><span class="cx"> changed = False
</span></span></pre></div>
<a id="CalendarServertrunktxdavwhotesttest_utilpy"></a>
<div class="modfile"><h4>Modified: CalendarServer/trunk/txdav/who/test/test_util.py (13477 => 13478)</h4>
<pre class="diff"><span>
<span class="info">--- CalendarServer/trunk/txdav/who/test/test_util.py 2014-05-15 16:09:15 UTC (rev 13477)
+++ CalendarServer/trunk/txdav/who/test/test_util.py 2014-05-15 18:43:58 UTC (rev 13478)
</span><span class="lines">@@ -62,15 +62,10 @@
</span><span class="cx"> sourceAccounts = sourceDir.child("accounts.xml")
</span><span class="cx"> accounts.setContent(sourceAccounts.getContent())
</span><span class="cx">
</span><del>- resources = destDir.child("resources.xml")
- sourceResources = sourceDir.child("resources.xml")
- resources.setContent(sourceResources.getContent())
</del><ins>+ # Note, don't create resources.xml nor augments.xml here,
+ # We'll test later on that they get created automatically.
</ins><span class="cx">
</span><del>- augments = destDir.child("augments.xml")
- sourceAugments = sourceDir.child("augments.xml")
- augments.setContent(sourceAugments.getContent())
</del><span class="cx">
</span><del>-
</del><span class="cx"> @inlineCallbacks
</span><span class="cx"> def test_directoryFromConfig(self):
</span><span class="cx">
</span><span class="lines">@@ -114,6 +109,12 @@
</span><span class="cx"> store = StubStore()
</span><span class="cx"> service = directoryFromConfig(config, store=store)
</span><span class="cx">
</span><ins>+ # Make sure XML files were created
+ dataRoot = FilePath(self.dataRoot)
+ self.assertTrue(dataRoot.child("accounts.xml").exists())
+ self.assertTrue(dataRoot.child("resources.xml").exists())
+ self.assertTrue(dataRoot.child("augments.xml").exists())
+
</ins><span class="cx"> # Inspect the directory service structure
</span><span class="cx"> self.assertTrue(isinstance(service, AugmentedDirectoryService))
</span><span class="cx"> self.assertTrue(isinstance(service._directory, AggregateDirectoryService))
</span></span></pre></div>
<a id="CalendarServertrunktxdavwhoutilpy"></a>
<div class="modfile"><h4>Modified: CalendarServer/trunk/txdav/who/util.py (13477 => 13478)</h4>
<pre class="diff"><span>
<span class="info">--- CalendarServer/trunk/txdav/who/util.py 2014-05-15 16:09:15 UTC (rev 13477)
+++ CalendarServer/trunk/txdav/who/util.py 2014-05-15 18:43:58 UTC (rev 13478)
</span><span class="lines">@@ -209,6 +209,12 @@
</span><span class="cx"> # Setup the Augment Service
</span><span class="cx"> #
</span><span class="cx"> if augmentServiceInfo.type:
</span><ins>+ for augmentFile in augmentServiceInfo.params.xmlFiles:
+ augmentFile = fullServerPath(dataRoot, augmentFile)
+ augmentFilePath = FilePath(augmentFile)
+ if not augmentFilePath.exists():
+ augmentFilePath.setContent(DEFAULT_AUGMENT_CONTENT)
+
</ins><span class="cx"> augmentClass = namedClass(augmentServiceInfo.type)
</span><span class="cx"> log.info(
</span><span class="cx"> "Configuring augment service of type: {augmentClass}",
</span><span class="lines">@@ -280,3 +286,8 @@
</span><span class="cx">
</span><span class="cx"> <directory realm="Realm"/>
</span><span class="cx"> """
</span><ins>+
+DEFAULT_AUGMENT_CONTENT = """<?xml version="1.0" encoding="utf-8"?>
+
+<augments/>
+"""
</ins></span></pre>
</div>
</div>
</body>
</html>