<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[13841] CalendarServer/trunk</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.calendarserver.org//changeset/13841">13841</a></dd>
<dt>Author</dt> <dd>sagen@apple.com</dd>
<dt>Date</dt> <dd>2014-08-05 16:11:29 -0700 (Tue, 05 Aug 2014)</dd>
</dl>

<h3>Log Message</h3>
<pre>Clean up directory service config; allow specifying of LDAP RDN and attribute mapping</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#CalendarServertrunkcalendarservertoolsutilpy">CalendarServer/trunk/calendarserver/tools/util.py</a></li>
<li><a href="#CalendarServertrunkconfcaldavdtestplist">CalendarServer/trunk/conf/caldavd-test.plist</a></li>
<li><a href="#CalendarServertrunkrequirementsstabletxt">CalendarServer/trunk/requirements-stable.txt</a></li>
<li><a href="#CalendarServertrunktwistedcaldavstdconfigpy">CalendarServer/trunk/twistedcaldav/stdconfig.py</a></li>
<li><a href="#CalendarServertrunktwistedcaldavtesttest_configpy">CalendarServer/trunk/twistedcaldav/test/test_config.py</a></li>
<li><a href="#CalendarServertrunktwistedcaldavupgradepy">CalendarServer/trunk/twistedcaldav/upgrade.py</a></li>
<li><a href="#CalendarServertrunktxdavwhogroupspy">CalendarServer/trunk/txdav/who/groups.py</a></li>
<li><a href="#CalendarServertrunktxdavwhoutilpy">CalendarServer/trunk/txdav/who/util.py</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="CalendarServertrunkcalendarservertoolsutilpy"></a>
<div class="modfile"><h4>Modified: CalendarServer/trunk/calendarserver/tools/util.py (13840 => 13841)</h4>
<pre class="diff"><span>
<span class="info">--- CalendarServer/trunk/calendarserver/tools/util.py        2014-08-05 22:49:28 UTC (rev 13840)
+++ CalendarServer/trunk/calendarserver/tools/util.py        2014-08-05 23:11:29 UTC (rev 13841)
</span><span class="lines">@@ -69,146 +69,6 @@
</span><span class="cx"> 
</span><span class="cx"> 
</span><span class="cx"> 
</span><del>-# def getDirectory(config=config):
-
-#     class MyDirectoryService (AggregateDirectoryService):
-#         def getPrincipalCollection(self):
-#             if not hasattr(self, &quot;_principalCollection&quot;):
-
-#                 if config.Notifications.Enabled:
-#                     # FIXME: NotifierFactory needs reference to the store in order
-#                     # to get a txn in order to create a Work item
-#                     notifierFactory = NotifierFactory(
-#                         None, config.ServerHostName,
-#                         config.Notifications.CoalesceSeconds,
-#                     )
-#                 else:
-#                     notifierFactory = None
-
-#                 # Need a data store
-#                 _newStore = CommonDataStore(FilePath(config.DocumentRoot),
-#                     notifierFactory, self, True, False)
-#                 if notifierFactory is not None:
-#                     notifierFactory.store = _newStore
-
-#                 #
-#                 # Instantiating a DirectoryCalendarHomeProvisioningResource with a directory
-#                 # will register it with the directory (still smells like a hack).
-#                 #
-#                 # We need that in order to locate calendar homes via the directory.
-#                 #
-#                 from twistedcaldav.directory.calendar import DirectoryCalendarHomeProvisioningResource
-#                 DirectoryCalendarHomeProvisioningResource(self, &quot;/calendars/&quot;, _newStore)
-
-#                 from twistedcaldav.directory.principal import DirectoryPrincipalProvisioningResource
-#                 self._principalCollection = DirectoryPrincipalProvisioningResource(&quot;/principals/&quot;, self)
-
-#             return self._principalCollection
-
-#         def setPrincipalCollection(self, coll):
-#             # See principal.py line 237:  self.directory.principalCollection = self
-#             pass
-
-#         principalCollection = property(getPrincipalCollection, setPrincipalCollection)
-
-#         def calendarHomeForRecord(self, record):
-#             principal = self.principalCollection.principalForRecord(record)
-#             if principal:
-#                 try:
-#                     return principal.calendarHome()
-#                 except AttributeError:
-#                     pass
-#             return None
-
-#         def calendarHomeForShortName(self, recordType, shortName):
-#             principal = self.principalCollection.principalForShortName(recordType, shortName)
-#             if principal:
-#                 return principal.calendarHome()
-#             return None
-
-#         def principalForCalendarUserAddress(self, cua):
-#             return self.principalCollection.principalForCalendarUserAddress(cua)
-
-#         def principalForUID(self, uid):
-#             return self.principalCollection.principalForUID(uid)
-
-#     # Load augment/proxy db classes now
-#     if config.AugmentService.type:
-#         augmentClass = namedClass(config.AugmentService.type)
-#         augmentService = augmentClass(**config.AugmentService.params)
-#     else:
-#         augmentService = None
-
-#     proxydbClass = namedClass(config.ProxyDBService.type)
-#     calendaruserproxy.ProxyDBService = proxydbClass(**config.ProxyDBService.params)
-
-#     # Wait for directory service to become available
-#     BaseDirectoryService = namedClass(config.DirectoryService.type)
-#     config.DirectoryService.params.augmentService = augmentService
-#     directory = BaseDirectoryService(config.DirectoryService.params)
-#     while not directory.isAvailable():
-#         sleep(5)
-
-#     directories = [directory]
-
-#     if config.ResourceService.Enabled:
-#         resourceClass = namedClass(config.ResourceService.type)
-#         config.ResourceService.params.augmentService = augmentService
-#         resourceDirectory = resourceClass(config.ResourceService.params)
-#         resourceDirectory.realmName = directory.realmName
-#         directories.append(resourceDirectory)
-
-#     aggregate = MyDirectoryService(directories, None)
-#     aggregate.augmentService = augmentService
-
-#     #
-#     # Wire up the resource hierarchy
-#     #
-#     principalCollection = aggregate.getPrincipalCollection()
-#     root = RootResource(
-#         config.DocumentRoot,
-#         principalCollections=(principalCollection,),
-#     )
-#     root.putChild(&quot;principals&quot;, principalCollection)
-
-#     # Need a data store
-#     _newStore = CommonDataStore(FilePath(config.DocumentRoot), None, aggregate, True, False)
-
-#     from twistedcaldav.directory.calendar import DirectoryCalendarHomeProvisioningResource
-#     calendarCollection = DirectoryCalendarHomeProvisioningResource(
-#         aggregate, &quot;/calendars/&quot;,
-#         _newStore,
-#     )
-#     root.putChild(&quot;calendars&quot;, calendarCollection)
-
-#     return aggregate
-
-
-
-# class DummyDirectoryService (DirectoryService):
-#     realmName = &quot;&quot;
-#     baseGUID = &quot;51856FD4-5023-4890-94FE-4356C4AAC3E4&quot;
-#     def recordTypes(self):
-#         return ()
-
-
-#     def listRecords(self):
-#         return ()
-
-
-#     def recordWithShortName(self):
-#         return None
-
-# dummyDirectoryRecord = DirectoryRecord(
-#     service=DummyDirectoryService(),
-#     recordType=&quot;dummy&quot;,
-#     guid=&quot;8EF0892F-7CB6-4B8E-B294-7C5A5321136A&quot;,
-#     shortNames=(&quot;dummy&quot;,),
-#     fullName=&quot;Dummy McDummerson&quot;,
-#     firstName=&quot;Dummy&quot;,
-#     lastName=&quot;McDummerson&quot;,
-# )
-
</del><span class="cx"> class UsageError (StandardError):
</span><span class="cx">     pass
</span><span class="cx"> 
</span></span></pre></div>
<a id="CalendarServertrunkconfcaldavdtestplist"></a>
<div class="modfile"><h4>Modified: CalendarServer/trunk/conf/caldavd-test.plist (13840 => 13841)</h4>
<pre class="diff"><span>
<span class="info">--- CalendarServer/trunk/conf/caldavd-test.plist        2014-08-05 22:49:28 UTC (rev 13840)
+++ CalendarServer/trunk/conf/caldavd-test.plist        2014-08-05 23:11:29 UTC (rev 13841)
</span><span class="lines">@@ -196,7 +196,7 @@
</span><span class="cx">     &lt;key&gt;DirectoryService&lt;/key&gt;
</span><span class="cx">     &lt;dict&gt;
</span><span class="cx">       &lt;key&gt;type&lt;/key&gt;
</span><del>-      &lt;string&gt;twistedcaldav.directory.xmlfile.XMLDirectoryService&lt;/string&gt;
</del><ins>+      &lt;string&gt;xml&lt;/string&gt;
</ins><span class="cx"> 
</span><span class="cx">       &lt;key&gt;params&lt;/key&gt;
</span><span class="cx">       &lt;dict&gt;
</span><span class="lines">@@ -210,14 +210,12 @@
</span><span class="cx">     &lt;key&gt;DirectoryService&lt;/key&gt;
</span><span class="cx">     &lt;dict&gt;
</span><span class="cx">       &lt;key&gt;type&lt;/key&gt;
</span><del>-      &lt;string&gt;twistedcaldav.directory.appleopendirectory.OpenDirectoryService&lt;/string&gt;
</del><ins>+      &lt;string&gt;opendirectory&lt;/string&gt;
</ins><span class="cx"> 
</span><span class="cx">       &lt;key&gt;params&lt;/key&gt;
</span><span class="cx">       &lt;dict&gt;
</span><span class="cx">         &lt;key&gt;node&lt;/key&gt;
</span><span class="cx">         &lt;string&gt;/Search&lt;/string&gt;
</span><del>-        &lt;key&gt;cacheTimeout&lt;/key&gt;
-        &lt;integer&gt;10&lt;/integer&gt;
</del><span class="cx">       &lt;/dict&gt;
</span><span class="cx">     &lt;/dict&gt;
</span><span class="cx">     --&gt;
</span><span class="lines">@@ -227,7 +225,7 @@
</span><span class="cx">     &lt;key&gt;DirectoryService&lt;/key&gt;
</span><span class="cx">     &lt;dict&gt;
</span><span class="cx">       &lt;key&gt;type&lt;/key&gt;
</span><del>-      &lt;string&gt;twistedcaldav.directory.ldapdirectory.LdapDirectoryService&lt;/string&gt;
</del><ins>+      &lt;string&gt;ldap&lt;/string&gt;
</ins><span class="cx"> 
</span><span class="cx">       &lt;key&gt;params&lt;/key&gt;
</span><span class="cx">       &lt;dict&gt;
</span><span class="lines">@@ -235,137 +233,58 @@
</span><span class="cx">         &lt;array&gt;
</span><span class="cx">            &lt;string&gt;users&lt;/string&gt;
</span><span class="cx">            &lt;string&gt;groups&lt;/string&gt;
</span><del>-           &lt;string&gt;locations&lt;/string&gt;
-           &lt;string&gt;resources&lt;/string&gt;
</del><span class="cx">         &lt;/array&gt;
</span><del>-        &lt;key&gt;cacheTimeout&lt;/key&gt;
-        &lt;integer&gt;10&lt;/integer&gt;
</del><span class="cx">         &lt;key&gt;uri&lt;/key&gt;
</span><del>-        &lt;string&gt;ldap://ldapserver.example.com/&lt;/string&gt;
-        &lt;key&gt;tls&lt;/key&gt;
-        &lt;false/&gt;
-        &lt;key&gt;tlsCACertFile&lt;/key&gt;
-        &lt;string&gt;&lt;/string&gt;
-        &lt;key&gt;tlsCACertDir&lt;/key&gt;
-        &lt;string&gt;&lt;/string&gt;
-        &lt;key&gt;tlsRequireCert&lt;/key&gt;
-        &lt;string&gt;never&lt;/string&gt;
</del><ins>+        &lt;string&gt;ldap://server.example.com/&lt;/string&gt;
</ins><span class="cx">         &lt;key&gt;credentials&lt;/key&gt;
</span><span class="cx">         &lt;dict&gt;
</span><span class="cx">           &lt;key&gt;dn&lt;/key&gt;
</span><span class="cx">           &lt;string&gt;uid=admin,ou=people,o=example.com&lt;/string&gt;
</span><span class="cx">           &lt;key&gt;password&lt;/key&gt;
</span><del>-          &lt;string&gt;PASSWORD&lt;/string&gt;
</del><ins>+          &lt;string&gt;&lt;/string&gt;
</ins><span class="cx">         &lt;/dict&gt;
</span><span class="cx">         &lt;key&gt;rdnSchema&lt;/key&gt;
</span><span class="cx">         &lt;dict&gt;
</span><span class="cx">           &lt;key&gt;base&lt;/key&gt;
</span><del>-          &lt;string&gt;o=example.com&lt;/string&gt;
-          &lt;key&gt;guidAttr&lt;/key&gt;
-          &lt;string&gt;GUID&lt;/string&gt;
</del><ins>+          &lt;string&gt;dc=server,dc=example,dc=com&lt;/string&gt;
</ins><span class="cx">           &lt;key&gt;users&lt;/key&gt;
</span><del>-          &lt;dict&gt;
-            &lt;key&gt;rdn&lt;/key&gt;
-            &lt;string&gt;ou=people&lt;/string&gt;
-            &lt;key&gt;mapping&lt;/key&gt;
-            &lt;dict&gt;
-                &lt;key&gt;recordName&lt;/key&gt;
-                &lt;string&gt;uid&lt;/string&gt;
-                &lt;key&gt;fullName&lt;/key&gt;
-                &lt;string&gt;cn&lt;/string&gt;
-                &lt;key&gt;emailAddresses&lt;/key&gt;
-                &lt;array&gt;
-                    &lt;string&gt;mail&lt;/string&gt;
-                    &lt;string&gt;mailAlias&lt;/string&gt;
-                &lt;/array&gt;
-                &lt;key&gt;firstName&lt;/key&gt;
-                &lt;string&gt;givenName&lt;/string&gt;
-                &lt;key&gt;lastName&lt;/key&gt;
-                &lt;string&gt;sn&lt;/string&gt;
-            &lt;/dict&gt;
-          &lt;/dict&gt;
</del><ins>+          &lt;string&gt;cn=users&lt;/string&gt;
</ins><span class="cx">           &lt;key&gt;groups&lt;/key&gt;
</span><del>-          &lt;dict&gt;
-            &lt;key&gt;rdn&lt;/key&gt;
-            &lt;string&gt;ou=groups&lt;/string&gt;
-            &lt;key&gt;mapping&lt;/key&gt;
-            &lt;dict&gt;
-                &lt;key&gt;recordName&lt;/key&gt;
-                &lt;string&gt;cn&lt;/string&gt;
-                &lt;key&gt;fullName&lt;/key&gt;
-                &lt;string&gt;cn&lt;/string&gt;
-                &lt;key&gt;emailAddresses&lt;/key&gt;
-                &lt;array&gt;
-                    &lt;string&gt;mail&lt;/string&gt;
-                    &lt;string&gt;mailAlias&lt;/string&gt;
-                &lt;/array&gt;
-            &lt;/dict&gt;
-          &lt;/dict&gt;
</del><ins>+          &lt;string&gt;cn=groups&lt;/string&gt;
</ins><span class="cx">           &lt;key&gt;locations&lt;/key&gt;
</span><del>-          &lt;dict&gt;
-            &lt;key&gt;rdn&lt;/key&gt;
-            &lt;string&gt;ou=locations&lt;/string&gt;
-            &lt;key&gt;associatedAddressAttr&lt;/key&gt;
-            &lt;string&gt;&lt;/string&gt;
-            &lt;key&gt;mapping&lt;/key&gt;
-            &lt;dict&gt;
-                &lt;key&gt;recordName&lt;/key&gt;
-                &lt;string&gt;cn&lt;/string&gt;
-                &lt;key&gt;fullName&lt;/key&gt;
-                &lt;string&gt;cn&lt;/string&gt;
-            &lt;/dict&gt;
-          &lt;/dict&gt;
</del><ins>+          &lt;string&gt;cn=locations&lt;/string&gt;
</ins><span class="cx">           &lt;key&gt;resources&lt;/key&gt;
</span><del>-          &lt;dict&gt;
-            &lt;key&gt;rdn&lt;/key&gt;
-            &lt;string&gt;ou=resources&lt;/string&gt;
-            &lt;key&gt;mapping&lt;/key&gt;
-            &lt;dict&gt;
-                &lt;key&gt;recordName&lt;/key&gt;
-                &lt;string&gt;cn&lt;/string&gt;
-                &lt;key&gt;fullName&lt;/key&gt;
-                &lt;string&gt;cn&lt;/string&gt;
-            &lt;/dict&gt;
-          &lt;/dict&gt;
</del><ins>+          &lt;string&gt;cn=resources&lt;/string&gt;
</ins><span class="cx">           &lt;key&gt;addresses&lt;/key&gt;
</span><del>-          &lt;dict&gt;
-            &lt;key&gt;rdn&lt;/key&gt;
-            &lt;string&gt;ou=buildings&lt;/string&gt;
-            &lt;key&gt;geoAttr&lt;/key&gt;
-            &lt;string&gt;&lt;/string&gt;
-            &lt;key&gt;streetAddressAttr&lt;/key&gt;
-            &lt;string&gt;&lt;/string&gt;
-            &lt;key&gt;mapping&lt;/key&gt;
-            &lt;dict&gt;
-                &lt;key&gt;recordName&lt;/key&gt;
-                &lt;string&gt;cn&lt;/string&gt;
-                &lt;key&gt;fullName&lt;/key&gt;
-                &lt;string&gt;cn&lt;/string&gt;
-            &lt;/dict&gt;
-          &lt;/dict&gt;
</del><ins>+          &lt;string&gt;cn=addresses&lt;/string&gt;
</ins><span class="cx">         &lt;/dict&gt;
</span><del>-        &lt;key&gt;groupSchema&lt;/key&gt;
</del><ins>+        &lt;key&gt;mapping&lt;/key&gt;
</ins><span class="cx">         &lt;dict&gt;
</span><del>-          &lt;key&gt;membersAttr&lt;/key&gt;
-          &lt;string&gt;uniqueMember&lt;/string&gt;
-          &lt;key&gt;nestedGroupsAttr&lt;/key&gt;
-          &lt;string&gt;&lt;/string&gt;
-          &lt;key&gt;memberIdAttr&lt;/key&gt;
-          &lt;string&gt;&lt;/string&gt;
</del><ins>+          &lt;key&gt;uid&lt;/key&gt;
+          &lt;array&gt;
+            &lt;string&gt;apple-generateduid&lt;/string&gt;
+          &lt;/array&gt;
+          &lt;key&gt;guid&lt;/key&gt;
+          &lt;array&gt;
+            &lt;string&gt;apple-generateduid&lt;/string&gt;
+          &lt;/array&gt;
+          &lt;key&gt;shortNames&lt;/key&gt;
+          &lt;array&gt;
+            &lt;string&gt;uid&lt;/string&gt;
+          &lt;/array&gt;
+          &lt;key&gt;fullNames&lt;/key&gt;
+          &lt;array&gt;
+            &lt;string&gt;cn&lt;/string&gt;
+          &lt;/array&gt;
+          &lt;key&gt;emailAddresses&lt;/key&gt;
+          &lt;array&gt;
+            &lt;string&gt;mail&lt;/string&gt;
+          &lt;/array&gt;
+          &lt;key&gt;memberDNs&lt;/key&gt;
+          &lt;array&gt;
+            &lt;string&gt;uniqueMember&lt;/string&gt;
+          &lt;/array&gt;
</ins><span class="cx">         &lt;/dict&gt;
</span><del>-        &lt;key&gt;resourceSchema&lt;/key&gt;
-        &lt;dict&gt;
-         &lt;key&gt;resourceInfoAttr&lt;/key&gt;
-         &lt;string&gt;&lt;/string&gt;
-         &lt;key&gt;autoScheduleAttr&lt;/key&gt;
-         &lt;string&gt;&lt;/string&gt;
-         &lt;key&gt;autoScheduleEnabledValue&lt;/key&gt;
-         &lt;string&gt;&lt;/string&gt;
-         &lt;key&gt;proxyAttr&lt;/key&gt;
-         &lt;string&gt;&lt;/string&gt;
-         &lt;key&gt;readOnlyProxyAttr&lt;/key&gt;
-         &lt;string&gt;&lt;/string&gt;
-        &lt;/dict&gt;
</del><span class="cx">       &lt;/dict&gt;
</span><span class="cx">     &lt;/dict&gt;
</span><span class="cx">     --&gt;
</span><span class="lines">@@ -380,7 +299,7 @@
</span><span class="cx">       &lt;key&gt;Enabled&lt;/key&gt;
</span><span class="cx">       &lt;true/&gt;
</span><span class="cx">       &lt;key&gt;type&lt;/key&gt;
</span><del>-      &lt;string&gt;twistedcaldav.directory.xmlfile.XMLDirectoryService&lt;/string&gt;
</del><ins>+      &lt;string&gt;xml&lt;/string&gt;
</ins><span class="cx"> 
</span><span class="cx">       &lt;key&gt;params&lt;/key&gt;
</span><span class="cx">       &lt;dict&gt;
</span><span class="lines">@@ -436,36 +355,6 @@
</span><span class="cx">     &lt;/dict&gt;
</span><span class="cx">      --&gt;
</span><span class="cx"> 
</span><del>-    &lt;!-- Sqlite ProxyDB Service --&gt;
-    &lt;key&gt;ProxyDBService&lt;/key&gt;
-    &lt;dict&gt;
-      &lt;key&gt;type&lt;/key&gt;
-      &lt;string&gt;twistedcaldav.directory.calendaruserproxy.ProxySqliteDB&lt;/string&gt;
-
-      &lt;key&gt;params&lt;/key&gt;
-      &lt;dict&gt;
-        &lt;key&gt;dbpath&lt;/key&gt;
-        &lt;string&gt;proxies.sqlite&lt;/string&gt;
-      &lt;/dict&gt;
-    &lt;/dict&gt;
-
-    &lt;!-- PostgreSQL ProxyDB Service --&gt;
-    &lt;!--
-    &lt;key&gt;ProxyDBService&lt;/key&gt;
-    &lt;dict&gt;
-      &lt;key&gt;type&lt;/key&gt;
-      &lt;string&gt;twistedcaldav.directory.calendaruserproxy.ProxyPostgreSQLDB&lt;/string&gt;
-
-      &lt;key&gt;params&lt;/key&gt;
-      &lt;dict&gt;
-        &lt;key&gt;host&lt;/key&gt;
-        &lt;string&gt;localhost&lt;/string&gt;
-        &lt;key&gt;database&lt;/key&gt;
-        &lt;string&gt;proxies&lt;/string&gt;
-      &lt;/dict&gt;
-    &lt;/dict&gt;
-     --&gt;
-
</del><span class="cx">     &lt;key&gt;ProxyLoadFromFile&lt;/key&gt;
</span><span class="cx">     &lt;string&gt;./conf/auth/proxies-test.xml&lt;/string&gt;
</span><span class="cx"> 
</span></span></pre></div>
<a id="CalendarServertrunkrequirementsstabletxt"></a>
<div class="modfile"><h4>Modified: CalendarServer/trunk/requirements-stable.txt (13840 => 13841)</h4>
<pre class="diff"><span>
<span class="info">--- CalendarServer/trunk/requirements-stable.txt        2014-08-05 22:49:28 UTC (rev 13840)
+++ CalendarServer/trunk/requirements-stable.txt        2014-08-05 23:11:29 UTC (rev 13841)
</span><span class="lines">@@ -5,7 +5,7 @@
</span><span class="cx"> # For CalendarServer development, don't try to get these projects from PyPI; use svn.
</span><span class="cx"> 
</span><span class="cx"> -e .
</span><del>--e svn+http://svn.calendarserver.org/repository/calendarserver/twext/trunk@13835#egg=twextpy
</del><ins>+-e svn+http://svn.calendarserver.org/repository/calendarserver/twext/trunk@13840#egg=twextpy
</ins><span class="cx"> -e svn+http://svn.calendarserver.org/repository/calendarserver/PyKerberos/trunk@13420#egg=kerberos
</span><span class="cx"> -e svn+http://svn.calendarserver.org/repository/calendarserver/PyCalendar/trunk@13802#egg=pycalendar
</span><span class="cx"> 
</span></span></pre></div>
<a id="CalendarServertrunktwistedcaldavstdconfigpy"></a>
<div class="modfile"><h4>Modified: CalendarServer/trunk/twistedcaldav/stdconfig.py (13840 => 13841)</h4>
<pre class="diff"><span>
<span class="info">--- CalendarServer/trunk/twistedcaldav/stdconfig.py        2014-08-05 22:49:28 UTC (rev 13840)
+++ CalendarServer/trunk/twistedcaldav/stdconfig.py        2014-08-05 23:11:29 UTC (rev 13841)
</span><span class="lines">@@ -49,133 +49,48 @@
</span><span class="cx">     DEFAULT_CONFIG_FILE = &quot;/etc/caldavd/caldavd.plist&quot;
</span><span class="cx"> 
</span><span class="cx"> DEFAULT_SERVICE_PARAMS = {
</span><del>-    &quot;twistedcaldav.directory.xmlfile.XMLDirectoryService&quot;: {
-        &quot;xmlFile&quot;: &quot;accounts.xml&quot;,
</del><ins>+    &quot;xml&quot;: {
</ins><span class="cx">         &quot;recordTypes&quot;: (&quot;users&quot;, &quot;groups&quot;),
</span><del>-        &quot;statSeconds&quot;: 15,
</del><ins>+        &quot;xmlFile&quot;: &quot;accounts.xml&quot;,
</ins><span class="cx">     },
</span><del>-    &quot;twistedcaldav.directory.appleopendirectory.OpenDirectoryService&quot;: {
-        &quot;node&quot;: &quot;/Search&quot;,
-        &quot;cacheTimeout&quot;: 1,  # Minutes
-        &quot;batchSize&quot;: 100,  # for splitting up large queries
-        &quot;negativeCaching&quot;: False,
-        &quot;restrictEnabledRecords&quot;: False,
-        &quot;restrictToGroup&quot;: &quot;&quot;,
</del><ins>+    &quot;opendirectory&quot;: {
</ins><span class="cx">         &quot;recordTypes&quot;: (&quot;users&quot;, &quot;groups&quot;),
</span><ins>+        &quot;node&quot;: &quot;/Search&quot;,
</ins><span class="cx">     },
</span><del>-    &quot;twistedcaldav.directory.ldapdirectory.LdapDirectoryService&quot;: {
-        &quot;cacheTimeout&quot;: 1,  # Minutes
-        &quot;negativeCaching&quot;: False,
-        &quot;warningThresholdSeconds&quot;: 3,
-        &quot;batchSize&quot;: 500,  # for splitting up large queries
-        &quot;requestTimeoutSeconds&quot;: 10,
-        &quot;requestResultsLimit&quot;: 200,
-        &quot;optimizeMultiName&quot;: False,
-        &quot;queryLocationsImplicitly&quot;: True,
-        &quot;restrictEnabledRecords&quot;: False,
-        &quot;restrictToGroup&quot;: &quot;&quot;,
</del><ins>+    &quot;ldap&quot;: {
</ins><span class="cx">         &quot;recordTypes&quot;: (&quot;users&quot;, &quot;groups&quot;),
</span><span class="cx">         &quot;uri&quot;: &quot;ldap://localhost/&quot;,
</span><del>-        &quot;tls&quot;: False,
-        &quot;tlsCACertFile&quot;: None,
-        &quot;tlsCACertDir&quot;: None,
-        &quot;tlsRequireCert&quot;: None,  # never, allow, try, demand, hard
</del><span class="cx">         &quot;credentials&quot;: {
</span><span class="cx">             &quot;dn&quot;: None,
</span><span class="cx">             &quot;password&quot;: None,
</span><span class="cx">         },
</span><del>-        &quot;authMethod&quot;: &quot;LDAP&quot;,
</del><span class="cx">         &quot;rdnSchema&quot;: {
</span><span class="cx">             &quot;base&quot;: &quot;dc=example,dc=com&quot;,
</span><del>-            &quot;guidAttr&quot;: &quot;entryUUID&quot;,
-            &quot;users&quot;: {
-                &quot;rdn&quot;: &quot;ou=People&quot;,
-                &quot;attr&quot;: &quot;uid&quot;,  # used only to synthesize email address
-                &quot;emailSuffix&quot;: None,  # used only to synthesize email address
-                &quot;filter&quot;: None,  # additional filter for this type
-                &quot;loginEnabledAttr&quot;: &quot;&quot;,  # attribute controlling login
-                &quot;loginEnabledValue&quot;: &quot;yes&quot;,  # &quot;True&quot; value of above attribute
-                &quot;calendarEnabledAttr&quot;: &quot;&quot;,  # attribute controlling enabledForCalendaring
-                &quot;calendarEnabledValue&quot;: &quot;yes&quot;,  # &quot;True&quot; value of above attribute
-                &quot;mapping&quot;: {  # maps internal record names to LDAP
-                    &quot;recordName&quot;: &quot;uid&quot;,
-                    &quot;fullName&quot;: &quot;cn&quot;,
-                    &quot;emailAddresses&quot;: [&quot;mail&quot;],
-                    &quot;firstName&quot;: &quot;givenName&quot;,
-                    &quot;lastName&quot;: &quot;sn&quot;,
-                },
-            },
-            &quot;groups&quot;: {
-                &quot;rdn&quot;: &quot;ou=Group&quot;,
-                &quot;attr&quot;: &quot;cn&quot;,  # used only to synthesize email address
-                &quot;emailSuffix&quot;: None,  # used only to synthesize email address
-                &quot;filter&quot;: None,  # additional filter for this type
-                &quot;mapping&quot;: {  # maps internal record names to LDAP
-                    &quot;recordName&quot;: &quot;cn&quot;,
-                    &quot;fullName&quot;: &quot;cn&quot;,
-                    &quot;emailAddresses&quot;: [&quot;mail&quot;],
-                    &quot;firstName&quot;: &quot;givenName&quot;,
-                    &quot;lastName&quot;: &quot;sn&quot;,
-                },
-            },
-            &quot;locations&quot;: {
-                &quot;rdn&quot;: &quot;ou=Places&quot;,
-                &quot;attr&quot;: &quot;cn&quot;,  # used only to synthesize email address
-                &quot;emailSuffix&quot;: None,  # used only to synthesize email address
-                &quot;filter&quot;: None,  # additional filter for this type
-                &quot;calendarEnabledAttr&quot;: &quot;&quot;,  # attribute controlling enabledForCalendaring
-                &quot;calendarEnabledValue&quot;: &quot;yes&quot;,  # &quot;True&quot; value of above attribute
-                &quot;mapping&quot;: {  # maps internal record names to LDAP
-                    &quot;recordName&quot;: &quot;cn&quot;,
-                    &quot;fullName&quot;: &quot;cn&quot;,
-                    &quot;emailAddresses&quot;: [&quot;mail&quot;],
-                    &quot;firstName&quot;: &quot;givenName&quot;,
-                    &quot;lastName&quot;: &quot;sn&quot;,
-                },
-            },
-            &quot;resources&quot;: {
-                &quot;rdn&quot;: &quot;ou=Resources&quot;,
-                &quot;attr&quot;: &quot;cn&quot;,  # used only to synthesize email address
-                &quot;emailSuffix&quot;: None,  # used only to synthesize email address
-                &quot;filter&quot;: None,  # additional filter for this type
-                &quot;calendarEnabledAttr&quot;: &quot;&quot;,  # attribute controlling enabledForCalendaring
-                &quot;calendarEnabledValue&quot;: &quot;yes&quot;,  # &quot;True&quot; value of above attribute
-                &quot;mapping&quot;: {  # maps internal record names to LDAP
-                    &quot;recordName&quot;: &quot;cn&quot;,
-                    &quot;fullName&quot;: &quot;cn&quot;,
-                    &quot;emailAddresses&quot;: [&quot;mail&quot;],
-                    &quot;firstName&quot;: &quot;givenName&quot;,
-                    &quot;lastName&quot;: &quot;sn&quot;,
-                },
-            },
</del><ins>+            &quot;users&quot;: &quot;cn=users&quot;,
+            &quot;groups&quot;: &quot;cn=groups&quot;,
+            &quot;locations&quot;: &quot;cn=locations&quot;,
+            &quot;resources&quot;: &quot;cn=resources&quot;,
+            &quot;addresses&quot;: &quot;cn=addresses&quot;,
</ins><span class="cx">         },
</span><del>-        &quot;groupSchema&quot;: {
-            &quot;membersAttr&quot;: &quot;member&quot;,  # how members are specified
-            &quot;nestedGroupsAttr&quot;: None,  # how nested groups are specified
-            &quot;memberIdAttr&quot;: None,  # which attribute the above refer to
-        },
-        &quot;resourceSchema&quot;: {
-            &quot;resourceInfoAttr&quot;: None,  # contains location/resource info
-            &quot;autoAcceptGroupAttr&quot;: None,  # auto accept group
-        },
-        &quot;poddingSchema&quot;: {
-            &quot;serverIdAttr&quot;: None,  # maps to augments server-id
-        },
</del><ins>+        &quot;mapping&quot;: {
+            &quot;uid&quot;: [&quot;apple-generateduid&quot;, ],
+            &quot;guid&quot;: [&quot;apple-generateduid&quot;, ],
+            &quot;shortNames&quot;: [&quot;uid&quot;, ],
+            &quot;fullNames&quot;: [&quot;cn&quot;, ],
+            &quot;emailAddresses&quot;: [&quot;mail&quot;, ],
+            &quot;memberDNs&quot;: [&quot;uniqueMember&quot;, ],
+        }
</ins><span class="cx">     },
</span><span class="cx"> }
</span><span class="cx"> 
</span><span class="cx"> DEFAULT_RESOURCE_PARAMS = {
</span><del>-    &quot;twistedcaldav.directory.xmlfile.XMLDirectoryService&quot;: {
-        &quot;xmlFile&quot;: &quot;resources.xml&quot;,
</del><ins>+    &quot;xml&quot;: {
</ins><span class="cx">         &quot;recordTypes&quot;: (&quot;locations&quot;, &quot;resources&quot;, &quot;addresses&quot;),
</span><ins>+        &quot;xmlFile&quot;: &quot;resources.xml&quot;,
</ins><span class="cx">     },
</span><del>-    &quot;twistedcaldav.directory.appleopendirectory.OpenDirectoryService&quot;: {
</del><ins>+    &quot;opendirectory&quot;: {
+        &quot;recordTypes&quot;: (&quot;locations&quot;, &quot;resources&quot;, &quot;addresses&quot;),
</ins><span class="cx">         &quot;node&quot;: &quot;/Search&quot;,
</span><del>-        &quot;cacheTimeout&quot;: 1,  # Minutes
-        &quot;negativeCaching&quot;: False,
-        &quot;restrictEnabledRecords&quot;: False,
-        &quot;restrictToGroup&quot;: &quot;&quot;,
-        &quot;recordTypes&quot;: (&quot;locations&quot;, &quot;resources&quot;),
</del><span class="cx">     },
</span><span class="cx"> }
</span><span class="cx"> 
</span><span class="lines">@@ -195,20 +110,7 @@
</span><span class="cx">     },
</span><span class="cx"> }
</span><span class="cx"> 
</span><del>-DEFAULT_PROXYDB_PARAMS = {
-    &quot;twistedcaldav.directory.calendaruserproxy.ProxySqliteDB&quot;: {
-        &quot;dbpath&quot;: &quot;proxies.sqlite&quot;,
-    },
-    &quot;twistedcaldav.directory.calendaruserproxy.ProxyPostgreSQLDB&quot;: {
-        &quot;host&quot;: &quot;localhost&quot;,
-        &quot;database&quot;: &quot;proxies&quot;,
-        &quot;user&quot;: &quot;&quot;,
-        &quot;password&quot;: &quot;&quot;,
-        &quot;dbtype&quot;: &quot;&quot;,
-    },
-}
</del><span class="cx"> 
</span><del>-
</del><span class="cx"> directoryAddressBookBackingServiceDefaultParams = {
</span><span class="cx">     &quot;twistedcaldav.directory.xmlfile.XMLDirectoryService&quot;: {
</span><span class="cx">         &quot;xmlFile&quot;: &quot;/etc/carddavd/accounts.xml&quot;,
</span><span class="lines">@@ -371,7 +273,7 @@
</span><span class="cx">     # Set to URL path of wiki authentication service, e.g. &quot;/auth&quot;, in order
</span><span class="cx">     # to use javascript authentication dialog.  Empty string indicates standard
</span><span class="cx">     # browser authentication dialog should be used.
</span><del>-    &quot;WebCalendarAuthPath&quot;     : &quot;&quot;,
</del><ins>+    &quot;WebCalendarAuthPath&quot;: &quot;&quot;,
</ins><span class="cx"> 
</span><span class="cx">     # Define mappings of URLs to file system objects (directories or files)
</span><span class="cx">     &quot;Aliases&quot;: [],
</span><span class="lines">@@ -384,8 +286,8 @@
</span><span class="cx">     #
</span><span class="cx">     &quot;DirectoryService&quot;: {
</span><span class="cx">         &quot;Enabled&quot;: True,
</span><del>-        &quot;type&quot;: &quot;twistedcaldav.directory.xmlfile.XMLDirectoryService&quot;,
-        &quot;params&quot;: DEFAULT_SERVICE_PARAMS[&quot;twistedcaldav.directory.xmlfile.XMLDirectoryService&quot;],
</del><ins>+        &quot;type&quot;: &quot;xml&quot;,
+        &quot;params&quot;: DEFAULT_SERVICE_PARAMS[&quot;xml&quot;],
</ins><span class="cx">     },
</span><span class="cx"> 
</span><span class="cx">     &quot;DirectoryRealmName&quot;: &quot;&quot;,
</span><span class="lines">@@ -398,8 +300,8 @@
</span><span class="cx">     #
</span><span class="cx">     &quot;ResourceService&quot;: {
</span><span class="cx">         &quot;Enabled&quot;: True,
</span><del>-        &quot;type&quot;: &quot;twistedcaldav.directory.xmlfile.XMLDirectoryService&quot;,
-        &quot;params&quot;: DEFAULT_RESOURCE_PARAMS[&quot;twistedcaldav.directory.xmlfile.XMLDirectoryService&quot;],
</del><ins>+        &quot;type&quot;: &quot;xml&quot;,
+        &quot;params&quot;: DEFAULT_RESOURCE_PARAMS[&quot;xml&quot;],
</ins><span class="cx">     },
</span><span class="cx"> 
</span><span class="cx">     #
</span><span class="lines">@@ -409,16 +311,12 @@
</span><span class="cx">     #
</span><span class="cx">     &quot;AugmentService&quot;: {
</span><span class="cx">         &quot;type&quot;: &quot;twistedcaldav.directory.augment.AugmentXMLDB&quot;,
</span><del>-        &quot;params&quot; : DEFAULT_AUGMENT_PARAMS[&quot;twistedcaldav.directory.augment.AugmentXMLDB&quot;],
</del><ins>+        &quot;params&quot;: DEFAULT_AUGMENT_PARAMS[&quot;twistedcaldav.directory.augment.AugmentXMLDB&quot;],
</ins><span class="cx">     },
</span><span class="cx"> 
</span><span class="cx">     #
</span><span class="cx">     # Proxies
</span><span class="cx">     #
</span><del>-    &quot;ProxyDBService&quot;: {
-        &quot;type&quot;: &quot;twistedcaldav.directory.calendaruserproxy.ProxySqliteDB&quot;,
-        &quot;params&quot;: DEFAULT_PROXYDB_PARAMS[&quot;twistedcaldav.directory.calendaruserproxy.ProxySqliteDB&quot;],
-    },
</del><span class="cx">     &quot;ProxyLoadFromFile&quot;: &quot;&quot;, # Allows for initialization of the proxy database from an XML file
</span><span class="cx"> 
</span><span class="cx">     #
</span><span class="lines">@@ -1472,15 +1370,6 @@
</span><span class="cx"> 
</span><span class="cx"> 
</span><span class="cx"> 
</span><del>-def _postUpdateProxyDBService(configDict, reloading=False):
-    if configDict.ProxyDBService.type in DEFAULT_PROXYDB_PARAMS:
-        for param in tuple(configDict.ProxyDBService.params):
-            if param not in DEFAULT_PROXYDB_PARAMS[configDict.ProxyDBService.type]:
-                log.warn(&quot;Parameter %s is not supported by service %s&quot; % (param, configDict.ProxyDBService.type))
-                del configDict.ProxyDBService.params[param]
-
-
-
</del><span class="cx"> def _updateACLs(configDict, reloading=False):
</span><span class="cx">     #
</span><span class="cx">     # Base resource ACLs
</span><span class="lines">@@ -1766,7 +1655,6 @@
</span><span class="cx">     _postUpdateDirectoryService,
</span><span class="cx">     _postUpdateResourceService,
</span><span class="cx">     _postUpdateAugmentService,
</span><del>-    _postUpdateProxyDBService,
</del><span class="cx">     _updateACLs,
</span><span class="cx">     _updateRejectClients,
</span><span class="cx">     _updateLogLevels,
</span></span></pre></div>
<a id="CalendarServertrunktwistedcaldavtesttest_configpy"></a>
<div class="modfile"><h4>Modified: CalendarServer/trunk/twistedcaldav/test/test_config.py (13840 => 13841)</h4>
<pre class="diff"><span>
<span class="info">--- CalendarServer/trunk/twistedcaldav/test/test_config.py        2014-08-05 22:49:28 UTC (rev 13840)
+++ CalendarServer/trunk/twistedcaldav/test/test_config.py        2014-08-05 23:11:29 UTC (rev 13841)
</span><span class="lines">@@ -230,51 +230,51 @@
</span><span class="cx"> 
</span><span class="cx"> 
</span><span class="cx">     def testDirectoryService_noChange(self):
</span><del>-        self.assertEquals(config.DirectoryService.type, &quot;twistedcaldav.directory.xmlfile.XMLDirectoryService&quot;)
</del><ins>+        self.assertEquals(config.DirectoryService.type, &quot;xml&quot;)
</ins><span class="cx">         self.assertEquals(config.DirectoryService.params.xmlFile, &quot;accounts.xml&quot;)
</span><span class="cx"> 
</span><span class="cx">         config.update({&quot;DirectoryService&quot;: {}})
</span><span class="cx"> 
</span><del>-        self.assertEquals(config.DirectoryService.type, &quot;twistedcaldav.directory.xmlfile.XMLDirectoryService&quot;)
</del><ins>+        self.assertEquals(config.DirectoryService.type, &quot;xml&quot;)
</ins><span class="cx">         self.assertEquals(config.DirectoryService.params.xmlFile, &quot;accounts.xml&quot;)
</span><span class="cx"> 
</span><span class="cx"> 
</span><span class="cx">     def testDirectoryService_sameType(self):
</span><del>-        self.assertEquals(config.DirectoryService.type, &quot;twistedcaldav.directory.xmlfile.XMLDirectoryService&quot;)
</del><ins>+        self.assertEquals(config.DirectoryService.type, &quot;xml&quot;)
</ins><span class="cx">         self.assertEquals(config.DirectoryService.params.xmlFile, &quot;accounts.xml&quot;)
</span><span class="cx"> 
</span><del>-        config.update({&quot;DirectoryService&quot;: {&quot;type&quot;: &quot;twistedcaldav.directory.xmlfile.XMLDirectoryService&quot;}})
</del><ins>+        config.update({&quot;DirectoryService&quot;: {&quot;type&quot;: &quot;xml&quot;}})
</ins><span class="cx"> 
</span><del>-        self.assertEquals(config.DirectoryService.type, &quot;twistedcaldav.directory.xmlfile.XMLDirectoryService&quot;)
</del><ins>+        self.assertEquals(config.DirectoryService.type, &quot;xml&quot;)
</ins><span class="cx">         self.assertEquals(config.DirectoryService.params.xmlFile, &quot;accounts.xml&quot;)
</span><span class="cx"> 
</span><span class="cx"> 
</span><span class="cx">     def testDirectoryService_newType(self):
</span><del>-        self.assertEquals(config.DirectoryService.type, &quot;twistedcaldav.directory.xmlfile.XMLDirectoryService&quot;)
</del><ins>+        self.assertEquals(config.DirectoryService.type, &quot;xml&quot;)
</ins><span class="cx">         self.assertEquals(config.DirectoryService.params.xmlFile, &quot;accounts.xml&quot;)
</span><span class="cx"> 
</span><del>-        config.update({&quot;DirectoryService&quot;: {&quot;type&quot;: &quot;twistedcaldav.directory.appleopendirectory.OpenDirectoryService&quot;}})
</del><ins>+        config.update({&quot;DirectoryService&quot;: {&quot;type&quot;: &quot;opendirectory&quot;}})
</ins><span class="cx"> 
</span><del>-        self.assertEquals(config.DirectoryService.type, &quot;twistedcaldav.directory.appleopendirectory.OpenDirectoryService&quot;)
</del><ins>+        self.assertEquals(config.DirectoryService.type, &quot;opendirectory&quot;)
</ins><span class="cx">         self.assertNotIn(&quot;xmlFile&quot;, config.DirectoryService.params)
</span><span class="cx">         self.assertEquals(config.DirectoryService.params.node, &quot;/Search&quot;)
</span><span class="cx"> 
</span><span class="cx"> 
</span><span class="cx">     def testDirectoryService_newParam(self):
</span><del>-        self.assertEquals(config.DirectoryService.type, &quot;twistedcaldav.directory.xmlfile.XMLDirectoryService&quot;)
</del><ins>+        self.assertEquals(config.DirectoryService.type, &quot;xml&quot;)
</ins><span class="cx">         self.assertEquals(config.DirectoryService.params.xmlFile, &quot;accounts.xml&quot;)
</span><span class="cx"> 
</span><del>-        config.update({&quot;DirectoryService&quot;: {&quot;type&quot;: &quot;twistedcaldav.directory.appleopendirectory.OpenDirectoryService&quot;}})
</del><ins>+        config.update({&quot;DirectoryService&quot;: {&quot;type&quot;: &quot;opendirectory&quot;}})
</ins><span class="cx"> 
</span><del>-        self.assertEquals(config.DirectoryService.type, &quot;twistedcaldav.directory.appleopendirectory.OpenDirectoryService&quot;)
</del><ins>+        self.assertEquals(config.DirectoryService.type, &quot;opendirectory&quot;)
</ins><span class="cx">         self.assertEquals(config.DirectoryService.params.node, &quot;/Search&quot;)
</span><span class="cx"> 
</span><span class="cx"> 
</span><span class="cx">     def testDirectoryService_unknownType(self):
</span><del>-        self.assertEquals(config.DirectoryService.type, &quot;twistedcaldav.directory.xmlfile.XMLDirectoryService&quot;)
</del><ins>+        self.assertEquals(config.DirectoryService.type, &quot;xml&quot;)
</ins><span class="cx">         self.assertEquals(config.DirectoryService.params.xmlFile, &quot;accounts.xml&quot;)
</span><span class="cx"> 
</span><del>-        config.update({&quot;DirectoryService&quot;: {&quot;type&quot;: &quot;twistedcaldav.test.test_config.SuperDuperAwesomeService&quot;}})
</del><ins>+        config.update({&quot;DirectoryService&quot;: {&quot;type&quot;: &quot;unknown&quot;}})
</ins><span class="cx"> 
</span><span class="cx">         # self.assertEquals(
</span><span class="cx">         #     config.DirectoryService.params,
</span></span></pre></div>
<a id="CalendarServertrunktwistedcaldavupgradepy"></a>
<div class="modfile"><h4>Modified: CalendarServer/trunk/twistedcaldav/upgrade.py (13840 => 13841)</h4>
<pre class="diff"><span>
<span class="info">--- CalendarServer/trunk/twistedcaldav/upgrade.py        2014-08-05 22:49:28 UTC (rev 13840)
+++ CalendarServer/trunk/twistedcaldav/upgrade.py        2014-08-05 23:11:29 UTC (rev 13841)
</span><span class="lines">@@ -1149,25 +1149,6 @@
</span><span class="cx">                     # Write stub file as indicator loading is done
</span><span class="cx">                     FilePath(loadDoneFilePath).touch()
</span><span class="cx"> 
</span><del>-
-            # # Populate the group membership cache
-            # if (self.config.GroupCaching.Enabled and
-            #     self.config.GroupCaching.EnableUpdater):
-            #     proxydb = calendaruserproxy.ProxyDBService
-            #     if proxydb is None:
-            #         proxydbClass = namedClass(self.config.ProxyDBService.type)
-            #         proxydb = proxydbClass(**self.config.ProxyDBService.params)
-
-            #     # MOVE2WHO FIXME: port to new group cacher
-            #     updater = GroupMembershipCacheUpdater(proxydb,
-            #         directory,
-            #         self.config.GroupCaching.UpdateSeconds,
-            #         self.config.GroupCaching.ExpireSeconds,
-            #         self.config.GroupCaching.LockSeconds,
-            #         namespace=self.config.GroupCaching.MemcachedPool,
-            #         useExternalProxies=self.config.GroupCaching.UseExternalProxies)
-            #     yield updater.updateCache(fast=True)
-
</del><span class="cx">             # Process old inbox items
</span><span class="cx">             self.store.setMigrating(True)
</span><span class="cx">             yield self.processInboxItems()
</span></span></pre></div>
<a id="CalendarServertrunktxdavwhogroupspy"></a>
<div class="modfile"><h4>Modified: CalendarServer/trunk/txdav/who/groups.py (13840 => 13841)</h4>
<pre class="diff"><span>
<span class="info">--- CalendarServer/trunk/txdav/who/groups.py        2014-08-05 22:49:28 UTC (rev 13840)
+++ CalendarServer/trunk/txdav/who/groups.py        2014-08-05 23:11:29 UTC (rev 13841)
</span><span class="lines">@@ -67,7 +67,6 @@
</span><span class="cx">         groupCacher = getattr(self.transaction, &quot;_groupCacher&quot;, None)
</span><span class="cx">         if groupCacher is not None:
</span><span class="cx"> 
</span><del>-            # New implementation
</del><span class="cx">             try:
</span><span class="cx">                 yield groupCacher.update(self.transaction)
</span><span class="cx">             except Exception, e:
</span></span></pre></div>
<a id="CalendarServertrunktxdavwhoutilpy"></a>
<div class="modfile"><h4>Modified: CalendarServer/trunk/txdav/who/util.py (13840 => 13841)</h4>
<pre class="diff"><span>
<span class="info">--- CalendarServer/trunk/txdav/who/util.py        2014-08-05 22:49:28 UTC (rev 13840)
+++ CalendarServer/trunk/txdav/who/util.py        2014-08-05 23:11:29 UTC (rev 13841)
</span><span class="lines">@@ -23,9 +23,9 @@
</span><span class="cx">     FieldName as BaseFieldName, RecordType, DirectoryConfigurationError
</span><span class="cx"> )
</span><span class="cx"> from twext.who.ldap import (
</span><del>-    DirectoryService as LDAPDirectoryService, LDAPAttribute,
</del><ins>+    DirectoryService as LDAPDirectoryService,
</ins><span class="cx">     FieldName as LDAPFieldName,
</span><del>-    RecordTypeSchema, LDAPObjectClass
</del><ins>+    RecordTypeSchema
</ins><span class="cx"> )
</span><span class="cx"> from twext.who.util import ConstantsContainer
</span><span class="cx"> from twisted.cred.credentials import UsernamePassword
</span><span class="lines">@@ -131,62 +131,40 @@
</span><span class="cx">                 )
</span><span class="cx">             else:
</span><span class="cx">                 creds = None
</span><ins>+            mapping = params.mapping
</ins><span class="cx">             directory = LDAPDirectoryService(
</span><span class="cx">                 params.uri,
</span><span class="cx">                 params.rdnSchema.base,
</span><span class="cx">                 credentials=creds,
</span><span class="cx">                 fieldNameToAttributesMap=MappingProxyType({
</span><del>-                    BaseFieldName.uid: (&quot;apple-generateduid&quot;,),
-                    BaseFieldName.guid: (&quot;apple-generateduid&quot;,),
-                    BaseFieldName.shortNames: (LDAPAttribute.uid.value,),
-                    BaseFieldName.fullNames: (LDAPAttribute.cn.value,),
-                    BaseFieldName.emailAddresses: (LDAPAttribute.mail.value,),
-                    BaseFieldName.password: (LDAPAttribute.userPassword.value,),
-                    LDAPFieldName.memberDNs: (LDAPAttribute.uniqueMember.value,),
</del><ins>+                    BaseFieldName.uid: mapping.uid,
+                    BaseFieldName.guid: mapping.guid,
+                    BaseFieldName.shortNames: mapping.shortNames,
+                    BaseFieldName.fullNames: mapping.fullNames,
+                    BaseFieldName.emailAddresses: mapping.emailAddresses,
+                    LDAPFieldName.memberDNs: mapping.memberDNs,
</ins><span class="cx">                 }),
</span><span class="cx">                 recordTypeSchemas=MappingProxyType({
</span><span class="cx">                     RecordType.user: RecordTypeSchema(
</span><del>-                        relativeDN=u&quot;ou=People&quot;,
-
-                        # (objectClass=inetOrgPerson)
-                        attributes=(
-                            (
-                                LDAPAttribute.objectClass.value,
-                                LDAPObjectClass.inetOrgPerson.value,
-                            ),
-                        ),
</del><ins>+                        relativeDN=params.rdnSchema.users,
+                        attributes=(),
</ins><span class="cx">                     ),
</span><del>-
</del><span class="cx">                     RecordType.group: RecordTypeSchema(
</span><del>-                        relativeDN=u&quot;ou=Groups&quot;,
-
-                        # (objectClass=groupOfNames)
-                        attributes=(
-                            (
-                                LDAPAttribute.objectClass.value,
-                                LDAPObjectClass.groupOfUniqueNames.value,
-                            ),
-                        ),
</del><ins>+                        relativeDN=params.rdnSchema.groups,
+                        attributes=(),
</ins><span class="cx">                     ),
</span><del>-
</del><span class="cx">                     CalRecordType.location: RecordTypeSchema(
</span><del>-                        relativeDN=u&quot;ou=places&quot;,
-
</del><ins>+                        relativeDN=params.rdnSchema.locations,
</ins><span class="cx">                         attributes=(),
</span><span class="cx">                     ),
</span><del>-
</del><span class="cx">                     CalRecordType.resource: RecordTypeSchema(
</span><del>-                        relativeDN=u&quot;ou=resources&quot;,
-
</del><ins>+                        relativeDN=params.rdnSchema.resources,
</ins><span class="cx">                         attributes=(),
</span><span class="cx">                     ),
</span><del>-
</del><span class="cx">                     CalRecordType.address: RecordTypeSchema(
</span><del>-                        relativeDN=u&quot;ou=buildings&quot;,
-
</del><ins>+                        relativeDN=params.rdnSchema.addresses,
</ins><span class="cx">                         attributes=(),
</span><span class="cx">                     ),
</span><del>-
</del><span class="cx">                 })
</span><span class="cx">             )
</span><span class="cx"> 
</span></span></pre>
</div>
</div>

</body>
</html>