<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[14100] twext/trunk/twext/who/ldap</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.calendarserver.org//changeset/14100">14100</a></dd>
<dt>Author</dt> <dd>sagen@apple.com</dd>
<dt>Date</dt> <dd>2014-10-23 15:40:08 -0700 (Thu, 23 Oct 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Fix boolean and multi-choice fields for LDAP</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#twexttrunktwextwholdap_servicepy">twext/trunk/twext/who/ldap/_service.py</a></li>
<li><a href="#twexttrunktwextwholdaptesttest_servicepy">twext/trunk/twext/who/ldap/test/test_service.py</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="twexttrunktwextwholdap_servicepy"></a>
<div class="modfile"><h4>Modified: twext/trunk/twext/who/ldap/_service.py (14099 => 14100)</h4>
<pre class="diff"><span>
<span class="info">--- twext/trunk/twext/who/ldap/_service.py 2014-10-23 16:58:03 UTC (rev 14099)
+++ twext/trunk/twext/who/ldap/_service.py 2014-10-23 22:40:08 UTC (rev 14100)
</span><span class="lines">@@ -302,7 +302,9 @@
</span><span class="cx"> for attribute in attributes:
</span><span class="cx"> if ":" in attribute:
</span><span class="cx"> attribute, ignored = attribute.split(":", 1)
</span><del>- self._attributeToFieldNameMap[attribute] = name
</del><ins>+ self._attributeToFieldNameMap.setdefault(
+ attribute, []
+ ).append(name)
</ins><span class="cx">
</span><span class="cx"> self._recordTypeSchemas = recordTypeSchemas
</span><span class="cx">
</span><span class="lines">@@ -758,81 +760,83 @@
</span><span class="cx"> fields = {}
</span><span class="cx">
</span><span class="cx"> for attribute, values in recordData.iteritems():
</span><del>- fieldName = self._attributeToFieldNameMap.get(attribute)
- attributeRules = self._fieldNameToAttributesMap[fieldName]
</del><ins>+ fieldNames = self._attributeToFieldNameMap.get(attribute, ())
+ for fieldName in fieldNames:
+ attributeRules = self._fieldNameToAttributesMap[fieldName]
</ins><span class="cx">
</span><del>- if fieldName is None:
- # self.log.debug(
- # "Unmapped LDAP attribute {attribute!r} in record "
- # "data: {recordData!r}",
- # attribute=attribute, recordData=recordData,
- # )
- continue
</del><ins>+ if fieldName is None:
+ # self.log.debug(
+ # "Unmapped LDAP attribute {attribute!r} in record "
+ # "data: {recordData!r}",
+ # attribute=attribute, recordData=recordData,
+ # )
+ continue
</ins><span class="cx">
</span><del>- valueType = self.fieldName.valueType(fieldName)
</del><ins>+ valueType = self.fieldName.valueType(fieldName)
</ins><span class="cx">
</span><del>- if valueType in (unicode, UUID):
- if not isinstance(values, list):
- values = [values]
</del><ins>+ if valueType in (unicode, UUID):
+ if not isinstance(values, list):
+ values = [values]
</ins><span class="cx">
</span><del>- if valueType is unicode:
- newValues = []
- for v in values:
- if isinstance(v, unicode):
- # because the ldap unit test produces
- # unicode values (?)
- newValues.append(v)
- else:
- newValues.append(unicode(v, "utf-8"))
- # newValues = [unicode(v, "utf-8") for v in values]
- else:
- newValues = [valueType(v) for v in values]
</del><ins>+ if valueType is unicode:
+ newValues = []
+ for v in values:
+ if isinstance(v, unicode):
+ # because the ldap unit test produces
+ # unicode values (?)
+ newValues.append(v)
+ else:
+ newValues.append(unicode(v, "utf-8"))
+ # newValues = [unicode(v, "utf-8") for v in values]
+ else:
+ newValues = [valueType(v) for v in values]
</ins><span class="cx">
</span><del>- if self.fieldName.isMultiValue(fieldName):
- fields[fieldName] = newValues
- else:
- fields[fieldName] = newValues[0]
</del><ins>+ if self.fieldName.isMultiValue(fieldName):
+ fields[fieldName] = newValues
+ else:
+ fields[fieldName] = newValues[0]
</ins><span class="cx">
</span><del>- elif valueType is bool:
- if not isinstance(values, list):
- values = [values]
</del><ins>+ elif valueType is bool:
+ if not isinstance(values, list):
+ values = [values]
</ins><span class="cx">
</span><del>- rule = attributeRules[0] # there is only one true value
- if ":" in rule:
- ignored, trueValue = rule.split(":")
- else:
- trueValue = "true"
</del><span class="cx">
</span><del>- for value in values:
- if value == trueValue:
- fields[fieldName] = True
- break
- else:
- fields[fieldName] = False
</del><ins>+ rule = attributeRules[0] # there is only one true value
+ if ":" in rule:
+ ignored, trueValue = rule.split(":")
+ else:
+ trueValue = "true"
</ins><span class="cx">
</span><del>- elif issubclass(valueType, Names):
- if not isinstance(values, list):
- values = [values]
-
- for rule in attributeRules:
- attribute, attributeValue, fieldValue = rule.split(":")
-
</del><span class="cx"> for value in values:
</span><del>- if value == attributeValue:
- # convert to a constant
- try:
- fieldValue = valueType.lookupByName(fieldValue)
- fields[fieldName] = fieldValue
- except ValueError:
- pass
</del><ins>+ if value == trueValue:
+ fields[fieldName] = True
</ins><span class="cx"> break
</span><ins>+ else:
+ fields[fieldName] = False
</ins><span class="cx">
</span><del>- else:
- raise LDAPConfigurationError(
- "Unknown value type {0} for field {1}".format(
- valueType, fieldName
</del><ins>+ elif issubclass(valueType, Names):
+ if not isinstance(values, list):
+ values = [values]
+
+ for rule in attributeRules:
+ attribute, attributeValue, fieldValue = rule.split(":")
+
+ for value in values:
+ if value == attributeValue:
+ # convert to a constant
+ try:
+ fieldValue = valueType.lookupByName(fieldValue)
+ fields[fieldName] = fieldValue
+ except ValueError:
+ pass
+ break
+
+ else:
+ raise LDAPConfigurationError(
+ "Unknown value type {0} for field {1}".format(
+ valueType, fieldName
+ )
</ins><span class="cx"> )
</span><del>- )
</del><span class="cx">
</span><span class="cx"> # Skip any results missing the uid, which is a required field
</span><span class="cx"> if self.fieldName.uid not in fields:
</span></span></pre></div>
<a id="twexttrunktwextwholdaptesttest_servicepy"></a>
<div class="modfile"><h4>Modified: twext/trunk/twext/who/ldap/test/test_service.py (14099 => 14100)</h4>
<pre class="diff"><span>
<span class="info">--- twext/trunk/twext/who/ldap/test/test_service.py 2014-10-23 16:58:03 UTC (rev 14099)
+++ twext/trunk/twext/who/ldap/test/test_service.py 2014-10-23 22:40:08 UTC (rev 14100)
</span><span class="lines">@@ -107,25 +107,49 @@
</span><span class="cx"> multiChoice.description = u"Multiple Choice Test Field"
</span><span class="cx"> multiChoice.valueType = TestFieldWithChoices
</span><span class="cx">
</span><del>- trueFalse = NamedConstant()
- trueFalse.description = u"Boolean Test Field"
- trueFalse.valueType = bool
</del><ins>+ boolean1 = NamedConstant()
+ boolean1.description = u"Boolean Test Field"
+ boolean1.valueType = bool
</ins><span class="cx">
</span><ins>+ boolean2 = NamedConstant()
+ boolean2.description = u"Boolean Test Field 2"
+ boolean2.valueType = bool
</ins><span class="cx">
</span><ins>+ boolean3 = NamedConstant()
+ boolean3.description = u"Boolean Test Field 3"
+ boolean3.valueType = bool
</ins><span class="cx">
</span><ins>+
</ins><span class="cx"> TEST_FIELDNAME_MAP = dict(DEFAULT_FIELDNAME_ATTRIBUTE_MAP)
</span><ins>+TEST_FIELDNAME_MAP[BaseFieldName.uid] = (u"__who_uid__",)
+
</ins><span class="cx"> TEST_FIELDNAME_MAP[TestFieldName.multiChoice] = (
</span><span class="cx"> u"testField:One:one",
</span><span class="cx"> u"testField:Two:two",
</span><span class="cx"> u"testField:Three:three",
</span><span class="cx"> )
</span><del>-TEST_FIELDNAME_MAP[TestFieldName.trueFalse] = (
</del><ins>+
+# Set up two Fields which will map to the same LDAP attribute ("foo")
+# to make sure both Fields get set. Their field values *will* be different,
+# based on whether there is a colon in the attribute rule. If the LDAP
+# value matches the string following the colon, the Field value will be True.
+# If there is no colon, then the string to match is literally the string "true".
+TEST_FIELDNAME_MAP[TestFieldName.boolean1] = (
</ins><span class="cx"> u"foo:active",
</span><span class="cx"> )
</span><del>-TEST_FIELDNAME_MAP[BaseFieldName.uid] = (u"__who_uid__",)
</del><ins>+TEST_FIELDNAME_MAP[TestFieldName.boolean2] = (
+ u"foo",
+)
</ins><span class="cx">
</span><ins>+# This Field will map to LDAP attribute "bar" and will be used for matching
+# the string "true"
+TEST_FIELDNAME_MAP[TestFieldName.boolean3] = (
+ u"bar",
+)
</ins><span class="cx">
</span><span class="cx">
</span><ins>+
+
</ins><span class="cx"> class TestService(DirectoryService, QueryMixIn):
</span><span class="cx"> pass
</span><span class="cx">
</span><span class="lines">@@ -430,6 +454,8 @@
</span><span class="cx"> {
</span><span class="cx"> "__who_uid__": u"active",
</span><span class="cx"> "foo": u"active",
</span><ins>+ "bar": u"true",
+ "unknown": u"unknown", # will ignore unknown LDAP attrs
</ins><span class="cx"> }
</span><span class="cx"> ),
</span><span class="cx"> (
</span><span class="lines">@@ -437,14 +463,21 @@
</span><span class="cx"> {
</span><span class="cx"> "__who_uid__": u"inactive",
</span><span class="cx"> "foo": u"inactive",
</span><ins>+ "bar": u"false",
</ins><span class="cx"> }
</span><span class="cx"> ),
</span><span class="cx"> )
</span><span class="cx"> records = service._recordsFromReply(reply, recordType=RecordType.user)
</span><del>- self.assertTrue(records[0].trueFalse)
- self.assertFalse(records[1].trueFalse)
</del><span class="cx">
</span><ins>+ self.assertTrue(records[0].boolean1) # foo == active so True
+ self.assertFalse(records[0].boolean2) # foo != true so False
+ self.assertTrue(records[0].boolean3) # bar == true so True
</ins><span class="cx">
</span><ins>+ self.assertFalse(records[1].boolean1) # foo != active so False
+ self.assertFalse(records[1].boolean2) # foo != true so False
+ self.assertFalse(records[1].boolean3) # bar != true so False
+
+
</ins><span class="cx"> def test_multipleChoice(self):
</span><span class="cx"> service = self.service()
</span><span class="cx"> reply = (
</span></span></pre>
</div>
</div>
</body>
</html>