<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[14492] CalendarServer/trunk/txdav</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.calendarserver.org//changeset/14492">14492</a></dd>
<dt>Author</dt> <dd>cdaboo@apple.com</dd>
<dt>Date</dt> <dd>2015-03-02 09:03:04 -0800 (Mon, 02 Mar 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Fix problem with sync revision deletes after a revision purge has removed the old entry for the item being deleted. Also same problem for rename.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#CalendarServertrunktxdavcaldavdatastoretesttest_sqlpy">CalendarServer/trunk/txdav/caldav/datastore/test/test_sql.py</a></li>
<li><a href="#CalendarServertrunktxdavcarddavdatastoresqlpy">CalendarServer/trunk/txdav/carddav/datastore/sql.py</a></li>
<li><a href="#CalendarServertrunktxdavcarddavdatastoretesttest_sqlpy">CalendarServer/trunk/txdav/carddav/datastore/test/test_sql.py</a></li>
<li><a href="#CalendarServertrunktxdavcommondatastoresqlpy">CalendarServer/trunk/txdav/common/datastore/sql.py</a></li>
<li><a href="#CalendarServertrunktxdavcommondatastoretesttest_sqlpy">CalendarServer/trunk/txdav/common/datastore/test/test_sql.py</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="CalendarServertrunktxdavcaldavdatastoretesttest_sqlpy"></a>
<div class="modfile"><h4>Modified: CalendarServer/trunk/txdav/caldav/datastore/test/test_sql.py (14491 => 14492)</h4>
<pre class="diff"><span>
<span class="info">--- CalendarServer/trunk/txdav/caldav/datastore/test/test_sql.py        2015-03-02 15:22:31 UTC (rev 14491)
+++ CalendarServer/trunk/txdav/caldav/datastore/test/test_sql.py        2015-03-02 17:03:04 UTC (rev 14492)
</span><span class="lines">@@ -2223,7 +2223,37 @@
</span><span class="cx"> yield self.commit()
</span><span class="cx">
</span><span class="cx">
</span><ins>+ @inlineCallbacks
+ def test_removeAfterRevisionCleanup(self):
+ """
+ Make sure L{Calendar}'s can be renamed after revision cleanup
+ removes their revision table entry..
+ """
+ yield self.homeUnderTest(name="user01", create=True)
+ cal = yield self.calendarUnderTest(home="user01", name="calendar")
+ self.assertTrue(cal is not None)
+ yield self.commit()
</ins><span class="cx">
</span><ins>+ # Remove the revision
+ cal = yield self.calendarUnderTest(home="user01", name="calendar")
+ yield cal.syncToken()
+ yield self.transactionUnderTest().deleteRevisionsBefore(cal._syncTokenRevision + 1)
+ yield self.commit()
+
+ # Rename the calendar
+ cal = yield self.calendarUnderTest(home="user01", name="calendar")
+ self.assertTrue(cal is not None)
+ yield cal.rename("calendar_renamed")
+ yield self.commit()
+
+ cal = yield self.calendarUnderTest(home="user01", name="calendar")
+ self.assertTrue(cal is None)
+ cal = yield self.calendarUnderTest(home="user01", name="calendar_renamed")
+ self.assertTrue(cal is not None)
+ yield self.commit()
+
+
+
</ins><span class="cx"> class SchedulingTests(CommonCommonTests, unittest.TestCase):
</span><span class="cx"> """
</span><span class="cx"> CalendarObject splitting tests
</span></span></pre></div>
<a id="CalendarServertrunktxdavcarddavdatastoresqlpy"></a>
<div class="modfile"><h4>Modified: CalendarServer/trunk/txdav/carddav/datastore/sql.py (14491 => 14492)</h4>
<pre class="diff"><span>
<span class="info">--- CalendarServer/trunk/txdav/carddav/datastore/sql.py        2015-03-02 15:22:31 UTC (rev 14491)
+++ CalendarServer/trunk/txdav/carddav/datastore/sql.py        2015-03-02 17:03:04 UTC (rev 14492)
</span><span class="lines">@@ -602,6 +602,14 @@
</span><span class="cx"> self._txn, resourceID=self._resourceID, name=name, id=id))
</span><span class="cx"> if rows:
</span><span class="cx"> self._syncTokenRevision = rows[0][0]
</span><ins>+ else:
+ # Nothing was matched on the delete so insert a new row
+ self._syncTokenRevision = (
+ yield self._completelyNewDeletedRevisionQuery.on(
+ self._txn, homeID=self.ownerHome()._resourceID,
+ resourceID=self._resourceID, name=name)
+ )[0][0]
+
</ins><span class="cx"> elif action == "update":
</span><span class="cx"> rows = (
</span><span class="cx"> yield self._updateBumpTokenQuery.on(
</span><span class="lines">@@ -609,9 +617,14 @@
</span><span class="cx"> if rows:
</span><span class="cx"> self._syncTokenRevision = rows[0][0]
</span><span class="cx"> else:
</span><del>- action = "insert"
</del><ins>+ # Nothing was matched on the update so insert a new row
+ self._syncTokenRevision = (
+ yield self._completelyNewRevisionQuery.on(
+ self._txn, homeID=self.ownerHome()._resourceID,
+ resourceID=self._resourceID, name=name)
+ )[0][0]
</ins><span class="cx">
</span><del>- if action == "insert":
</del><ins>+ elif action == "insert":
</ins><span class="cx"> # Note that an "insert" may happen for a resource that previously
</span><span class="cx"> # existed and then was deleted. In that case an entry in the
</span><span class="cx"> # REVISIONS table still exists so we have to detect that and do db
</span></span></pre></div>
<a id="CalendarServertrunktxdavcarddavdatastoretesttest_sqlpy"></a>
<div class="modfile"><h4>Modified: CalendarServer/trunk/txdav/carddav/datastore/test/test_sql.py (14491 => 14492)</h4>
<pre class="diff"><span>
<span class="info">--- CalendarServer/trunk/txdav/carddav/datastore/test/test_sql.py        2015-03-02 15:22:31 UTC (rev 14491)
+++ CalendarServer/trunk/txdav/carddav/datastore/test/test_sql.py        2015-03-02 17:03:04 UTC (rev 14492)
</span><span class="lines">@@ -917,3 +917,119 @@
</span><span class="cx"> obj = yield self.addressbookObjectUnderTest(name="data1.ics", addressbook_name="addressbook")
</span><span class="cx"> self.assertEqual(obj._dataversion, obj._currentDataVersion)
</span><span class="cx"> yield self.commit()
</span><ins>+
+
+ @inlineCallbacks
+ def test_updateAfterRevisionCleanup(self):
+ """
+ Make sure L{AddressBookObject}'s can be updated or removed after revision cleanup
+ removes their revision table entry..
+ """
+ person = """BEGIN:VCARD
+VERSION:3.0
+N:Thompson;Default1;;;
+FN:Default1 Thompson
+EMAIL;type=INTERNET;type=WORK;type=pref:lthompson1@example.com
+TEL;type=WORK;type=pref:1-555-555-5555
+TEL;type=CELL:1-444-444-4444
+item1.ADR;type=WORK;type=pref:;;1245 Test;Sesame Street;California;11111;USA
+item1.X-ABADR:us
+UID:uid-person
+X-ADDRESSBOOKSERVER-KIND:person
+END:VCARD
+"""
+ group = """BEGIN:VCARD
+VERSION:3.0
+N:Group;Fancy;;;
+FN:Fancy Group
+UID:uid-group
+X-ADDRESSBOOKSERVER-KIND:group
+X-ADDRESSBOOKSERVER-MEMBER:urn:uuid:uid-person
+END:VCARD
+"""
+ group_update = """BEGIN:VCARD
+VERSION:3.0
+N:Group2;Fancy;;;
+FN:Fancy Group2
+UID:uid-group
+X-ADDRESSBOOKSERVER-KIND:group
+X-ADDRESSBOOKSERVER-MEMBER:urn:uuid:uid-person
+END:VCARD
+"""
+
+ yield self.homeUnderTest()
+ adbk = yield self.addressbookUnderTest(name="addressbook")
+ yield adbk.createAddressBookObjectWithName("person.vcf", VCard.fromString(person))
+ yield adbk.createAddressBookObjectWithName("group.vcf", VCard.fromString(group))
+ yield self.commit()
+
+ # Remove the revision
+ adbk = yield self.addressbookUnderTest(name="addressbook")
+ yield adbk.syncToken()
+ yield self.transactionUnderTest().deleteRevisionsBefore(adbk._syncTokenRevision + 1)
+ yield self.commit()
+
+ # Update the object
+ obj = yield self.addressbookObjectUnderTest(name="group.vcf", addressbook_name="addressbook")
+ yield obj.setComponent(VCard.fromString(group_update))
+ yield self.commit()
+
+ obj = yield self.addressbookObjectUnderTest(name="group.vcf", addressbook_name="addressbook")
+ self.assertTrue(obj is not None)
+ obj = yield self.addressbookObjectUnderTest(name="person.vcf", addressbook_name="addressbook")
+ self.assertTrue(obj is not None)
+ yield self.commit()
+
+
+ @inlineCallbacks
+ def test_removeAfterRevisionCleanup(self):
+ """
+ Make sure L{AddressBookObject}'s can be updated or removed after revision cleanup
+ removes their revision table entry..
+ """
+ person = """BEGIN:VCARD
+VERSION:3.0
+N:Thompson;Default1;;;
+FN:Default1 Thompson
+EMAIL;type=INTERNET;type=WORK;type=pref:lthompson1@example.com
+TEL;type=WORK;type=pref:1-555-555-5555
+TEL;type=CELL:1-444-444-4444
+item1.ADR;type=WORK;type=pref:;;1245 Test;Sesame Street;California;11111;USA
+item1.X-ABADR:us
+UID:uid-person
+X-ADDRESSBOOKSERVER-KIND:person
+END:VCARD
+"""
+ group = """BEGIN:VCARD
+VERSION:3.0
+N:Group;Fancy;;;
+FN:Fancy Group
+UID:uid-group
+X-ADDRESSBOOKSERVER-KIND:group
+X-ADDRESSBOOKSERVER-MEMBER:urn:uuid:uid-person
+END:VCARD
+"""
+
+ yield self.homeUnderTest()
+ adbk = yield self.addressbookUnderTest(name="addressbook")
+ yield adbk.createAddressBookObjectWithName("person.vcf", VCard.fromString(person))
+ yield adbk.createAddressBookObjectWithName("group.vcf", VCard.fromString(group))
+ yield self.commit()
+
+ # Remove the revision
+ adbk = yield self.addressbookUnderTest(name="addressbook")
+ yield adbk.syncToken()
+ yield self.transactionUnderTest().deleteRevisionsBefore(adbk._syncTokenRevision + 1)
+ yield self.commit()
+
+ # Remove the object
+ obj = yield self.addressbookObjectUnderTest(name="group.vcf", addressbook_name="addressbook")
+ self.assertTrue(obj is not None)
+ yield obj.remove()
+ yield self.commit()
+
+ obj = yield self.addressbookObjectUnderTest(name="group.vcf", addressbook_name="addressbook")
+ self.assertTrue(obj is None)
+ obj = yield self.addressbookObjectUnderTest(name="person.vcf", addressbook_name="addressbook")
+ self.assertTrue(obj is not None)
+ yield self.commit()
</ins></span></pre></div>
<a id="CalendarServertrunktxdavcommondatastoresqlpy"></a>
<div class="modfile"><h4>Modified: CalendarServer/trunk/txdav/common/datastore/sql.py (14491 => 14492)</h4>
<pre class="diff"><span>
<span class="info">--- CalendarServer/trunk/txdav/common/datastore/sql.py        2015-03-02 15:22:31 UTC (rev 14491)
+++ CalendarServer/trunk/txdav/common/datastore/sql.py        2015-03-02 17:03:04 UTC (rev 14492)
</span><span class="lines">@@ -4259,9 +4259,13 @@
</span><span class="cx">
</span><span class="cx"> @inlineCallbacks
</span><span class="cx"> def _renameSyncToken(self):
</span><del>- self._syncTokenRevision = (yield self._renameSyncTokenQuery.on(
- self._txn, name=self._name, resourceID=self._resourceID))[0][0]
- self._txn.bumpRevisionForObject(self)
</del><ins>+ rows = yield self._renameSyncTokenQuery.on(
+ self._txn, name=self._name, resourceID=self._resourceID)
+ if rows:
+ self._syncTokenRevision = rows[0][0]
+ self._txn.bumpRevisionForObject(self)
+ else:
+ yield self._initSyncToken()
</ins><span class="cx">
</span><span class="cx">
</span><span class="cx"> @classproperty
</span><span class="lines">@@ -4440,6 +4444,21 @@
</span><span class="cx"> )
</span><span class="cx">
</span><span class="cx">
</span><ins>+ @classproperty
+ def _completelyNewDeletedRevisionQuery(cls):
+ rev = cls._revisionsSchema
+ return Insert(
+ {
+ rev.HOME_RESOURCE_ID: Parameter("homeID"),
+ rev.RESOURCE_ID: Parameter("resourceID"),
+ rev.RESOURCE_NAME: Parameter("name"),
+ rev.REVISION: schema.REVISION_SEQ,
+ rev.DELETED: True
+ },
+ Return=rev.REVISION
+ )
+
+
</ins><span class="cx"> @inlineCallbacks
</span><span class="cx"> def _changeRevision(self, action, name):
</span><span class="cx">
</span><span class="lines">@@ -4452,6 +4471,13 @@
</span><span class="cx"> self._txn, resourceID=self._resourceID, name=name))
</span><span class="cx"> if rows:
</span><span class="cx"> self._syncTokenRevision = rows[0][0]
</span><ins>+ else:
+ self._syncTokenRevision = (
+ yield self._completelyNewDeletedRevisionQuery.on(
+ self._txn, homeID=self.ownerHome()._resourceID,
+ resourceID=self._resourceID, name=name)
+ )[0][0]
+
</ins><span class="cx"> elif action == "update":
</span><span class="cx"> rows = (
</span><span class="cx"> yield self._updateBumpTokenQuery.on(
</span><span class="lines">@@ -4459,9 +4485,13 @@
</span><span class="cx"> if rows:
</span><span class="cx"> self._syncTokenRevision = rows[0][0]
</span><span class="cx"> else:
</span><del>- action = "insert"
</del><ins>+ self._syncTokenRevision = (
+ yield self._completelyNewRevisionQuery.on(
+ self._txn, homeID=self.ownerHome()._resourceID,
+ resourceID=self._resourceID, name=name)
+ )[0][0]
</ins><span class="cx">
</span><del>- if action == "insert":
</del><ins>+ elif action == "insert":
</ins><span class="cx"> # Note that an "insert" may happen for a resource that previously
</span><span class="cx"> # existed and then was deleted. In that case an entry in the
</span><span class="cx"> # REVISIONS table still exists so we have to detect that and do db
</span></span></pre></div>
<a id="CalendarServertrunktxdavcommondatastoretesttest_sqlpy"></a>
<div class="modfile"><h4>Modified: CalendarServer/trunk/txdav/common/datastore/test/test_sql.py (14491 => 14492)</h4>
<pre class="diff"><span>
<span class="info">--- CalendarServer/trunk/txdav/common/datastore/test/test_sql.py        2015-03-02 15:22:31 UTC (rev 14491)
+++ CalendarServer/trunk/txdav/common/datastore/test/test_sql.py        2015-03-02 17:03:04 UTC (rev 14492)
</span><span class="lines">@@ -346,7 +346,7 @@
</span><span class="cx"> token = yield homeChild.syncToken()
</span><span class="cx"> yield homeChild._changeRevision("delete", "E")
</span><span class="cx"> changed = yield homeChild.resourceNamesSinceToken(token)
</span><del>- self.assertEqual(changed, ([], [], [],))
</del><ins>+ self.assertEqual(changed, ([], ["E"], [],))
</ins><span class="cx">
</span><span class="cx"> yield txn.abort()
</span><span class="cx">
</span></span></pre>
</div>
</div>
</body>
</html>