<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[14684] CalendarServer/trunk/calendarserver/tap/test/test_caldav.py</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.calendarserver.org//changeset/14684">14684</a></dd>
<dt>Author</dt> <dd>sagen@apple.com</dd>
<dt>Date</dt> <dd>2015-04-17 11:32:48 -0700 (Fri, 17 Apr 2015)</dd>
</dl>

<h3>Log Message</h3>
<pre>Fix the memcache tests so stopService( ) returns a deferred</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#CalendarServertrunkcalendarservertaptesttest_caldavpy">CalendarServer/trunk/calendarserver/tap/test/test_caldav.py</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="CalendarServertrunkcalendarservertaptesttest_caldavpy"></a>
<div class="modfile"><h4>Modified: CalendarServer/trunk/calendarserver/tap/test/test_caldav.py (14683 => 14684)</h4>
<pre class="diff"><span>
<span class="info">--- CalendarServer/trunk/calendarserver/tap/test/test_caldav.py        2015-04-17 18:11:45 UTC (rev 14683)
+++ CalendarServer/trunk/calendarserver/tap/test/test_caldav.py        2015-04-17 18:32:48 UTC (rev 14684)
</span><span class="lines">@@ -26,17 +26,18 @@
</span><span class="cx"> 
</span><span class="cx"> from zope.interface import implements
</span><span class="cx"> 
</span><ins>+from twisted.application import service
</ins><span class="cx"> from twisted.python import log as logging
</span><span class="cx"> from twisted.python.threadable import isInIOThread
</span><span class="cx"> from twisted.internet.reactor import callFromThread
</span><span class="cx"> from twisted.python.usage import Options, UsageError
</span><span class="cx"> from twisted.python.procutils import which
</span><span class="cx"> 
</span><del>-from twisted.runner.procmon import ProcessMonitor
</del><ins>+from twisted.runner.procmon import ProcessMonitor, LoggingProtocol
</ins><span class="cx"> 
</span><span class="cx"> from twisted.internet.interfaces import IProcessTransport, IReactorProcess
</span><span class="cx"> from twisted.internet.protocol import ServerFactory
</span><del>-from twisted.internet.defer import Deferred, inlineCallbacks, succeed
</del><ins>+from twisted.internet.defer import Deferred, inlineCallbacks, succeed, gatherResults
</ins><span class="cx"> from twisted.internet.task import Clock
</span><span class="cx"> from twisted.internet import reactor
</span><span class="cx"> from twisted.application.service import (IService, IServiceCollection
</span><span class="lines">@@ -443,12 +444,70 @@
</span><span class="cx">             self.assertEquals(socketService.gid, self.alternateGroup)
</span><span class="cx"> 
</span><span class="cx"> 
</span><ins>+class TestLoggingProtocol(LoggingProtocol):
</ins><span class="cx"> 
</span><ins>+    def processEnded(self, reason):
+        LoggingProtocol.processEnded(self, reason)
+        self.service.processEnded(self.name)
+
+
+class TestProcessMonitor(ProcessMonitor):
+
+    def startProcess(self, name):
+        &quot;&quot;&quot;
+        @param name: The name of the process to be started
+        &quot;&quot;&quot;
+        # If a protocol instance already exists, it means the process is
+        # already running
+        if name in self.protocols:
+            return
+
+        args, uid, gid, env = self.processes[name]
+
+        proto = TestLoggingProtocol()
+        proto.service = self
+        proto.name = name
+        self.protocols[name] = proto
+        self.timeStarted[name] = self._reactor.seconds()
+        self._reactor.spawnProcess(
+            proto, args[0], args, uid=uid, gid=gid, env=env
+        )
+
+    def stopService(self):
+        &quot;&quot;&quot;
+        Return a deferred that fires when all child processes have ended.
+        &quot;&quot;&quot;
+        service.Service.stopService(self)
+
+        self.stopping = True
+        self.deferreds = {}
+        for name in self.processes:
+            self.deferreds[name] = Deferred()
+
+        # Cancel any outstanding restarts
+        for name, delayedCall in self.restart.items():
+            if delayedCall.active():
+                delayedCall.cancel()
+
+        for name in self.processes:
+            self.stopProcess(name)
+
+        return gatherResults(self.deferreds.values())
+
+
+    def processEnded(self, name):
+        if self.stopping:
+            deferred = self.deferreds.pop(name, None)
+            if deferred is not None:
+                deferred.callback(None)
+
</ins><span class="cx"> class MemcacheSpawner(TestCase):
</span><span class="cx"> 
</span><span class="cx">     def setUp(self):
</span><span class="cx">         super(MemcacheSpawner, self).setUp()
</span><del>-        self.monitor = ProcessMonitor()
</del><ins>+        self.patch(config.Memcached.Pools.Default, &quot;ServerEnabled&quot;, True)
+
+        self.monitor = TestProcessMonitor()
</ins><span class="cx">         self.monitor.startService()
</span><span class="cx">         self.socket = os.path.join(tempfile.gettempdir(), &quot;memcache.sock&quot;)
</span><span class="cx">         self.patch(config.Memcached.Pools.Default, &quot;ServerEnabled&quot;, True)
</span></span></pre>
</div>
</div>

</body>
</html>