<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[14841] CalendarServer/trunk</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.calendarserver.org//changeset/14841">14841</a></dd>
<dt>Author</dt> <dd>cdaboo@apple.com</dd>
<dt>Date</dt> <dd>2015-05-28 08:32:34 -0700 (Thu, 28 May 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Make sure POST/trash operations require authorization.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#CalendarServertrunkrequirementsdevtxt">CalendarServer/trunk/requirements-dev.txt</a></li>
<li><a href="#CalendarServertrunktwistedcaldavresourcepy">CalendarServer/trunk/twistedcaldav/resource.py</a></li>
<li><a href="#CalendarServertrunktwistedcaldavstorebridgepy">CalendarServer/trunk/twistedcaldav/storebridge.py</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="CalendarServertrunkrequirementsdevtxt"></a>
<div class="modfile"><h4>Modified: CalendarServer/trunk/requirements-dev.txt (14840 => 14841)</h4>
<pre class="diff"><span>
<span class="info">--- CalendarServer/trunk/requirements-dev.txt 2015-05-28 15:28:02 UTC (rev 14840)
+++ CalendarServer/trunk/requirements-dev.txt 2015-05-28 15:32:34 UTC (rev 14841)
</span><span class="lines">@@ -8,4 +8,4 @@
</span><span class="cx"> q
</span><span class="cx"> tl.eggdeps
</span><span class="cx"> --editable svn+http://svn.calendarserver.org/repository/calendarserver/CalDAVClientLibrary/trunk@14811#egg=CalDAVClientLibrary
</span><del>---editable svn+http://svn.calendarserver.org/repository/calendarserver/CalDAVTester/trunk@14838#egg=CalDAVTester
</del><ins>+--editable svn+http://svn.calendarserver.org/repository/calendarserver/CalDAVTester/trunk@14840#egg=CalDAVTester
</ins></span></pre></div>
<a id="CalendarServertrunktwistedcaldavresourcepy"></a>
<div class="modfile"><h4>Modified: CalendarServer/trunk/twistedcaldav/resource.py (14840 => 14841)</h4>
<pre class="diff"><span>
<span class="info">--- CalendarServer/trunk/twistedcaldav/resource.py 2015-05-28 15:28:02 UTC (rev 14840)
+++ CalendarServer/trunk/twistedcaldav/resource.py 2015-05-28 15:32:34 UTC (rev 14841)
</span><span class="lines">@@ -102,6 +102,35 @@
</span><span class="cx"> shareAcceptStatesByXML["DECLINED"] = customxml.InviteStatusDeclined()
</span><span class="cx"> shareAcceptStatesByXML["DELETED"] = customxml.InviteStatusDeleted()
</span><span class="cx">
</span><ins>+def requiresPermissions(*permissions, **kw):
+ """
+ A decorator to wrap http_ methods in, to indicate that they should not be
+ run until the current user principal has been authorized for the given
+ permission set.
+ """
+ fromParent = kw.get('fromParent')
+ # FIXME: direct unit tests
+ def wrap(thunk):
+ def authAndContinue(self, request, *args, **kwargs):
+ if permissions:
+ d = self.authorize(request, permissions)
+ else:
+ d = succeed(None)
+ if fromParent:
+ d.addCallback(
+ lambda whatever:
+ request.locateResource(parentForURL(request.uri))
+ ).addCallback(
+ lambda parent:
+ parent.authorize(request, fromParent)
+ )
+ d.addCallback(lambda whatever: thunk(self, request, *args, **kwargs))
+ return d
+ return authAndContinue
+ return wrap
+
+
+
</ins><span class="cx"> class CalDAVComplianceMixIn(object):
</span><span class="cx"> def davComplianceClasses(self):
</span><span class="cx"> return (
</span><span class="lines">@@ -2733,6 +2762,7 @@
</span><span class="cx"> returnValue((changed, deleted, notallowed))
</span><span class="cx">
</span><span class="cx">
</span><ins>+ @requiresPermissions(element.WriteContent())
</ins><span class="cx"> @inlineCallbacks
</span><span class="cx"> def POST_handler_action(self, request, action):
</span><span class="cx"> """
</span></span></pre></div>
<a id="CalendarServertrunktwistedcaldavstorebridgepy"></a>
<div class="modfile"><h4>Modified: CalendarServer/trunk/twistedcaldav/storebridge.py (14840 => 14841)</h4>
<pre class="diff"><span>
<span class="info">--- CalendarServer/trunk/twistedcaldav/storebridge.py 2015-05-28 15:28:02 UTC (rev 14840)
+++ CalendarServer/trunk/twistedcaldav/storebridge.py 2015-05-28 15:32:34 UTC (rev 14841)
</span><span class="lines">@@ -43,7 +43,8 @@
</span><span class="cx"> )
</span><span class="cx"> from twistedcaldav.memcachelock import MemcacheLockTimeoutError
</span><span class="cx"> from twistedcaldav.notifications import NotificationCollectionResource, NotificationResource
</span><del>-from twistedcaldav.resource import CalDAVResource, DefaultAlarmPropertyMixin
</del><ins>+from twistedcaldav.resource import CalDAVResource, DefaultAlarmPropertyMixin, \
+ requiresPermissions
</ins><span class="cx"> from twistedcaldav.scheduling_store.caldav.resource import ScheduleInboxResource
</span><span class="cx"> from twistedcaldav.sharing import (
</span><span class="cx"> invitationBindStatusToXMLMap, invitationBindModeToXMLMap
</span><span class="lines">@@ -169,35 +170,6 @@
</span><span class="cx">
</span><span class="cx">
</span><span class="cx">
</span><del>-def requiresPermissions(*permissions, **kw):
- """
- A decorator to wrap http_ methods in, to indicate that they should not be
- run until the current user principal has been authorized for the given
- permission set.
- """
- fromParent = kw.get('fromParent')
- # FIXME: direct unit tests
- def wrap(thunk):
- def authAndContinue(self, request, *args, **kwargs):
- if permissions:
- d = self.authorize(request, permissions)
- else:
- d = succeed(None)
- if fromParent:
- d.addCallback(
- lambda whatever:
- request.locateResource(parentForURL(request.uri))
- ).addCallback(
- lambda parent:
- parent.authorize(request, fromParent)
- )
- d.addCallback(lambda whatever: thunk(self, request, *args, **kwargs))
- return d
- return authAndContinue
- return wrap
-
-
-
</del><span class="cx"> class _NewStoreFileMetaDataHelper(object):
</span><span class="cx">
</span><span class="cx"> def exists(self):
</span></span></pre>
</div>
</div>
</body>
</html>