<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[15134] PyKerberos/trunk/src/kerberos.c</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.calendarserver.org//changeset/15134">15134</a></dd>
<dt>Author</dt> <dd>cdaboo@apple.com</dd>
<dt>Date</dt> <dd>2015-09-18 09:35:52 -0700 (Fri, 18 Sep 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Fix issues with uninitialized variables for unused keyword arguments.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#PyKerberostrunksrckerberosc">PyKerberos/trunk/src/kerberos.c</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="PyKerberostrunksrckerberosc"></a>
<div class="modfile"><h4>Modified: PyKerberos/trunk/src/kerberos.c (15133 => 15134)</h4>
<pre class="diff"><span>
<span class="info">--- PyKerberos/trunk/src/kerberos.c 2015-09-18 16:35:20 UTC (rev 15133)
+++ PyKerberos/trunk/src/kerberos.c 2015-09-18 16:35:52 UTC (rev 15134)
</span><span class="lines">@@ -129,10 +129,10 @@
</span><span class="cx"> {
</span><span class="cx"> const char *service = NULL;
</span><span class="cx"> const char *principal = NULL;
</span><del>- gss_client_state *state;
- PyObject *pystate;
</del><ins>+ gss_client_state *state = NULL;
+ PyObject *pystate = NULL;
</ins><span class="cx"> gss_server_state *delegatestate = NULL;
</span><del>- PyObject *pydelegatestate;
</del><ins>+ PyObject *pydelegatestate = NULL;
</ins><span class="cx"> static char *kwlist[] = {
</span><span class="cx"> "service", "principal", "gssflags", "delegated", NULL
</span><span class="cx"> };
</span><span class="lines">@@ -149,7 +149,7 @@
</span><span class="cx"> state = (gss_client_state *) malloc(sizeof(gss_client_state));
</span><span class="cx"> pystate = PyCObject_FromVoidPtr(state, NULL);
</span><span class="cx">
</span><del>- if (PyCObject_Check(pydelegatestate)) {
</del><ins>+ if (pydelegatestate != NULL && PyCObject_Check(pydelegatestate)) {
</ins><span class="cx"> delegatestate = PyCObject_AsVoidPtr(pydelegatestate);
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -166,8 +166,8 @@
</span><span class="cx">
</span><span class="cx"> static PyObject *authGSSClientClean(PyObject *self, PyObject *args)
</span><span class="cx"> {
</span><del>- gss_client_state *state;
- PyObject *pystate;
</del><ins>+ gss_client_state *state = NULL;
+ PyObject *pystate = NULL;
</ins><span class="cx"> int result = 0;
</span><span class="cx">
</span><span class="cx"> if (! PyArg_ParseTuple(args, "O", &pystate)) {
</span><span class="lines">@@ -193,8 +193,8 @@
</span><span class="cx">
</span><span class="cx"> static PyObject *authGSSClientStep(PyObject *self, PyObject *args)
</span><span class="cx"> {
</span><del>- gss_client_state *state;
- PyObject *pystate;
</del><ins>+ gss_client_state *state = NULL;
+ PyObject *pystate = NULL;
</ins><span class="cx"> char *challenge = NULL;
</span><span class="cx"> int result = 0;
</span><span class="cx">
</span><span class="lines">@@ -224,8 +224,8 @@
</span><span class="cx">
</span><span class="cx"> static PyObject *authGSSClientResponseConf(PyObject *self, PyObject *args)
</span><span class="cx"> {
</span><del>- gss_client_state *state;
- PyObject *pystate;
</del><ins>+ gss_client_state *state = NULL;
+ PyObject *pystate = NULL;
</ins><span class="cx">
</span><span class="cx"> if (! PyArg_ParseTuple(args, "O", &pystate)) {
</span><span class="cx"> return NULL;
</span><span class="lines">@@ -247,8 +247,8 @@
</span><span class="cx">
</span><span class="cx"> static PyObject *authGSSServerHasDelegated(PyObject *self, PyObject *args)
</span><span class="cx"> {
</span><del>- gss_server_state *state;
- PyObject *pystate;
</del><ins>+ gss_server_state *state = NULL;
+ PyObject *pystate = NULL;
</ins><span class="cx">
</span><span class="cx"> if (! PyArg_ParseTuple(args, "O", &pystate)) {
</span><span class="cx"> return NULL;
</span><span class="lines">@@ -270,8 +270,8 @@
</span><span class="cx">
</span><span class="cx"> static PyObject *authGSSClientResponse(PyObject *self, PyObject *args)
</span><span class="cx"> {
</span><del>- gss_client_state *state;
- PyObject *pystate;
</del><ins>+ gss_client_state *state = NULL;
+ PyObject *pystate = NULL;
</ins><span class="cx">
</span><span class="cx"> if (! PyArg_ParseTuple(args, "O", &pystate)) {
</span><span class="cx"> return NULL;
</span><span class="lines">@@ -293,8 +293,8 @@
</span><span class="cx">
</span><span class="cx"> static PyObject *authGSSClientUserName(PyObject *self, PyObject *args)
</span><span class="cx"> {
</span><del>- gss_client_state *state;
- PyObject *pystate;
</del><ins>+ gss_client_state *state = NULL;
+ PyObject *pystate = NULL;
</ins><span class="cx">
</span><span class="cx"> if (! PyArg_ParseTuple(args, "O", &pystate)) {
</span><span class="cx"> return NULL;
</span><span class="lines">@@ -316,8 +316,8 @@
</span><span class="cx">
</span><span class="cx"> static PyObject *authGSSClientUnwrap(PyObject *self, PyObject *args)
</span><span class="cx"> {
</span><del>- gss_client_state *state;
- PyObject *pystate;
</del><ins>+ gss_client_state *state = NULL;
+ PyObject *pystate = NULL;
</ins><span class="cx"> char *challenge = NULL;
</span><span class="cx"> int result = 0;
</span><span class="cx">
</span><span class="lines">@@ -347,8 +347,8 @@
</span><span class="cx">
</span><span class="cx"> static PyObject *authGSSClientWrap(PyObject *self, PyObject *args)
</span><span class="cx"> {
</span><del>- gss_client_state *state;
- PyObject *pystate;
</del><ins>+ gss_client_state *state = NULL;
+ PyObject *pystate = NULL;
</ins><span class="cx"> char *challenge = NULL;
</span><span class="cx"> char *user = NULL;
</span><span class="cx"> int protect = 0;
</span><span class="lines">@@ -382,8 +382,8 @@
</span><span class="cx">
</span><span class="cx"> static PyObject *authGSSClientInquireCred(PyObject *self, PyObject *args)
</span><span class="cx"> {
</span><del>- gss_client_state *state;
- PyObject *pystate;
</del><ins>+ gss_client_state *state = NULL;
+ PyObject *pystate = NULL;
</ins><span class="cx"> int result = 0;
</span><span class="cx"> if (!PyArg_ParseTuple(args, "O", &pystate)) {
</span><span class="cx"> return NULL;
</span><span class="lines">@@ -410,8 +410,8 @@
</span><span class="cx"> static PyObject *authGSSServerInit(PyObject *self, PyObject *args)
</span><span class="cx"> {
</span><span class="cx"> const char *service = NULL;
</span><del>- gss_server_state *state;
- PyObject *pystate;
</del><ins>+ gss_server_state *state = NULL;
+ PyObject *pystate = NULL;
</ins><span class="cx"> int result = 0;
</span><span class="cx">
</span><span class="cx"> if (! PyArg_ParseTuple(args, "s", &service)) {
</span><span class="lines">@@ -432,8 +432,8 @@
</span><span class="cx">
</span><span class="cx"> static PyObject *authGSSServerClean(PyObject *self, PyObject *args)
</span><span class="cx"> {
</span><del>- gss_server_state *state;
- PyObject *pystate;
</del><ins>+ gss_server_state *state = NULL;
+ PyObject *pystate = NULL;
</ins><span class="cx"> int result = 0;
</span><span class="cx">
</span><span class="cx"> if (! PyArg_ParseTuple(args, "O", &pystate)) {
</span><span class="lines">@@ -459,8 +459,8 @@
</span><span class="cx">
</span><span class="cx"> static PyObject *authGSSServerStep(PyObject *self, PyObject *args)
</span><span class="cx"> {
</span><del>- gss_server_state *state;
- PyObject *pystate;
</del><ins>+ gss_server_state *state = NULL;
+ PyObject *pystate = NULL;
</ins><span class="cx"> char *challenge = NULL;
</span><span class="cx"> int result = 0;
</span><span class="cx">
</span><span class="lines">@@ -490,8 +490,8 @@
</span><span class="cx">
</span><span class="cx"> static PyObject *authGSSServerStoreDelegate(PyObject *self, PyObject *args)
</span><span class="cx"> {
</span><del>- gss_server_state *state;
- PyObject *pystate;
</del><ins>+ gss_server_state *state = NULL;
+ PyObject *pystate = NULL;
</ins><span class="cx"> int result = 0;
</span><span class="cx">
</span><span class="cx"> if (! PyArg_ParseTuple(args, "O", &pystate)) {
</span><span class="lines">@@ -520,8 +520,8 @@
</span><span class="cx">
</span><span class="cx"> static PyObject *authGSSServerResponse(PyObject *self, PyObject *args)
</span><span class="cx"> {
</span><del>- gss_server_state *state;
- PyObject *pystate;
</del><ins>+ gss_server_state *state = NULL;
+ PyObject *pystate = NULL;
</ins><span class="cx">
</span><span class="cx"> if (! PyArg_ParseTuple(args, "O", &pystate)) {
</span><span class="cx"> return NULL;
</span><span class="lines">@@ -543,8 +543,8 @@
</span><span class="cx">
</span><span class="cx"> static PyObject *authGSSServerUserName(PyObject *self, PyObject *args)
</span><span class="cx"> {
</span><del>- gss_server_state *state;
- PyObject *pystate;
</del><ins>+ gss_server_state *state = NULL;
+ PyObject *pystate = NULL;
</ins><span class="cx">
</span><span class="cx"> if (! PyArg_ParseTuple(args, "O", &pystate)) {
</span><span class="cx"> return NULL;
</span><span class="lines">@@ -566,8 +566,8 @@
</span><span class="cx">
</span><span class="cx"> static PyObject *authGSSServerCacheName(PyObject *self, PyObject *args)
</span><span class="cx"> {
</span><del>- gss_server_state *state;
- PyObject *pystate;
</del><ins>+ gss_server_state *state = NULL;
+ PyObject *pystate = NULL;
</ins><span class="cx">
</span><span class="cx"> if (! PyArg_ParseTuple(args, "O", &pystate)) {
</span><span class="cx"> return NULL;
</span><span class="lines">@@ -589,8 +589,8 @@
</span><span class="cx">
</span><span class="cx"> static PyObject *authGSSServerTargetName(PyObject *self, PyObject *args)
</span><span class="cx"> {
</span><del>- gss_server_state *state;
- PyObject *pystate;
</del><ins>+ gss_server_state *state = NULL;
+ PyObject *pystate = NULL;
</ins><span class="cx">
</span><span class="cx"> if (! PyArg_ParseTuple(args, "O", &pystate)) {
</span><span class="cx"> return NULL;
</span></span></pre>
</div>
</div>
</body>
</html>