<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[15193] CalendarServer/branches/release/CalendarServer-5.4-dev/txdav/caldav/datastore/scheduling/imip</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://trac.calendarserver.org//changeset/15193">15193</a></dd>
<dt>Author</dt> <dd>sagen@apple.com</dd>
<dt>Date</dt> <dd>2015-10-15 14:05:45 -0700 (Thu, 15 Oct 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>Scrub embedded mail headers; add PRODID missing from replies</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#CalendarServerbranchesreleaseCalendarServer54devtxdavcaldavdatastoreschedulingimipinboundpy">CalendarServer/branches/release/CalendarServer-5.4-dev/txdav/caldav/datastore/scheduling/imip/inbound.py</a></li>
<li><a href="#CalendarServerbranchesreleaseCalendarServer54devtxdavcaldavdatastoreschedulingimipoutboundpy">CalendarServer/branches/release/CalendarServer-5.4-dev/txdav/caldav/datastore/scheduling/imip/outbound.py</a></li>
<li><a href="#CalendarServerbranchesreleaseCalendarServer54devtxdavcaldavdatastoreschedulingimiptesttest_inboundpy">CalendarServer/branches/release/CalendarServer-5.4-dev/txdav/caldav/datastore/scheduling/imip/test/test_inbound.py</a></li>
<li><a href="#CalendarServerbranchesreleaseCalendarServer54devtxdavcaldavdatastoreschedulingimiptesttest_outboundpy">CalendarServer/branches/release/CalendarServer-5.4-dev/txdav/caldav/datastore/scheduling/imip/test/test_outbound.py</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="CalendarServerbranchesreleaseCalendarServer54devtxdavcaldavdatastoreschedulingimipinboundpy"></a>
<div class="modfile"><h4>Modified: CalendarServer/branches/release/CalendarServer-5.4-dev/txdav/caldav/datastore/scheduling/imip/inbound.py (15192 => 15193)</h4>
<pre class="diff"><span>
<span class="info">--- CalendarServer/branches/release/CalendarServer-5.4-dev/txdav/caldav/datastore/scheduling/imip/inbound.py 2015-10-15 18:53:04 UTC (rev 15192)
+++ CalendarServer/branches/release/CalendarServer-5.4-dev/txdav/caldav/datastore/scheduling/imip/inbound.py 2015-10-15 21:05:45 UTC (rev 15193)
</span><span class="lines">@@ -175,7 +175,29 @@
</span><span class="cx"> yield txn.commit()
</span><span class="cx">
</span><span class="cx">
</span><ins>+def sanitizeCalendar(calendar):
+ """
+ Clean up specific issues seen in the wild from third party IMIP capable
+ servers.
</ins><span class="cx">
</span><ins>+ @param calendar: the calendar Component to sanitize
+ @type calendar: L{Component}
+ """
+ # Don't let a missing PRODID prevent the reply from being processed
+ if not calendar.hasProperty("PRODID"):
+ calendar.addProperty(
+ Property(
+ "PRODID", "Unknown"
+ )
+ )
+
+ # For METHOD:REPLY we can remove STATUS properties
+ methodProperty = calendar.getProperty("METHOD")
+ if methodProperty is not None:
+ if methodProperty.value() == "REPLY":
+ calendar.removeAllPropertiesWithName("STATUS")
+
+
</ins><span class="cx"> class MailReceiver(object):
</span><span class="cx">
</span><span class="cx"> NO_TOKEN = 0
</span><span class="lines">@@ -357,6 +379,8 @@
</span><span class="cx"> calendar = Component.fromString(calBody)
</span><span class="cx"> event = calendar.mainComponent()
</span><span class="cx">
</span><ins>+ sanitizeCalendar(calendar)
+
</ins><span class="cx"> calendar.removeAllButOneAttendee(attendee)
</span><span class="cx"> organizerProperty = calendar.getOrganizerProperty()
</span><span class="cx"> if organizerProperty is None:
</span></span></pre></div>
<a id="CalendarServerbranchesreleaseCalendarServer54devtxdavcaldavdatastoreschedulingimipoutboundpy"></a>
<div class="modfile"><h4>Modified: CalendarServer/branches/release/CalendarServer-5.4-dev/txdav/caldav/datastore/scheduling/imip/outbound.py (15192 => 15193)</h4>
<pre class="diff"><span>
<span class="info">--- CalendarServer/branches/release/CalendarServer-5.4-dev/txdav/caldav/datastore/scheduling/imip/outbound.py 2015-10-15 18:53:04 UTC (rev 15192)
+++ CalendarServer/branches/release/CalendarServer-5.4-dev/txdav/caldav/datastore/scheduling/imip/outbound.py 2015-10-15 21:05:45 UTC (rev 15193)
</span><span class="lines">@@ -22,6 +22,7 @@
</span><span class="cx">
</span><span class="cx"> from cStringIO import StringIO
</span><span class="cx"> import os
</span><ins>+import re
</ins><span class="cx">
</span><span class="cx"> from email.mime.multipart import MIMEMultipart
</span><span class="cx"> from email.mime.text import MIMEText
</span><span class="lines">@@ -48,6 +49,8 @@
</span><span class="cx"> log = Logger()
</span><span class="cx">
</span><span class="cx">
</span><ins>+EMBEDDED_HEADER_CHECK = re.compile(r'\n[^ \t]+:')
+
</ins><span class="cx"> """ SCHEMA:
</span><span class="cx"> create sequence WORKITEM_SEQ;
</span><span class="cx">
</span><span class="lines">@@ -484,6 +487,17 @@
</span><span class="cx"> returnValue(False)
</span><span class="cx">
</span><span class="cx">
</span><ins>+ def _scrubHeader(self, value):
+ """
+ Check for what would be considered "embedded headers" and, if present,
+ remove the newlines.
+ """
+ if EMBEDDED_HEADER_CHECK.search(value) is not None:
+ value = value.replace("\n", " ")
+ return value
+
+
+
</ins><span class="cx"> def generateEmail(self, inviteState, calendar, orgEmail, orgCN,
</span><span class="cx"> attendees, fromAddress, replyToAddress, toAddress,
</span><span class="cx"> language='en'):
</span><span class="lines">@@ -550,9 +564,9 @@
</span><span class="cx">
</span><span class="cx"> msg = MIMEMultipart()
</span><span class="cx"> msg["From"] = fromAddress
</span><del>- msg["Subject"] = details['subject']
- msg["Reply-To"] = replyToAddress
- msg["To"] = toAddress
</del><ins>+ msg["Subject"] = self._scrubHeader(details['subject'])
+ msg["Reply-To"] = self._scrubHeader(replyToAddress)
+ msg["To"] = self._scrubHeader(toAddress)
</ins><span class="cx"> msg["Date"] = rfc822date()
</span><span class="cx"> msgId = SMTPSender.betterMessageID()
</span><span class="cx"> msg["Message-ID"] = msgId
</span></span></pre></div>
<a id="CalendarServerbranchesreleaseCalendarServer54devtxdavcaldavdatastoreschedulingimiptesttest_inboundpy"></a>
<div class="modfile"><h4>Modified: CalendarServer/branches/release/CalendarServer-5.4-dev/txdav/caldav/datastore/scheduling/imip/test/test_inbound.py (15192 => 15193)</h4>
<pre class="diff"><span>
<span class="info">--- CalendarServer/branches/release/CalendarServer-5.4-dev/txdav/caldav/datastore/scheduling/imip/test/test_inbound.py 2015-10-15 18:53:04 UTC (rev 15192)
+++ CalendarServer/branches/release/CalendarServer-5.4-dev/txdav/caldav/datastore/scheduling/imip/test/test_inbound.py 2015-10-15 21:05:45 UTC (rev 15193)
</span><span class="lines">@@ -27,6 +27,7 @@
</span><span class="cx"> from txdav.caldav.datastore.scheduling.imip.inbound import injectMessage
</span><span class="cx"> from txdav.caldav.datastore.scheduling.imip.inbound import shouldDeleteAllMail
</span><span class="cx"> from txdav.caldav.datastore.scheduling.imip.inbound import IMAP4DownloadProtocol
</span><ins>+from txdav.caldav.datastore.scheduling.imip.inbound import sanitizeCalendar
</ins><span class="cx"> from txdav.caldav.datastore.scheduling.itip import iTIPRequestStatus
</span><span class="cx"> from txdav.caldav.datastore.test.util import buildCalendarStore
</span><span class="cx">
</span><span class="lines">@@ -473,6 +474,35 @@
</span><span class="cx">
</span><span class="cx">
</span><span class="cx">
</span><ins>+ def test_sanitizeCalendar(self):
+ """
+ Verify certain inbound third party mistakes are corrected.
+ """
+
+ data = """BEGIN:VCALENDAR
+VERSION:2.0
+METHOD:REPLY
+BEGIN:VEVENT
+UID:12345-67890
+DTSTAMP:20130208T120000Z
+DTSTART:20180601T120000Z
+DTEND:20180601T130000Z
+ORGANIZER:urn:x-uid:user01
+ATTENDEE:mailto:xyzzy@example.com;PARTSTAT=ACCEPTED
+STATUS:ACCEPTED
+END:VEVENT
+END:VCALENDAR
+"""
+ calendar = Component.fromString(data)
+ self.assertFalse(calendar.hasProperty("PRODID"))
+ self.assertTrue(calendar.masterComponent().hasProperty("STATUS"))
+ sanitizeCalendar(calendar)
+ self.assertTrue(calendar.hasProperty("PRODID"))
+ self.assertFalse(calendar.masterComponent().hasProperty("STATUS"))
+
+
+
+
</ins><span class="cx"> class StubFactory(object):
</span><span class="cx">
</span><span class="cx"> def __init__(self, actionTaken, deleteAllMail):
</span></span></pre></div>
<a id="CalendarServerbranchesreleaseCalendarServer54devtxdavcaldavdatastoreschedulingimiptesttest_outboundpy"></a>
<div class="modfile"><h4>Modified: CalendarServer/branches/release/CalendarServer-5.4-dev/txdav/caldav/datastore/scheduling/imip/test/test_outbound.py (15192 => 15193)</h4>
<pre class="diff"><span>
<span class="info">--- CalendarServer/branches/release/CalendarServer-5.4-dev/txdav/caldav/datastore/scheduling/imip/test/test_outbound.py 2015-10-15 18:53:04 UTC (rev 15192)
+++ CalendarServer/branches/release/CalendarServer-5.4-dev/txdav/caldav/datastore/scheduling/imip/test/test_outbound.py 2015-10-15 21:05:45 UTC (rev 15193)
</span><span class="lines">@@ -53,7 +53,7 @@
</span><span class="cx"> F-B543-B2F29A7EEB0B
</span><span class="cx"> ORGANIZER;CN=Th\xe9 Organizer;EMAIL=organizer@example.com:urn:uuid:C3B38B00-
</span><span class="cx"> 4166-11DD-B22C-A07C87E02F6A
</span><del>-SUMMARY:t\xe9sting outbound( )
</del><ins>+SUMMARY:testing outbound( )\\nEmbedded: Header
</ins><span class="cx"> DESCRIPTION:awesome description with "<" and "&"
</span><span class="cx"> END:VEVENT
</span><span class="cx"> END:VCALENDAR
</span><span class="lines">@@ -387,6 +387,7 @@
</span><span class="cx"> u"Th\xe9 Organizer <organizer@example.com>",
</span><span class="cx"> "=?utf-8?q?Th=C3=A9_Organizer_=3Corganizer=40example=2Ecom=3E?=",
</span><span class="cx"> "attendee@example.com",
</span><ins>+ "Event invitation: testing outbound( ) Embedded: Header",
</ins><span class="cx"> ),
</span><span class="cx">
</span><span class="cx"> # Update
</span><span class="lines">@@ -421,6 +422,7 @@
</span><span class="cx"> u"Th\xe9 Organizer <organizer@example.com>",
</span><span class="cx"> "=?utf-8?q?Th=C3=A9_Organizer_=3Corganizer=40example=2Ecom=3E?=",
</span><span class="cx"> "attendee@example.com",
</span><ins>+ "=?utf-8?q?Event_update=3A_t=C3=A9sting_outbound=28_=29_*update*?=",
</ins><span class="cx"> ),
</span><span class="cx">
</span><span class="cx"> # Reply
</span><span class="lines">@@ -452,12 +454,13 @@
</span><span class="cx"> "attendee@example.com",
</span><span class="cx"> "attendee@example.com",
</span><span class="cx"> "organizer@example.com",
</span><ins>+ "=?utf-8?q?Event_reply=3A_t=C3=A9sting_outbound=28_=29_*reply*?=",
</ins><span class="cx"> ),
</span><span class="cx">
</span><span class="cx"> )
</span><span class="cx"> for (inputCalendar, UID, inputOriginator, inputRecipient, inviteState,
</span><span class="cx"> outputOrganizerEmail, outputOrganizerName, outputAttendeeList,
</span><del>- outputFrom, encodedFrom, outputRecipient) in data:
</del><ins>+ outputFrom, encodedFrom, outputRecipient, outputSubject) in data:
</ins><span class="cx">
</span><span class="cx"> txn = self.store.newTransaction()
</span><span class="cx"> yield self.sender.outbound(
</span><span class="lines">@@ -477,6 +480,7 @@
</span><span class="cx"> self.assertEquals(self.attendees, outputAttendeeList)
</span><span class="cx"> self.assertEquals(self.fromAddress, outputFrom)
</span><span class="cx"> self.assertEquals(self.toAddress, outputRecipient)
</span><ins>+ self.assertEquals(msg["Subject"], outputSubject)
</ins><span class="cx">
</span><span class="cx"> if UID: # The organizer is local, and server is sending to remote
</span><span class="cx"> # attendee
</span></span></pre>
</div>
</div>
</body>
</html>