[launchd-changes] [23518] trunk/launchd/src/launchd_core_logic.c

source_changes at macosforge.org source_changes at macosforge.org
Fri Feb 15 14:18:21 PST 2008


Revision: 23518
          http://trac.macosforge.org/projects/launchd/changeset/23518
Author:   zarzycki at apple.com
Date:     2008-02-15 14:18:20 -0800 (Fri, 15 Feb 2008)

Log Message:
-----------
Better logging.

Modified Paths:
--------------
    trunk/launchd/src/launchd_core_logic.c

Modified: trunk/launchd/src/launchd_core_logic.c
===================================================================
--- trunk/launchd/src/launchd_core_logic.c	2008-02-15 22:18:10 UTC (rev 23517)
+++ trunk/launchd/src/launchd_core_logic.c	2008-02-15 22:18:20 UTC (rev 23518)
@@ -1149,7 +1149,8 @@
 	}
 
 	if (jp && !jp->anonymous && unlikely(!(kp.kp_proc.p_flag & P_EXEC))) {
-		job_log(jp, LOG_APPLEONLY, "Performance and sanity: fork() without exec*(). Please switch to posix_spawn()");
+		job_log(jp, LOG_APPLEONLY, "Performance and sanity: fork() without exec*(). Please switch to posix_spawn(). Child PID %u",
+				kp.kp_proc.p_pid);
 	}
 
 
@@ -2450,8 +2451,8 @@
 			continue;
 		}
 
-		job_log(j, LOG_APPLEONLY, "Performance and sanity: fork() without exec*(). Please switch to posix_spawn()");
-		break;
+		job_log(j, LOG_APPLEONLY, "Performance and sanity: fork() without exec*(). Please switch to posix_spawn(). Child PID %u",
+				kp[i].kp_proc.p_pid);
 	}
 
 out:
@@ -6051,7 +6052,7 @@
 		job_log(j, LOG_DEBUG, "%sMach service lookup: %s", flags & BOOTSTRAP_PER_PID_SERVICE ? "Per PID " : "", servicename);
 
 		if (unlikely(j->lastlookup == ms && j->lastlookup_gennum == ms->gen_num && !j->per_user)) {
-			job_log(ms->job, LOG_APPLEONLY, "Performance: Please fix the framework to cache the Mach port for service: %s", servicename);
+			job_log(j, LOG_APPLEONLY, "Performance: Please fix the framework that talks to \"%s\" to cache the Mach port for service: %s", ms->job->label, servicename);
 		}
 
 		j->lastlookup = ms;

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.macosforge.org/pipermail/launchd-changes/attachments/20080215/7bc065ef/attachment-0001.html 


More information about the launchd-changes mailing list