[libdispatch-dev] Solaris portability, dispatch.h - PATCH [4/6]

[Robert Watson]

On Mon, 9 Nov 2009, Joakim Johansson wrote:

> I'd certainly be glad with that approach and would happily provide the 
> simple diffs for it if the maintainers are happy with it, it would 
> definitely look cleaner.
>
> Kevin/Robert?

I'm not sure I have any specific opinion on this, but if we're going to be 
defining __BEGIN_DECLS/__END_DECLS variations in dispatch.h, let's go whole 
hog (as it were) and use __DISPATCH_BEGIN_DECLS.

Robert

>
> Joakim
>
>
> On 7 nov 2009, at 16.55, Paolo Bonzini wrote:
>
>> On 11/06/2009 11:29 PM, Robert Watson wrote:
>>> 
>>> +
>>> +#ifndef __BEGIN_DECLS
>>> +#  if defined(__cplusplus)
>>> +#    define __BEGIN_DECLS    extern "C" {
>>> +#    define __END_DECLS        };
>>> +#  else /* __BEGIN_DECLS */
>>> +#    define __BEGIN_DECLS
>>> +#    define __END_DECLS
>>> +#  endif /* __BEGIN_DECLS */
>>> +#endif /* __BEGIN_DECLS */
>> 
>> Just remove cdefs.h completely and do 
>> s/__BEGIN_DECLS/__DISPATCH_BEGIN_DECLS/ (similarly for END)?
>> 
>> Paolo
>> _______________________________________________
>> libdispatch-dev mailing list
>> libdispatch-dev at lists.macosforge.org
>> http://lists.macosforge.org/mailman/listinfo.cgi/libdispatch-dev
>
> _______________________________________________
> libdispatch-dev mailing list
> libdispatch-dev at lists.macosforge.org
> http://lists.macosforge.org/mailman/listinfo.cgi/libdispatch-dev