[libdispatch-dev] [PATCH 2/4] complete separation

Robert Watson robert at fledge.watson.org
Sat Nov 14 08:56:42 PST 2009

On Tue, 10 Nov 2009, Paolo Bonzini wrote:

> ---
> src/kevent_internal.h |    6 +---
> src/source.c          |   52 ++-------------------------------
> src/source_internal.h |    9 ++++-
> src/source_kevent.c   |   77 ++++++++++++++++++++++++++++++++++++++++++++++--
> 4 files changed, 84 insertions(+), 60 deletions(-)

Committed as r153 with some minor refinements, such as adopting house style 
(real tabs, no space between function name and parens on invocation, ',' after 
last entry in a C99-initialized data structure).

I also removed the empty __linux__ struct kevent definition -- I'm pondering 
whether it's worth adding a check for struct kevent in configure.ac, but since 
we only support kqueue as an event source currently I'm not sure of the 
benefit is too concreate.  If we do want to build without kqueue for 
build-checking purposes, then doing it via configure is probably the right way 
so that it also works on Linux?


Robert N M Watson
Computer Laboratory
University of Cambridge

More information about the libdispatch-dev mailing list