[46780] trunk/base

[ryandesign at macports.org]

Revision: 46780
          http://trac.macports.org/changeset/46780
Author:   ryandesign at macports.org
Date:     2009-02-12 15:02:59 -0800 (Thu, 12 Feb 2009)
Log Message:
-----------
ChangeLog, portlint.tcl: port lint no longer complains about missing master_sites if there are no distfiles; closes #18479

Modified Paths:
--------------
    trunk/base/ChangeLog
    trunk/base/src/port1.0/portlint.tcl

Modified: trunk/base/ChangeLog
===================================================================
--- trunk/base/ChangeLog	2009-02-12 22:52:11 UTC (rev 46779)
+++ trunk/base/ChangeLog	2009-02-12 23:02:59 UTC (rev 46780)
@@ -5,6 +5,9 @@
 
 
 Release 1.8.0 (unreleased):
+    - port lint no longer requires variable master_sites if the port has no
+      distfiles (#18479, ryandesign)
+
     - Upgrade will no longer accept ports that are not installed (but it still
       installs new ports as dependencies if needed). In particular, this means
       that "port upgrade all" will no longer proceed to install every

Modified: trunk/base/src/port1.0/portlint.tcl
===================================================================
--- trunk/base/src/port1.0/portlint.tcl	2009-02-12 22:52:11 UTC (rev 46779)
+++ trunk/base/src/port1.0/portlint.tcl	2009-02-12 23:02:59 UTC (rev 46780)
@@ -300,7 +300,7 @@
     set portarch ${os.arch}
     global description long_description platforms categories all_variants
     global maintainers homepage master_sites checksums patchfiles
-    global depends_lib depends_build depends_run fetch.type
+    global depends_lib depends_build depends_run distfiles fetch.type
     
     global lint_portsystem lint_platforms lint_categories 
     global lint_required lint_optional lint_variants
@@ -332,9 +332,15 @@
             set var $req_var
         }
 
-        if {$var == "master_sites" && ${fetch.type} != "standard"} {
-            ui_info "OK: $var not required for fetch.type ${fetch.type}"
-            continue
+        if {$var == "master_sites"} {
+            if {${fetch.type} != "standard"} {
+                ui_info "OK: $var not required for fetch.type ${fetch.type}"
+                continue
+            }
+            if {[llength ${distfiles}] == 0} {
+                ui_info "OK: $var not required when there are no distfiles"
+                continue
+            }
         }
 
         if {![info exists $var]} {
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.macosforge.org/pipermail/macports-changes/attachments/20090212/573cd854/attachment.html>