[109303] trunk/base/src/port1.0/portlint.tcl
cal at macports.org
cal at macports.org
Mon Aug 12 11:50:37 PDT 2013
Revision: 109303
https://trac.macports.org/changeset/109303
Author: cal at macports.org
Date: 2013-08-12 11:50:37 -0700 (Mon, 12 Aug 2013)
Log Message:
-----------
portlint: recognize " version 1.2.3" as the version line and don't warn about a hardcoded version number
Modified Paths:
--------------
trunk/base/src/port1.0/portlint.tcl
Modified: trunk/base/src/port1.0/portlint.tcl
===================================================================
--- trunk/base/src/port1.0/portlint.tcl 2013-08-12 17:15:27 UTC (rev 109302)
+++ trunk/base/src/port1.0/portlint.tcl 2013-08-12 18:50:37 UTC (rev 109303)
@@ -270,8 +270,8 @@
}
if {!$hashline
- && ![regexp {^PortSystem|^PortGroup|^version} $line]
- && ![regexp {^[a-z0-9]+\.setup} $line]
+ && ![regexp {^\s*PortSystem|^\s*PortGroup|^\s*version} $line]
+ && ![regexp {^\s*[a-z0-9]+\.setup} $line]
&& [string first [option version] $line] != -1} {
ui_warn "Line $lineno seems to hardcode the version number, consider using \${version} instead"
incr warnings
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.macosforge.org/pipermail/macports-changes/attachments/20130812/7de07b2b/attachment.html>
More information about the macports-changes
mailing list