[135849] trunk/dports/devel/dbus/Portfile

[cal at macports.org]

Revision: 135849
          https://trac.macports.org/changeset/135849
Author:   cal at macports.org
Date:     2015-05-05 10:09:32 -0700 (Tue, 05 May 2015)
Log Message:
-----------
dbus: Add comment with a warning about why this piece of code is crucial

Modified Paths:
--------------
    trunk/dports/devel/dbus/Portfile

Modified: trunk/dports/devel/dbus/Portfile
===================================================================
--- trunk/dports/devel/dbus/Portfile	2015-05-05 17:08:06 UTC (rev 135848)
+++ trunk/dports/devel/dbus/Portfile	2015-05-05 17:09:32 UTC (rev 135849)
@@ -275,6 +275,12 @@
 
 variant no_root conflicts underscore description {Run the DBUS daemon as MacPorts install user.} {
     pre-fetch {
+        ###########
+        # WARNING #
+        ###########
+        # Do not error out later than in the fetch phase. In MacPorts 2.3.3,
+        # add_users root trashes the root user in the extract phase. See
+        # #45737.
         if {${install.user} eq "root" || ${install.group} eq "wheel"} {
             ui_error "The DBUS daemon should not be run as root."
             error "Please do not use this variant with your MacPorts configuration."
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.macosforge.org/pipermail/macports-changes/attachments/20150505/badf9a6e/attachment.html>