[144784] trunk/dports

mcalhoun at macports.org mcalhoun at macports.org
Mon Jan 18 06:57:31 PST 2016


Revision: 144784
          https://trac.macports.org/changeset/144784
Author:   mcalhoun at macports.org
Date:     2016-01-18 06:57:31 -0800 (Mon, 18 Jan 2016)
Log Message:
-----------
qt5 PortGroup: stop install process early if Qt dependency is unsupported on particular OS version (see #50331)

Modified Paths:
--------------
    trunk/dports/_resources/port1.0/group/qt5-1.0.tcl
    trunk/dports/aqua/qt5/Portfile

Modified: trunk/dports/_resources/port1.0/group/qt5-1.0.tcl
===================================================================
--- trunk/dports/_resources/port1.0/group/qt5-1.0.tcl	2016-01-18 14:47:26 UTC (rev 144783)
+++ trunk/dports/_resources/port1.0/group/qt5-1.0.tcl	2016-01-18 14:57:31 UTC (rev 144784)
@@ -177,6 +177,27 @@
 #     -DQT_ZLIB_LIBRARY=${prefix}/lib/libz.dylib \
 #     -DQT_PNG_LIBRARY=${prefix}/lib/libpng.dylib"
 
+# Qt has what is calls reference configurations, which are said to be thoroughly tested
+# Qt also has configurations which are occasionally tested
+# see http://doc.qt.io/qt-5/supported-platforms.html#reference-configurations
+global qt5_min_tested_version
+global qt5_max_tested_version
+global qt5_min_reference_version
+global qt5_max_reference_version
+set qt5_min_tested_version     11
+set qt5_max_tested_version     14
+set qt5_min_reference_version  12
+set qt5_max_reference_version  14
+
+# do not try to install if qt5-qtbase dependency will fail to build
+# warn about non-reference configurations
+if { ${os.major} < ${qt5_min_tested_version} } {
+    pre-fetch {
+        ui_error "Qt dependency will not build on this platform"
+        return -code error "unsupported OS"
+    }
+}
+
 if {![info exists building_qt5]} {
     depends_lib-append port:qt5-qtbase
 }

Modified: trunk/dports/aqua/qt5/Portfile
===================================================================
--- trunk/dports/aqua/qt5/Portfile	2016-01-18 14:47:26 UTC (rev 144783)
+++ trunk/dports/aqua/qt5/Portfile	2016-01-18 14:57:31 UTC (rev 144784)
@@ -51,20 +51,20 @@
     pre-fetch {
         ui_warn "${subport} is untested on \"${os.platform}\"."
     }
-} elseif { ${os.major} < 11 } {
+} elseif { ${os.major} < ${qt5_min_tested_version} } {
     pre-fetch {
         ui_error "OS X prior to 10.8 (Mountain Lion) is not a Reference Configuration for Qt."
         ui_error "OS X prior to 10.7 (Lion) is not even tested."
         ui_error "See http://doc.qt.io/qt-5/supported-platforms.html#reference-configurations"
         return -code error "unsupported OS"
     }
-} elseif { ${os.major} > 14 } {
+} elseif { ${os.major} > ${qt5_max_reference_version} } {
     pre-fetch {
         ui_warn "OS X subsequent to 10.10 (Yosemite) is not a Reference Configuration for Qt."
         ui_warn "See http://doc.qt.io/qt-5/supported-platforms.html#reference-configurations"
     }
 } else {
-    # 11 <= ${os.major} <= 14
+    # ${qt5_min_tested_version} <= ${os.major} <= ${qt5_max_reference_version}
     if { [variant_isset universal] } {
         pre-fetch {
             ui_warn "Multiple architectures is not a Reference Configuration for Qt."
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.macosforge.org/pipermail/macports-changes/attachments/20160118/fbd59d38/attachment.html>


More information about the macports-changes mailing list