[154418] contrib/buildbot-test/master.cfg

larryv at macports.org larryv at macports.org
Sat Oct 29 03:05:45 CEST 2016


Revision: 154418
          https://trac.macports.org/changeset/154418
Author:   larryv at macports.org
Date:     2016-10-29 03:05:45 +0200 (Sat, 29 Oct 2016)
Log Message:
-----------
buildbot: Improve PortsMailNotifier.useLookup

Prefer list comprehension over looping.

Modified Paths:
--------------
    contrib/buildbot-test/master.cfg

Modified: contrib/buildbot-test/master.cfg
===================================================================
--- contrib/buildbot-test/master.cfg	2016-10-29 01:02:33 UTC (rev 154417)
+++ contrib/buildbot-test/master.cfg	2016-10-29 01:05:45 UTC (rev 154418)
@@ -660,13 +660,10 @@
         return msgdict
 
     def useLookup(self, build):
-        dl = []
+        # Initialize with additional recipients.
+        dl = [defer.maybeDeferred(self.lookup.getAddress, user)
+              for user in self.interested_users]
 
-        # add additional recipients
-        for u in self.interested_users:
-            d = defer.maybeDeferred(self.lookup.getAddress, u)
-            dl.append(d)
-
         # original list of recipients
 #        for u in build.getResponsibleUsers() + build.getInterestedUsers():
 #            d = defer.maybeDeferred(self.lookup.getAddress, u)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.macports.org/pipermail/macports-changes/attachments/20161029/3dc89b23/attachment-0002.html>


More information about the macports-changes mailing list