<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[124891] trunk/dports/security/certsync/files</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="https://trac.macports.org/changeset/124891">124891</a></dd>
<dt>Author</dt> <dd>cal@macports.org</dd>
<dt>Date</dt> <dd>2014-08-30 03:49:53 -0700 (Sat, 30 Aug 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>certsync: Fix warnings and potential crash on Tiger
https://lists.macosforge.org/pipermail/macports-dev/2014-August/027807.html</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkdportssecuritycertsyncfilescertsyncm">trunk/dports/security/certsync/files/certsync.m</a></li>
<li><a href="#trunkdportssecuritycertsyncfilescompath">trunk/dports/security/certsync/files/compat.h</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkdportssecuritycertsyncfilescertsyncm"></a>
<div class="modfile"><h4>Modified: trunk/dports/security/certsync/files/certsync.m (124890 => 124891)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/dports/security/certsync/files/certsync.m 2014-08-30 10:36:35 UTC (rev 124890)
+++ trunk/dports/security/certsync/files/certsync.m 2014-08-30 10:49:53 UTC (rev 124891)
</span><span class="lines">@@ -403,8 +403,14 @@
</span><span class="cx"> /* Set the keychain preference domain to user, this causes
</span><span class="cx"> * ValidateSystemTrust to use the user's keychain */
</span><span class="cx"> if ((err = SecKeychainSetPreferenceDomain(kSecPreferencesDomainUser)) != errSecSuccess) {
</span><del>- CFStringRef errMsg = PLCFAutorelease(SecCopyErrorMessageString(err, NULL));
- nsfprintf(stderr, @"Failed to set keychain preference domain: %@\n", errMsg);
</del><ins>+ if (SecCopyErrorMessageString != NULL) {
+ /* >= 10.5 */
+ CFStringRef errMsg = PLCFAutorelease(SecCopyErrorMessageString(err, NULL));
+ nsfprintf(stderr, @"Failed to set keychain preference domain: %@\n", errMsg);
+ } else {
+ /* <= 10.4 */
+ nsfprintf(stderr, @"Failed to set keychain preference domain: %d\n", err);
+ }
</ins><span class="cx">
</span><span class="cx"> [pool release];
</span><span class="cx"> return EXIT_FAILURE;
</span><span class="lines">@@ -423,8 +429,14 @@
</span><span class="cx"> /* Admin & System */
</span><span class="cx"> /* Causes ValidateSystemTrust to ignore the user's keychain */
</span><span class="cx"> if ((err = SecKeychainSetPreferenceDomain(kSecPreferencesDomainSystem)) != errSecSuccess) {
</span><del>- CFStringRef errMsg = PLCFAutorelease(SecCopyErrorMessageString(err, NULL));
- nsfprintf(stderr, @"Failed to set keychain preference domain: %@\n", errMsg);
</del><ins>+ if (SecCopyErrorMessageString != NULL) {
+ /* >= 10.5 */
+ CFStringRef errMsg = PLCFAutorelease(SecCopyErrorMessageString(err, NULL));
+ nsfprintf(stderr, @"Failed to set keychain preference domain: %@\n", errMsg);
+ } else {
+ /* <= 10.4 */
+ nsfprintf(stderr, @"Failed to set keychain preference domain: %d\n", err);
+ }
</ins><span class="cx">
</span><span class="cx"> [pool release];
</span><span class="cx"> return EXIT_FAILURE;
</span></span></pre></div>
<a id="trunkdportssecuritycertsyncfilescompath"></a>
<div class="modfile"><h4>Modified: trunk/dports/security/certsync/files/compat.h (124890 => 124891)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/dports/security/certsync/files/compat.h 2014-08-30 10:36:35 UTC (rev 124890)
+++ trunk/dports/security/certsync/files/compat.h 2014-08-30 10:49:53 UTC (rev 124891)
</span><span class="lines">@@ -54,6 +54,13 @@
</span><span class="cx"> /* SecTrustSettingsCopyCertificates() was added in 10.5 */
</span><span class="cx"> extern OSStatus SecTrustSettingsCopyCertificates (SecTrustSettingsDomain domain, CFArrayRef *certArray) __attribute__((weak_import));
</span><span class="cx"> #define SecTrustSettingsCopyCertificates ((OSStatus(*)(SecTrustSettingsDomain, CFArrayRef *)) NULL) /* We can't safely weak-link what we don't have */
</span><ins>+
+ /* SecTrustSettingsCopyTrustSettings() was added in 10.5 */
+ extern OSStatus SecTrustSettingsCopyTrustSettings (SecCertificateRef certRef, SecTrustSettingsDomain domain, CFArrayRef *trustSettings) __attribute__((weak_import));
+ #define SecTrustSettingsCopyTrustSettings ((OSStatus(*)(SecCertificateRef, SecTrustSettingsDomain, CFArrayRef *)) NULL) /* We can't safely weak-link what we don't have */
+
+ extern CFStringRef SecCopyErrorMessageString (OSStatus status, void *reserved) __attribute__((weak_import));
+ #define SecCopyErrorMessageString ((CFStringRef(*)(OSStatus, void *)) NULL) /* We can't safely weak-link what we don't have */
</ins><span class="cx">
</span><span class="cx"> /* CFError was added in 10.5 */
</span><span class="cx"> typedef CFTypeRef CFErrorRef;
</span></span></pre>
</div>
</div>
</body>
</html>