<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[128704] trunk/dports/devel/isl</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="https://trac.macports.org/changeset/128704">128704</a></dd>
<dt>Author</dt> <dd>larryv@macports.org</dd>
<dt>Date</dt> <dd>2014-11-25 17:37:41 -0800 (Tue, 25 Nov 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>isl: Include space.h in deprecated headers
The headers for the isl_int API use the isl_dim_type enumeration without
including space.h. This causes compilation to fail if including source
files don't include space.h themselves.
Upstream doesn't want to fix deprecated code
(https://groups.google.com/d/msg/isl-development/N6UWJDbKXNA/2CY6WHDvOYoJ),
so this patch should be applied until they remove the headers outright.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkdportsdevelislPortfile">trunk/dports/devel/isl/Portfile</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkdportsdevelislfilesfixdeprecatedheaderspatch">trunk/dports/devel/isl/files/fix-deprecated-headers.patch</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkdportsdevelislPortfile"></a>
<div class="modfile"><h4>Modified: trunk/dports/devel/isl/Portfile (128703 => 128704)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/dports/devel/isl/Portfile 2014-11-26 01:37:32 UTC (rev 128703)
+++ trunk/dports/devel/isl/Portfile 2014-11-26 01:37:41 UTC (rev 128704)
</span><span class="lines">@@ -8,7 +8,7 @@
</span><span class="cx"> conflicts isl-devel
</span><span class="cx">
</span><span class="cx"> version 0.14
</span><del>-revision 1
</del><ins>+revision 2
</ins><span class="cx"> epoch 2
</span><span class="cx">
</span><span class="cx"> categories devel math
</span><span class="lines">@@ -34,8 +34,14 @@
</span><span class="cx">
</span><span class="cx"> depends_lib port:gmp
</span><span class="cx">
</span><ins>+# Add a missing include to the isl_int headers. Upstream doesn't want to
+# bother fixing deprecated APIs
+# (https://groups.google.com/d/msg/isl-development/N6UWJDbKXNA/2CY6WHDvOYoJ),
+# so this should be applied until they remove the headers outright.
+patchfiles fix-deprecated-headers.patch
+
</ins><span class="cx"> # Don't link using "-flat_namespace -undefined suppress" on Yosemite and later.
</span><del>-patchfiles yosemite-libtool.patch
</del><ins>+patchfiles-append yosemite-libtool.patch
</ins><span class="cx">
</span><span class="cx"> configure.args --disable-silent-rules
</span><span class="cx">
</span></span></pre></div>
<a id="trunkdportsdevelislfilesfixdeprecatedheaderspatch"></a>
<div class="addfile"><h4>Added: trunk/dports/devel/isl/files/fix-deprecated-headers.patch (0 => 128704)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/dports/devel/isl/files/fix-deprecated-headers.patch (rev 0)
+++ trunk/dports/devel/isl/files/fix-deprecated-headers.patch 2014-11-26 01:37:41 UTC (rev 128704)
</span><span class="lines">@@ -0,0 +1,84 @@
</span><ins>+commit dbf64e83af8d4b5a55fed546e0c615cd51141bd7
+Author: Lawrence Velázquez <larryv@macports.org>
+Date: Tue Nov 25 01:50:58 2014 -0500
+
+ Include space.h in deprecated headers using isl_dim_type
+
+ These headers should not assume that space.h will be included
+ transitively through another header or by an including source file, as
+ compilation can fail if those assumptions don't hold.
+
+ Signed-off-by: Lawrence Velázquez <larryv@macports.org>
+
+Index: include/isl/deprecated/aff_int.h
+===================================================================
+--- include/isl/deprecated/aff_int.h.orig
++++ include/isl/deprecated/aff_int.h
+@@ -3,6 +3,7 @@
+
+ #include <isl/deprecated/int.h>
+ #include <isl/aff_type.h>
++#include <isl/space.h>
+
+ #if defined(__cplusplus)
+ extern "C" {
+Index: include/isl/deprecated/constraint_int.h
+===================================================================
+--- include/isl/deprecated/constraint_int.h.orig
++++ include/isl/deprecated/constraint_int.h
+@@ -3,6 +3,7 @@
+
+ #include <isl/deprecated/int.h>
+ #include <isl/constraint.h>
++#include <isl/space.h>
+
+ #if defined(__cplusplus)
+ extern "C" {
+Index: include/isl/deprecated/map_int.h
+===================================================================
+--- include/isl/deprecated/map_int.h.orig
++++ include/isl/deprecated/map_int.h
+@@ -3,6 +3,7 @@
+
+ #include <isl/deprecated/int.h>
+ #include <isl/map_type.h>
++#include <isl/space.h>
+
+ #if defined(__cplusplus)
+ extern "C" {
+Index: include/isl/deprecated/point_int.h
+===================================================================
+--- include/isl/deprecated/point_int.h.orig
++++ include/isl/deprecated/point_int.h
+@@ -3,6 +3,7 @@
+
+ #include <isl/deprecated/int.h>
+ #include <isl/point.h>
++#include <isl/space.h>
+
+ #if defined(__cplusplus)
+ extern "C" {
+Index: include/isl/deprecated/polynomial_int.h
+===================================================================
+--- include/isl/deprecated/polynomial_int.h.orig
++++ include/isl/deprecated/polynomial_int.h
+@@ -3,6 +3,7 @@
+
+ #include <isl/deprecated/int.h>
+ #include <isl/polynomial.h>
++#include <isl/space.h>
+
+ #if defined(__cplusplus)
+ extern "C" {
+Index: include/isl/deprecated/set_int.h
+===================================================================
+--- include/isl/deprecated/set_int.h.orig
++++ include/isl/deprecated/set_int.h
+@@ -3,6 +3,7 @@
+
+ #include <isl/deprecated/int.h>
+ #include <isl/set_type.h>
++#include <isl/space.h>
+
+ #if defined(__cplusplus)
+ extern "C" {
</ins></span></pre>
</div>
</div>
</body>
</html>