<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[143305] trunk/dports/math/itsol/Portfile</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="https://trac.macports.org/changeset/143305">143305</a></dd>
<dt>Author</dt> <dd>dstrubbe@macports.org</dd>
<dt>Date</dt> <dd>2015-12-09 19:21:32 -0800 (Wed, 09 Dec 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>itsol: Use vecLibFort for Accelerate, which should resolve the concerns about its bugginess. I don't see any problem for g95, since atlas does not need to be installed with the same Fortran compiler as used here; all tests passed regardless. Use more condensed link line for atlas.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkdportsmathitsolPortfile">trunk/dports/math/itsol/Portfile</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkdportsmathitsolPortfile"></a>
<div class="modfile"><h4>Modified: trunk/dports/math/itsol/Portfile (143304 => 143305)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/dports/math/itsol/Portfile 2015-12-10 03:15:59 UTC (rev 143304)
+++ trunk/dports/math/itsol/Portfile 2015-12-10 03:21:32 UTC (rev 143305)
</span><span class="lines">@@ -42,34 +42,15 @@
</span><span class="cx"> compilers.choose fc
</span><span class="cx"> compilers.setup require_fortran
</span><span class="cx">
</span><del>-# atlas does not provide a +g95 variant, so if +g95 is used,
-# +accelerate must also be used. +accelerate will work with +gccXY,
-# so this is all a bit complex to check for. Setting 'requires' here
-# does not yet seem to work with 'port' to get [+]accelerate; leaving
-# it out does work, so doing that and checking for this condition
-# later, for now.
-
-######################
-# set up BLAS variants
-
-# atlas does not work with g95, so always conflict with it
-
</del><span class="cx"> variant atlas description {use BLAS from MacPorts' atlas port} \
</span><del>- conflicts g95 accelerate {}
</del><ins>+ conflicts accelerate {}
</ins><span class="cx">
</span><del>-# accelerate works with any fortran variant
-
</del><span class="cx"> variant accelerate description \
</span><del>- {use BLAS from Apple's Accelerate.framework [might be buggy]} \
</del><ins>+ {use BLAS from Apple's Accelerate.framework} \
</ins><span class="cx"> conflicts atlas {}
</span><span class="cx">
</span><del>-##################
-# variant checking
-
-# check for BLAS default variant, use +atlas if nothing else
-
</del><span class="cx"> set blas_variant_selection ""
</span><del>-if {[variant_isset g95] || [variant_isset accelerate]} {
</del><ins>+if {[variant_isset accelerate]} {
</ins><span class="cx"> set blas_variant_selection "accelerate"
</span><span class="cx"> } else {
</span><span class="cx"> set blas_variant_selection "atlas"
</span><span class="lines">@@ -89,12 +70,13 @@
</span><span class="cx">
</span><span class="cx"> if {[variant_isset accelerate]} {
</span><span class="cx">
</span><del>- configure.ldflags-append -Wl,-framework -Wl,Accelerate
</del><ins>+ depends_lib-append vecLibFort
+ configure.ldflags-append -lvecLibFort
</ins><span class="cx">
</span><span class="cx"> } else {
</span><span class="cx">
</span><span class="cx"> depends_lib-append port:atlas
</span><del>- configure.ldflags-append -llapack -lcblas -lf77blas -latlas
</del><ins>+ configure.ldflags-append -lsatlas
</ins><span class="cx">
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -108,18 +90,6 @@
</span><span class="cx"> configure.universal_args
</span><span class="cx"> destroot.env-append PREFIX=${prefix}
</span><span class="cx">
</span><del>-pre-fetch {
-
- # check for +accelerate. Apple's VecLib has bugs that can cause
- # crashes, while Atlas does not have these issues. Print a
- # warning if this variant is in use, but do not force the use of
- # +atlas (for now).
-
- if {[variant_isset accelerate]} {
- ui_msg "\nWARNING: The +accelerate variant has been selected, using Apple's Vector Libraries which have known bugs that can cause crashes. The +atlas variant does not have these issues, and is generally considered a better way to go.\n"
- }
-}
-
</del><span class="cx"> test.run yes
</span><span class="cx"> pre-test {
</span><span class="cx"> test.args-append LINKS="-L../LIB -litsol" \
</span></span></pre>
</div>
</div>
</body>
</html>