<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[142957] trunk/dports/devel/gmp</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="https://trac.macports.org/changeset/142957">142957</a></dd>
<dt>Author</dt> <dd>jeremyhu@macports.org</dd>
<dt>Date</dt> <dd>2015-11-28 21:47:28 -0800 (Sat, 28 Nov 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>gmp: Link with -no-undefined
I encountered an odd error on a Leopard VM where some libgmp symbols were
missing in the library. Had the library been built with -no-undefined, the
issue would have been caught at link time. Oddly, rebuilding (with
-no-undefined) resulted in the symbols being present. I highly doubt that
the flag is the fix for the problem. It's likely that toolchain changes
in the interim fixed the issue for me, but I'm adding the flag to protect
users from potentially hitting fallout from the same issue in the future.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkdportsdevelgmpPortfile">trunk/dports/devel/gmp/Portfile</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunkdportsdevelgmpfilespatchMakefileindiff">trunk/dports/devel/gmp/files/patch-Makefile.in.diff</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkdportsdevelgmpPortfile"></a>
<div class="modfile"><h4>Modified: trunk/dports/devel/gmp/Portfile (142956 => 142957)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/dports/devel/gmp/Portfile 2015-11-29 05:14:38 UTC (rev 142956)
+++ trunk/dports/devel/gmp/Portfile 2015-11-29 05:47:28 UTC (rev 142957)
</span><span class="lines">@@ -6,6 +6,7 @@
</span><span class="cx">
</span><span class="cx"> name gmp
</span><span class="cx"> version 6.1.0
</span><ins>+revision 1
</ins><span class="cx"> categories devel math
</span><span class="cx"> license LGPL-3+
</span><span class="cx"> maintainers mcalhoun openmaintainer
</span><span class="lines">@@ -31,6 +32,9 @@
</span><span class="cx"> use_bzip2 yes
</span><span class="cx"> use_parallel_build yes
</span><span class="cx">
</span><ins>+patchfiles \
+ patch-Makefile.in.diff
+
</ins><span class="cx"> configure.args --enable-cxx
</span><span class="cx">
</span><span class="cx"> # Prevent precompiled binaries.
</span></span></pre></div>
<a id="trunkdportsdevelgmpfilespatchMakefileindiff"></a>
<div class="addfile"><h4>Added: trunk/dports/devel/gmp/files/patch-Makefile.in.diff (0 => 142957)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/dports/devel/gmp/files/patch-Makefile.in.diff (rev 0)
+++ trunk/dports/devel/gmp/files/patch-Makefile.in.diff 2015-11-29 05:47:28 UTC (rev 142957)
</span><span class="lines">@@ -0,0 +1,20 @@
</span><ins>+--- Makefile.in.orig 2015-11-01 10:19:56.000000000 -0500
++++ Makefile.in 2015-11-29 00:34:56.000000000 -0500
+@@ -756,7 +756,7 @@ libgmp_la_DEPENDENCIES = @TAL_OBJECT@ \
+
+ libgmp_la_LIBADD = $(libgmp_la_DEPENDENCIES)
+ libgmp_la_LDFLAGS = $(GMP_LDFLAGS) $(LIBGMP_LDFLAGS) \
+- -version-info $(LIBGMP_LT_CURRENT):$(LIBGMP_LT_REVISION):$(LIBGMP_LT_AGE)
++ -version-info $(LIBGMP_LT_CURRENT):$(LIBGMP_LT_REVISION):$(LIBGMP_LT_AGE) -no-undefined
+
+
+ # We need at least one .cc file in $(libgmpxx_la_SOURCES) so automake will
+@@ -767,7 +767,7 @@ libgmpxx_la_SOURCES = cxx/dummy.cc
+ libgmpxx_la_DEPENDENCIES = $(CXX_OBJECTS) libgmp.la
+ libgmpxx_la_LIBADD = $(libgmpxx_la_DEPENDENCIES)
+ libgmpxx_la_LDFLAGS = $(GMP_LDFLAGS) $(LIBGMPXX_LDFLAGS) \
+- -version-info $(LIBGMPXX_LT_CURRENT):$(LIBGMPXX_LT_REVISION):$(LIBGMPXX_LT_AGE)
++ -version-info $(LIBGMPXX_LT_CURRENT):$(LIBGMPXX_LT_REVISION):$(LIBGMPXX_LT_AGE) -no-undefined
+
+ all: $(BUILT_SOURCES) config.h
+ $(MAKE) $(AM_MAKEFLAGS) all-recursive
</ins></span></pre>
</div>
</div>
</body>
</html>