<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[149254] trunk/dports/science/apbs/Portfile</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="https://trac.macports.org/changeset/149254">149254</a></dd>
<dt>Author</dt> <dd>dstrubbe@macports.org</dd>
<dt>Date</dt> <dd>2016-06-07 12:12:06 -0700 (Tue, 07 Jun 2016)</dd>
</dl>
<h3>Log Message</h3>
<pre>apbs, apbs-mpi: Fixes to enable BEM as variant. Blacklisting compilers, only choose the Fortran one. Fix MPI maloc linking error. Some comments. Fixes #48544 and #49058 (openmaintainer/maintainer timeout #49058).</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkdportsscienceapbsPortfile">trunk/dports/science/apbs/Portfile</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkdportsscienceapbsPortfile"></a>
<div class="modfile"><h4>Modified: trunk/dports/science/apbs/Portfile (149253 => 149254)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/dports/science/apbs/Portfile 2016-06-07 19:03:28 UTC (rev 149253)
+++ trunk/dports/science/apbs/Portfile 2016-06-07 19:12:06 UTC (rev 149254)
</span><span class="lines">@@ -6,8 +6,6 @@
</span><span class="cx"> PortGroup mpi 1.0
</span><span class="cx"> PortGroup github 1.0
</span><span class="cx">
</span><del>-compilers.choose cc cxx
-
</del><span class="cx"> name apbs
</span><span class="cx"> subport apbs-mpi {}
</span><span class="cx"> # set revision separately for each subport, below.
</span><span class="lines">@@ -35,13 +33,12 @@
</span><span class="cx"> depends_lib port:maloc \
</span><span class="cx"> port:readline
</span><span class="cx">
</span><del>-# dependencies are not managed correctly within this code, so errors such as from Eigen or -lapbs_geoflow might occur
</del><ins>+# dependencies are not managed correctly within this code, so errors such as from -lapbs_geoflow might occur
+# how to solve: first 'make apbs_geoflow', then 'make all'
</ins><span class="cx"> use_parallel_build no
</span><span class="cx">
</span><del>-# BEM needs 'gfortran', hard-coded, and configure fails without it if BEM is enabled, with a syntax error
-#CMake Error at CMakeLists.txt:217 (get_filename_component):
-# get_filename_component called with incorrect number of arguments
-# To enable, need not only to fix that check, but also fix configure in tapipb directory to use chosen FC compiler.
</del><ins>+# do +debug and +universal work?
+# do we really want -g?
</ins><span class="cx"> configure.args-append -DENABLE_OPENMP:BOOL=OFF \
</span><span class="cx"> -DENABLE_BEM=OFF \
</span><span class="cx"> -DCMAKE_C_COMPILER_ARG1:STRING="-I${worksrcpath}/include -O3 -ffast-math -g" \
</span><span class="lines">@@ -60,6 +57,13 @@
</span><span class="cx"> mergedx mergedx2 mgmesh multivalue similarity smooth tensor2dx
</span><span class="cx"> uhbd_asc2bin value}
</span><span class="cx">
</span><ins>+# Some cmake tests will fail with "error: unrecognized option '-arch'" from gcc 4.6 and earlier. Same with dragonegg based on it.
+# llvm-gcc-4.2 will fail to build with: error: unrecognized command line option "-std=c++0x"
+compiler.blacklist macports-gcc-4.4 macports-gcc-4.5 macports-gcc-4.6 \
+ macports-dragonegg-3.3 macports-dragonegg-3.4 llvm-gcc-4.2
+# g++ will just fail to link apbs_geoflow. probably about -lstdc++ stuff. So, just use Fortran.
+compilers.choose fc
+
</ins><span class="cx"> switch ${subport} {
</span><span class="cx"> apbs {
</span><span class="cx"> compilers.setup
</span><span class="lines">@@ -99,6 +103,8 @@
</span><span class="cx"> -DCMAKE_CXX_COMPILER=${configure.cxx} \
</span><span class="cx"> -DMPI_C_COMPILER=${mpi.cc} \
</span><span class="cx"> -DMPI_CXX_COMPILER=${mpi.cxx}
</span><ins>+ # sometimes there will be a failure to link without this
+ reinplace -W ${worksrcpath} "s/-lmaloc/-lmaloc -lreadline/" CMakeLists.txt
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> destroot {
</span><span class="lines">@@ -117,6 +123,29 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+variant bem description {Build with support for Boundary Element Method} {
+ configure.args-delete -DENABLE_BEM=OFF
+ configure.args-append -DENABLE_BEM=ON
+
+ if {![fortran_variant_isset]} {
+ ui_error "+bem requires a Fortran variant, e.g. +gfortran, +gccX, or +g95."
+ return -code error "+bem requires a Fortran variant."
+ }
+
+ # BEM looks for 'gfortran', hard-coded, and configure fails without it if BEM is enabled, with a syntax error
+ #CMake Error at CMakeLists.txt:217 (get_filename_component):
+ # get_filename_component called with incorrect number of arguments
+ post-patch {
+ reinplace "s|get_filename_component(LIBGFORTRANPATH|#get_filename_component(LIBGFORTRANPATH|g" ${worksrcpath}/CMakeLists.txt
+ reinplace "s|find_path(LIBGFORTRAN_PATH|#find_path(LIBGFORTRAN_PATH|g" ${worksrcpath}/CMakeLists.txt
+ # -lstdc++ does not seem necessary and may cause trouble; specifying full paths avoid possible use of -ltabip from an earlier installation in ${prefix}
+ reinplace "s|-L\${LIBGFORTRAN_PATH} -lgfortran -ltabipb -lstdc\+\+|${compilers.libfortran} ${worksrcpath}/lib/libtabipb.a|" ${worksrcpath}/CMakeLists.txt
+ # provide this information to subsidiary cmake command run in tabipb directory during build phase
+ reinplace "s|CMAKE_ARGS|CMAKE_ARGS -DCMAKE_Fortran_COMPILER:STRING=${configure.fc}|" ${worksrcpath}/CMakeLists.txt
+ system -W ${worksrcpath} "echo 'include_directories(\${APBS_ROOT}/include)' >> CMakeLists.txt"
+ }
+}
+
</ins><span class="cx"> # check for real releases, not github commits
</span><span class="cx"> livecheck.type regex
</span><span class="cx"> livecheck.url http://www.poissonboltzmann.org/news/
</span></span></pre>
</div>
</div>
</body>
</html>