[31795] trunk/dports/security

[Ryan Schmidt]

Some comments...

On Dec 7, 2007, at 13:12, ricci at macports.org wrote:

> Added: trunk/dports/security/afflib/Portfile
> ===================================================================
> --- trunk/dports/security/afflib/Portfile	                         
> (rev 0)
> +++ trunk/dports/security/afflib/Portfile	2007-12-07 19:12:12 UTC  
> (rev 31795)
> @@ -0,0 +1,55 @@
> +# $Id$
> +
> +PortSystem 1.0

There should be a newline after this line; see "port lint" (in  
MacPorts 1.6.0 and later).

> +name		afflib
> +version		3.0.4
> +revision	0

0 is the default revision; you don't need to specify it.

> +categories	net

The port is in the "security" directory but says its category is  
"net"? That doesn't match.

> +maintainers	opendarwin.org at darkart.com
> +description	The Advanced Forensic Format
> +homepage	http://afflib.org/

Probably "homepage http://www.aflib.org/" would have been better  
since "http://afflib.org/" redirects to that.

> +platforms	darwin
> +
> +long_description AFF(R) is an open and extensible file format  
> designed \
> +			to store disk images and associated metadata.
> +
> +master_sites	http://www.afflib.org/downloads/

Then you could just say "master_sites ${homepage}downloads/" here.

> +checksums	md5	60730870a313056ae85aa489141714e7		\
> +		sha1	6b17e3297fb6825e3748a8f4aef6065b77a69291
> +##		rmd160	dd5a0bb35bf27c2c16794580a6e9861fffe78ccc

Why is the rmd160 checksum commented out?

> +use_bzip2	no

The default is not to use bzip2; you don't need to specify it.

> +## depends_lib	port:libewf	\

Why is this dependency commented out?

> +depends_lib	\
> +		port:openssl	\
> +		port:readline	\
> +		port:zlib
> +
> +configure.args	--enable-fuse=no	\
> +		--enable-s3=no		\
> +		--with-ssl=${prefix}	\
> +		--with-zlib=${prefix}

There's extra whitespace after this line, which "port lint" also  
mentions.

> +variant s3 description { Enable the use of Amazon's S3 service } {
> +	configure.args-append	--enable-s3=yes	\
> +				--with-curl=${prefix}/lib
> +	configure.args-delete	--enable-s3=no
> +	depends_lib-append	port:curl	\
> +				port:expat
> +}
> +
> +
> +## untested....
> +## variant fuse description { Access AFF data through FUSE } {
> +## 	configure.args-append	--enable-fuse=yes
> +## 	configure.args-delete	--enable-fuse=no
> +## 	

Extra white space after this line.

> +## }
> +##
> +
> +#
> +##EOF

We all know where the end of the file is; you don't need a comment  
for that. :)


> Added: trunk/dports/security/libewf/Portfile
> ===================================================================
> --- trunk/dports/security/libewf/Portfile	                         
> (rev 0)
> +++ trunk/dports/security/libewf/Portfile	2007-12-07 19:12:12 UTC  
> (rev 31795)
> @@ -0,0 +1,30 @@
> +# $Id$
> +
> +PortSystem 1.0

Missing newline here...

> +name		libewf
> +version		20070512
> +revision	0

Is the default...

> +categories	net

Category mismatch...

> +maintainers	opendarwin.org at darkart.com
> +description	Libewf is a library for support of the Expert Witness  
> Compression Format
> +homepage	https://www.uitwisselplatform.nl/projects/libewf/
> +platforms	darwin
> +
> +long_description Libewf is a library for support of the Expert  
> Witness \
> +		Compression Format (EWF), it support both the SMART \
> +		format (EWF-S01) and the EnCase format (EWF-E01).  \
> +		Libewf allows you to read and write media information within the  
> EWF files.
> +
> +master_sites	http://www.uitwisselplatform.nl/frs/download.php/303/
> +
> +checksums	md5	5c09ed6478eadd020d6de0ea61569a8e	\
> +		sha1	0fba1160cc42ca6f280fcca7ba2de84b49c86bdc
> +
>
> +use_bzip2	no

Is the default...

> +## master_site uses a self-signed cert and appears to force the  
> use of SSL.
> +## libcurl chokes on this, so disable cert. validation
> +fetch.ignore_sslcert	yes
> +
> +#
> +##EOF


Is unnecessary. :)