[30474] trunk/dports/python/py-reportlab/Portfile

[Ryan Schmidt]

On Oct 28, 2007, at 17:43, source_changes at macosforge.org wrote:

[snip]

> -distfiles		ReportLab_1_20.tgz
> -checksums		md5 8d374b9b6f7db3fc0821082347d5e6b5
> +distfiles		ReportLab_2_1.tgz
> +checksums		sha1 67c6fba57b6372987dd3280be257a1f6bb7fff80
> +depends_lib-append	port:py-numeric
>
> -worksrcdir		reportlab_1_20/reportlab
> +worksrcdir		reportlab_2_1/reportlab

[snip]

Instead of hardcoding the version in py-reportlab and py25-reportlab,  
you may want

distfiles ReportLab_[strsed ${version} {g/[.]/_/}].tgz

and

worksrcdir reportlab_[strsed ${version} {g/[.]/_/}]/reportlab


Also, when you created the py25-reportlab portfile based on the py- 
reportlab portfile, it would have been better to "svn cp py-reportlab  
py25-reportlab" in the python directory, rather than copy it outside  
of Subversion and then add it. Had you done that, "svn log `port file  
py25-reportlab`" would now be more useful (would reflect the port's  
history back thru the creation of the original py-reportlab portfile  
in 2003) instead of appearing to have been called into existence just  
now with no history.