[48123] trunk/base/src/macports1.0/macports.tcl

[Rainer Müller]

On 2009-03-17 02:07, Ryan Schmidt wrote:
> On Mar 14, 2009, at 23:28, raimue at macports.org wrote:
>> --- trunk/base/src/macports1.0/macports.tcl	2009-03-15 03:49:27 UTC  
>> (rev 48122)
>> +++ trunk/base/src/macports1.0/macports.tcl	2009-03-15 04:28:51 UTC  
>> (rev 48123)
>> @@ -2086,6 +2086,7 @@
>>
>>      # syncing ports tree.
>>      if {![info exists options(ports_selfupdate_nosync)] || $options 
>> (ports_selfupdate_nosync) != "yes"} {
>> +        ui_msg "--> Updating the ports tree"
> 
> [snip other similar lines]
> 
> Shouldn't we be using $UI_PREFIX in these places instead of "-->"?

Yes, I know that. I already spoke with Joshua when he used "-->" in the
dependency calculation.

There is simply no UI_PREFIX in the macports1.0 package, it is used in
port1.0 only. It is also hardcoded in registry1.0. Although port1.0
tries to overwrite UI_PREFIX from the environment, this is blocked by
the env cleanup in macports1.0.

I don't think anybody could be actually overwriting this at the moment
and it was broken before, so it's not a real regression caused by this
commit ;-)

For fixing this, having a ui_msg_prefix (or ui_section/ui_header/etc.)
command similar to ui_msg which prepends this prefix would be better and
more portable. Clients of macports1.0 could tell which prefix they
prefer or even get it through a different channel and add the prefix on
its own.

Rainer