[63189] trunk/dports/_resources/port1.0/group

Joshua Root jmr at macports.org
Fri Jan 29 00:08:28 PST 2010


On 2010-1-29 17:54 , Ryan Schmidt wrote:
> 
> On Jan 28, 2010, at 16:41, snc at macports.org wrote:
> 
>> Revision: 63189
>>          http://trac.macports.org/changeset/63189
>> Author:   snc at macports.org
>> Date:     2010-01-28 14:41:21 -0800 (Thu, 28 Jan 2010)
>> Log Message:
>> -----------
>> change portgroups from ui_msg to notes
> 
> I fear these changes are largely incorrect. ui_msg is a command, while notes is a variable (much like description and long_description). So you can't simply replace occurrences of ui_msg with notes and have things work properly. The idea is that notes is used for additional information the port may want to inform the user about after installation, and that the user can later type "port notes portname" to see them again if he's forgotten. Since I don't believe most of your changes meet that goal, I think you should probably revert most or all of this revision.

Reverted. Clear breakage in the ports tree needs to be reverted on the
spot, it's pushed live to users after all. In portgroups doubly so,
since they are used by multiple ports.

Better still, test sufficiently and don't commit broken code in the
first place.

- Josh


More information about the macports-dev mailing list