[70103] trunk/dports/lang/parrot/Portfile

[Thomas Keller]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am 30.07.10 03:47, schrieb Ryan Schmidt:
> On Jul 29, 2010, at 19:45, tommyd at macports.org wrote:
> 
>> Revision: 70103
>>          http://trac.macports.org/changeset/70103
>> Author:   tommyd at macports.org
>> Date:     2010-07-29 17:45:30 -0700 (Thu, 29 Jul 2010)
>> Log Message:
>> -----------
>> * configure with the correct --mandir so dependent ports
>>  which pick up the mandir through parrot_config install
>>  their man pages in a proper location
>> * install parrot straight into ${prefix}, so documentation,
>>  man pages (again) and other files are in the expected
>>  locations
> 
>> @@ -26,10 +27,12 @@
>> depends_lib             port:gmp port:icu
>>
>> configure.cmd           perl Configure.pl
>> -configure.pre_args      --prefix=${prefix}/lib/parrot
>> -configure.args          --optimize
>> +configure.pre_args      --prefix=${prefix} \
>> +                        --mandir=${prefix}/share/man \
>> +                        --optimize
> 
> The convention is that configure.pre_args is only for setting the prefix. Everything else goes in configure.args. So it would be better to say:
> 
> configure.pre_args      --prefix=${prefix}
> configure.args          --mandir=${prefix}/share/man \
>                         --optimize
> 
> Except that --prefix=${prefix} is the default for configure.pre_args, so you can simplify to just:
> 
> configure.args          --mandir=${prefix}/share/man \
>                         --optimize
> 

Ok, I'll include that in the next update.

> Were your changes approved by the port's maintainers, by the way?

Actually not, but as the port was largely outdated I did this (and the
earlier) NMU without the create-ticket-wait-72-hours-finally-continue
workflow. The port is also still not 100% usable (and was not before I
took my hands on it), see <http://trac.parrot.org/parrot/ticket/344> for
more details. Further updates will follow.

Thomas.

- -- 
GPG-Key 0x160D1092 | tommyd3mdi at jabber.ccc.de | http://thomaskeller.biz
Please note that according to the EU law on data retention, information
on every electronic information exchange might be retained for a period
of six months or longer: http://www.vorratsdatenspeicherung.de/?lang=en
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkxSMSwACgkQaf7NlBYNEJIsEwCfcBSjgDxQ96CscbjYcF/erYIR
SHQAmwR+ub2u3FrqMa+VrzMeAZlQkBWs
=iZI+
-----END PGP SIGNATURE-----