[79570] trunk/dports/mail

[Bradley Giesbrecht]

On Jun 18, 2011, at 1:15 PM, Ryan Schmidt wrote:

> On Jun 18, 2011, at 14:38, pixilla at macports.org wrote:
>> +maintainers         pixilla.com:brad
> 
> You don't wish to use your macports handle?
> 
>> +pre-configure {
>> +    reinplace "s|@@PREFIX@@|${destroot}${prefix}|g" ${worksrcpath}/Makefile
>> +    reinplace "s|@@PREFIX@@|${prefix}|g" ${worksrcpath}/etc/sqlgrey.conf
> 
> post-patch is a better place to do these reinplaces.
> 
> reinplace can do multiple files at once, so it might be more concise to combine the multiple reinplaces for each placeholder into single reinplaces for that placeholder.
> 
> reinplace "s|@@PREFIX@@|${prefix}|g" \
> 	${worksrcpath}/etc/sqlgrey.conf \
> 	${worksrcpath}/sqlgrey-logstats.pl \
> 	${worksrcpath}/sqlgrey \
> 	${worksrcpath}/tester.pl
> 
> The first reinplace is also slightly confusing; it might be clearer if the placeholder @@PREFIX@@ were always replaced with ${prefix} (and not sometimes with ${destroot}${prefix}); instead, you might want to just have a new placeholder @@DESTROOT@@.
> 
>> +use_configure       no
> 
> This is a great indicator that you either need to address UsingTheRightCompiler, build_arch, and a universal variant, or in this case, that the port doesn't install any architecture-specific files at all and therefore needs "supported_archs noarch".

Thanks Ryan. This was an old private port i dusted off... well, lets say I stirred the dust :)

Improvements always welcome.


Regards,
Bradley Giesbrecht (pixilla)

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.macosforge.org/pipermail/macports-dev/attachments/20110618/f8be85ff/attachment.html>