[79639] trunk/dports/net/ola/Portfile

[Ryan Schmidt]

On Jun 21, 2011, at 21:34, macsforever2000 at macports.org wrote:

> Revision: 79639
>          http://trac.macports.org/changeset/79639
> Author:   macsforever2000 at macports.org
> Date:     2011-06-21 19:34:02 -0700 (Tue, 21 Jun 2011)
> Log Message:
> -----------
> ola: Add variants. Fix license. Fix description. Sort dependencies. (#29899)
> 
> Modified Paths:
> --------------
>    trunk/dports/net/ola/Portfile
> 
> Modified: trunk/dports/net/ola/Portfile
> ===================================================================
> --- trunk/dports/net/ola/Portfile	2011-06-22 02:11:19 UTC (rev 79638)
> +++ trunk/dports/net/ola/Portfile	2011-06-22 02:34:02 UTC (rev 79639)
> @@ -7,10 +7,10 @@
> version             0.8.9-1
> categories          net comms
> platforms           darwin
> -license             LGPL-2.1+
> +license             GPL-2+ LGPL-2.1+
> maintainers         gmail.com:nomis52 p3k.org:interface
> 
> -description         an open framework for DMX lighting control
> +description         An open framework for DMX512 lighting control
> 
> long_description    The Open Lighting Architecture (OLA) provides a plugin \
>                     framework for distributing DMX512 control signals on \
> @@ -29,18 +29,27 @@
> depends_build       port:pkgconfig
> 
> depends_lib         port:cppunit \
> -                    port:unittest-cpp \
> -                    port:protobuf-cpp
> +                    port:protobuf-cpp \
> +                    port:unittest-cpp
> 
> configure.args      --disable-http \
>                     --disable-libusb
> 
> +variant python description {Enable the Python API} {
> +    configure.args-append   --enable-python-libs
> +}
> +
> variant http description {Build with embedded web server} {
>     depends_lib-append      port:libmicrohttpd
>     configure.args-delete   --disable-http
> }
> 
> -default_variants    +http
> +variant libusb description {Build with libusb support} {
> +    depends_lib-append      port:libusb
> +    configure.args-delete   --disable-libusb
> +}
> 
> +default_variants    +http +python +libusb

Because of the new default variants, the port's revision must be increased to offer this upgrade to existing users.

The python variant is problematic. *Which* python will this use? The answer is, I think, whichever one is selected by the user with "sudo port select python ...", which isn't ok. This probably needs multiple conflicting python variants, each designed for one of the many MacPorts python ports. (At least python26 and python27, and possibly python3* if they will work with it.)