[MacPorts] #33927: Add CELT051 audio codec to ports

[Fabiano Fidêncio]

On Thu, Apr 12, 2012 at 12:44 AM, Ryan Schmidt <ryandesign at macports.org> wrote:
> On Apr 11, 2012, at 22:20, Fabiano Fidêncio wrote:
>> On Wed, Apr 11, 2012 at 8:40 PM, MacPorts <noreply at macports.org> wrote:
>>> #33927: Add CELT051 audio codec to ports
>>> ----------------------------------+-----------------------------------------
>>>  Reporter:  fabiano@…             |       Owner:  macports-tickets@…
>>>     Type:  submission            |      Status:  new
>>>  Priority:  Normal                |   Milestone:
>>> Component:  ports                 |     Version:  2.0.4
>>>  Keywords:                        |        Port:  celt
>>> ----------------------------------+-----------------------------------------
>>> Changes (by ryandesign@…):
>>>
>>>  * port:  => celt
>>>
>>>
>>> Comment:
>>>
>>>  [http://www.macports.org/ports.php?by=name&substr=celt celt 0.11.1 is
>>>  already in MacPorts] (and it should probably be [ticket:34003 updated to
>>>  0.11.3]); you clearly based this celt 0.5.1.1 portfile on the existing
>>>  celt 0.11.1 portfile because the only changes from it are the version
>>>  number, checksums and maintainers line.
>>
>> Yeap, This is the more logic way to create a port, or am I wrong? :-)
>
> Sure, but you should have pointed out that this is what you did. When I first read your ticket, I thought you were submitting a completely new independent port called "celt". When I later went back to try to resolve the ticket, I realized we already have a port called "celt".

Sorry, I don't mind how serious it could be. Mainly because my first
contact with MacPorts were 2 patches applied without any credit. :-)

>
>
>>>  You're welcome to create a new celt05 port but it should be engineered in
>>>  such a way that it does not conflict with the existing celt port.
>>
>> Why it could conflict with celt port?
>> Did you test it, at least?
>
> [snip]
>
>> Summarizing, will it be applied? What I need to change for it?
>
> I did not test the portfile because it cannot be accepted as submitted. We already have a port "celt" version 0.11.1; we cannot accept a new port "celt" version 0.5.1.1. The subject of the ticket says "Add CELT051"; if you meant to name the port "celt051" then you should resubmit it with "celt051" in the name field. Before you do that, you should install the existing celt 0.11.1 port, then see if your new port celt051 can be installed without generating activation errors.

I'll do :-)
Thanks for the tips, Ryan.

>
>


Best Regards,
-- 
Fabiano Fidêncio