[90432] trunk/dports/lang/sbcl/Portfile

[Ryan Schmidt]

On Mar 5, 2012, at 03:56, easieste at macports.org wrote:

> Revision: 90432
>          http://trac.macports.org/changeset/90432
> Author:   easieste at macports.org
> Date:     2012-03-05 01:56:10 -0800 (Mon, 05 Mar 2012)
> Log Message:
> -----------
> lang/sbcl:  Add variant to force use of llvm-gcc-4.2.

Why would we want that?


> Addres futher style concerns voices by Ryan Schmidt.
> 
> Modified Paths:
> --------------
>    trunk/dports/lang/sbcl/Portfile


> @@ -1,30 +1,27 @@
> -# $Id$
> -# -*- coding: utf-8; mode: tcl; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- # vim:fenc=utf-8:filetype=tcl:et:sw=4:ts=4:sts=4
> +# $Id$ # -*- mode: tcl; coding: utf-8; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- # vim:fenc=utf-8:filetype=tcl:et:sw=4:ts=4:sts=4

You've combined the $Id$ and modeline lines. The modeline should be the first line, and the $Id$ line should be the second line.


> -long_description { 
> -Steel Bank Common Lisp (SBCL) is a Open Source development system for
> -ANSI Common Lisp. It provides an interactive environment including an
> -integrated native compiler, interpreter, and debugger. (And it, and
> -its generated code, can also play nicely with Unix when running
> -noninteractively.)
> +long_description {Steel Bank Common Lisp (SBCL) is a Open Source implementation of ANSI
> +Common Lisp. It provides an interactive environment including an
> +integrated native compiler, interpreter, and debugger. SBCL is quite
> +suitable for creation of long running system services.
> }

This still contains hard linebreaks. Every other port simply uses backslashes at the end of the line of the long_description, thus allowing MacPorts to insert soft linebreaks where appropriate for the terminal window's width -- just as the sbcl port did before you started making changes. :) It was really better the way it was before.


> -homepage	http://www.sbcl.org
> +homepage	    http://www.sbcl.org
> master_sites	sourceforge
> -use_bzip2	yes
> +use_bzip2	    yes

If you have whitespace changes to make, they should be made in a separate commit.


> +variant use-llvm-gcc-4.2 description {Force the use of LLVM GCC 4.2. 
> +This is perhaps better handled with the gcc_select port.} { 
> +    configure.compiler llvm-gcc-4.2
> +}

The gcc_select port is for the user's convenience in selecting a compiler for their use for things outside of MacPorts; ports themselves may not use the compiler the user has selected; ports use the default compiler for the currently-installed version of Xcode (which MacPorts sets the configure.compiler variable to), or a different compiler the port maintainer chose (by setting configure.compiler) if that's necessary for some reason.

Is using llvm-gcc-4.2 necessary or beneficial for sbcl for some reason?