[90977] trunk/dports/devel/libzookeeper/Portfile

[Jeremy Huddleston]

Please make an effort to actually address build failures rather than just falling back on older compilers.  At minimum, please explain why you are falling back in a comment or in the change log.

Here's a better fix:

Index: Portfile
===================================================================
--- Portfile	(revision 91320)
+++ Portfile	(working copy)
@@ -44,7 +44,7 @@
 }
 
 if {${configure.compiler} == "clang"} {
-    configure.compiler llvm-gcc-4.2
+    configure.cflags-append "--std=gnu89"
 }
 
 build.args          CFLAGS="${configure.cflags} [get_canonical_archflags]"


On Mar 20, 2012, at 7:47 AM, hum at macports.org wrote:

> Revision: 90977
>          https://trac.macports.org/changeset/90977
> Author:   hum at macports.org
> Date:     2012-03-20 07:47:34 -0700 (Tue, 20 Mar 2012)
> Log Message:
> -----------
> libzookeeper: update to 3.3.5; set configure.compiler to llvm-gcc-4.2; modify livecheck.url.
> 
> Modified Paths:
> --------------
>    trunk/dports/devel/libzookeeper/Portfile
> 
> Modified: trunk/dports/devel/libzookeeper/Portfile
> ===================================================================
> --- trunk/dports/devel/libzookeeper/Portfile	2012-03-20 14:46:03 UTC (rev 90976)
> +++ trunk/dports/devel/libzookeeper/Portfile	2012-03-20 14:47:34 UTC (rev 90977)
> @@ -4,7 +4,7 @@
> PortSystem          1.0
> 
> name                libzookeeper
> -version             3.3.4
> +version             3.3.5
> maintainers         brett hum
> categories          devel
> platforms           darwin
> @@ -24,8 +24,8 @@
> distname            zookeeper-${version}
> dist_subdir         zookeeper
> master_sites        apache:zookeeper/stable
> -checksums           rmd160  554dd95111f0a81eb7cac22888c2e72515cd63e3 \
> -                    sha256  de698d412c4b0ed5230aec9c4412045803f09ba0a0f7839c707a22809d2dbce9
> +checksums           rmd160  bfd028deb55f075f286eed3dbb6a215f83e0f083 \
> +                    sha256  b78b92edf489fca7587ec6ddfcd95714449d55b1288a67a7369844fa61124f0a
> 
> worksrcdir          ${distname}/src/c
> 
> @@ -43,8 +43,12 @@
>     reinplace "s|c-client-src|zookeeper|" ${worksrcpath}/Makefile
> }
> 
> +if {${configure.compiler} == "clang"} {
> +    configure.compiler llvm-gcc-4.2
> +}
> +
> build.args          CFLAGS="${configure.cflags} [get_canonical_archflags]"
> 
> livecheck.type      regex
> -livecheck.url       http://www.eu.apache.org/dist/zookeeper/stable/
> +livecheck.url       http://www.apache.org/dist/zookeeper/stable/
> livecheck.regex     zookeeper-(\[0-9.\]+)\\.tar
> _______________________________________________
> macports-changes mailing list
> macports-changes at lists.macosforge.org
> http://lists.macosforge.org/mailman/listinfo.cgi/macports-changes



---
Jeremy Huddleston

Rebuild Sudan
 - Board of Directors
 - http://www.rebuildsudan.org

Berkeley Foundation for Opportunities in Information Technology
 - Advisory Board
 - http://www.bfoit.org