[108496] trunk/dports/devel

[Daniel J. Luke]

On Jul 25, 2013, at 2:28 PM, Ryan Schmidt <ryandesign at macports.org> wrote:
> 
> On Jul 24, 2013, at 15:08, dluke at macports.org wrote:
> 
>> Revision
>> 108496
>> Author
>> dluke at macports.org
>> Date
>> 2013-07-24 13:08:14 -0700 (Wed, 24 Jul 2013)
>> Log Message
>> 
>> subversion and bindings ports: Add new patchfiles for swig bindings ports, update subversion unicode patch
> 
> 
>> +@@ -5885,7 +5861,7 @@
>> +     arg1 = (struct svn_log_entry_t *)(argp1);
>> +     result = (apr_hash_t *) ((arg1)->changed_paths2);
>> +     {
>> +-      /*@SWIG:/home/breser/wandisco/svnrm-1.8/prefix/share/swig/2.0.9/perl5/perltypemaps.swg,59,%append_output@*/ if (argvi >= items) EXTEND(sp,1); /*@SWIG:/home/breser/wandisco/svnrm-1.8/prefix/share/swig/2.0.9/perl5/perltypemaps.swg,56,%set_output@*/ ST(argvi) = (result) ? svn_swig_pl_convert_hash(result, SWIGTYPE_p_svn_log_changed_path2_t)
>> ++      /*@SWIG:/opt/local/share/swig/2.0.9/perl5/perltypemaps.swg,59,%append_output@*/ if (argvi >= items) EXTEND(sp,1); /*@SWIG:/opt/local/share/swig/2.0.9/perl5/perltypemaps.swg,56,%set_output@*/ ST(argvi) = (result) ? svn_swig_pl_convert_hash(result, SWIGTYPE_p_svn_log_changed_path2_t)
>> +       :&PL_sv_undef; argvi++ /*@SWIG@*/
>> +       /*@SWIG@*/
>> +       
> 
> Isn't it a problem that /opt/local is hardcoded into the patchfile? What if the MacPorts prefix isn't /opt/local?

I don't think it's an issue.

1 - it's in a comment
2 - the unpatched file contains the path /home/breser/wandisco/svnrm-1.8/prefix/share/swig/2.0.9/perl5/perltypemaps.swg, which I'm sure most users don't have on their system ;-)

are you seeing a problem with the port in a prefix that isn't /opt/local?
--
Daniel J. Luke                                                                   
+========================================================+                        
| *---------------- dluke at geeklair.net ----------------* |                          
| *-------------- http://www.geeklair.net -------------* |                          
+========================================================+                        
|   Opinions expressed are mine and do not necessarily   |                          
|          reflect the opinions of my employer.          |                          
+========================================================+