[113631] trunk/dports/graphics/wxWidgets-3.0

[Ryan Schmidt]

On Nov 21, 2013, at 06:28, mojca at macports.org wrote:

> Revision
> 113631
> Author
> mojca at macports.org
> Date
> 2013-11-21 04:28:53 -0800 (Thu, 21 Nov 2013)
> Log Message
> 
> wxWigets-3.0: remove a patch that fails on 10.5 (#41420)
> Modified Paths
> 
> 	• trunk/dports/graphics/wxWidgets-3.0/Portfile
> Added Paths
> 
> 	• trunk/dports/graphics/wxWidgets-3.0/files/patch-src-osx-cocoa-utils.mm.diff
> Removed Paths
> 
> 	• trunk/dports/graphics/wxWidgets-3.0/files/patch-upstream-nonbundled.diff
> Diff
> 
> Modified: trunk/dports/graphics/wxWidgets-3.0/Portfile (113630 => 113631)
> 
> --- trunk/dports/graphics/wxWidgets-3.0/Portfile	2013-11-21 12:25:32 UTC (rev 113630)
> +++ trunk/dports/graphics/wxWidgets-3.0/Portfile	2013-11-21 12:28:53 UTC (rev 113631)
> 
> @@ -73,9 +73,15 @@
> 
>  
> 
>  patch.dir           ${worksrcpath}/..
> 
>  
> 
> -patchfiles-append   patch-configure.diff \
> -                    patch-upstream-nonbundled.diff
> 
> +patchfiles-append   patch-configure.diff
> 
>  
> 
> +if {${os.major} > 10} {
> +    # the patch doesn't work on 10.5, but it's still better to have working wxWidgets with a flaw
> +    # than not bing able to compile it at all
> +    patchfiles-append \
> +                    patch-src-osx-cocoa-utils.mm.diff
> +}

What about 10.6? Does the patch succeed on that version? If so, why not use the patch there?