certsync: Please test patches on systems < 10.9

Thu Aug 28 18:07:07 PDT 2014

On 2014-8-8 22:23 , Clemens Lang wrote:
> Hi,
> 
>> certsync.m: In function ‘ValidateSystemTrust’:
>> certsync.m:163: error: ‘SecPolicyCreateBasicX509’ undeclared (first use
>> in this function)
>> certsync.m:163: error: (Each undeclared identifier is reported only once
>> certsync.m:163: error: for each function it appears in.)
>> certsync.m:164: warning: implicit declaration of function
>> ‘SecPolicyCreateBasicX509’
>> certsync.m:164: warning: assignment makes pointer from integer without a
>> cast
>> Command failed: /usr/bin/gcc-4.2  -Os  -mmacosx-version-min=10.4  -Wall
>>  certsync.m -o certsync  -L/opt/local/lib
>> -Wl,-headerpad_max_install_names  -arch i386  -framework Foundation
>> -framework Security -framework CoreServices
> 
> Yesterday, I remembered there were some changes I wanted to commit to
> certsync but haven't finished yet. Can you try the attached patch against
> certsync's $filesdir again on 10.5 and 10.4?

Builds without warnings on Leopard but fails to run:

$ ./certsync
Failed to extract certificate description for untrusted certificate:
Error Domain=NSOSStatusErrorDomain Code=-25303 UserInfo=0x14d350
"SecCertificateCopyCommonName() failed" ( / The attribute does not exist.)
Segmentation fault

Crash log attached.

Some warnings on Tiger, but it builds and seems to work.

certsync.m: In function 'certificatesForTrustDomain':
certsync.m:298: warning: implicit declaration of function
'SecTrustSettingsCopyTrustSettings'
certsync.m: In function 'exportCertificates':
certsync.m:406: warning: implicit declaration of function
'SecCopyErrorMessageString'
certsync.m:406: warning: passing argument 1 of 'PLCFAutorelease' makes
pointer from integer without a cast
certsync.m:426: warning: passing argument 1 of 'PLCFAutorelease' makes
pointer from integer without a cast

- Josh
-------------- next part --------------
Process:         certsync [26982]
Path:            ./certsync
Identifier:      certsync
Version:         ??? (???)
Code Type:       X86 (Native)
Parent Process:  bash [1234]

Date/Time:       2014-06-26 09:09:46.310 +1000
OS Version:      Mac OS X Server 10.5.8 (9L34)
Report Version:  6
Anonymous UUID:  39EFAB35-361E-46EF-B11C-1497D1B4EBCB

Exception Type:  EXC_BAD_ACCESS (SIGSEGV)
Exception Codes: KERN_INVALID_ADDRESS at 0x00000000204e4f49
Crashed Thread:  0

Thread 0 Crashed:
0   libobjc.A.dylib               	0x9478c68c objc_msgSend + 28
1   certsync                      	0x000044c5 certificatesForTrustDomain + 1267
2   certsync                      	0x0000478b main + 521
3   certsync                      	0x00003d03 _start + 209
4   certsync                      	0x00003c31 start + 41

Thread 0 crashed with X86 Thread State (32-bit):
  eax: 0xbffff808  ebx: 0x00003e3e  ecx: 0x94807a64  edx: 0x00117940
  edi: 0x204e4f49  esi: 0x00000000  ebp: 0xbffff788  esp: 0xbffff734
   ss: 0x0000001f  efl: 0x00010282  eip: 0x9478c68c   cs: 0x00000017
   ds: 0x0000001f   es: 0x0000001f   fs: 0x00000000   gs: 0x00000037
  cr2: 0x204e4f49

Binary Images:
    0x1000 -     0x4fff +certsync ??? (???) <51dc677a0c3cb8886a56ed179378c668> /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_security_certsync/certsync/work/destroot/opt/local/libexec/certsync
0x8fe00000 - 0x8fe2db43  dyld 97.1 (???) <458eed38a009e5658a79579e7bc26603> /usr/lib/dyld
0x9003e000 - 0x900c5ff7  libsqlite3.0.dylib ??? (???) <aaaf72c093e13f34b96e2688b95bdb4a> /usr/lib/libsqlite3.0.dylib
0x9090f000 - 0x9093afe7  libauto.dylib ??? (???) <4f3e58cb81da07a1662c1f647ce30225> /usr/lib/libauto.dylib
0x90e0d000 - 0x90e6affb  libstdc++.6.dylib ??? (???) <04b812dcec670daa8b7d2852ab14be60> /usr/lib/libstdc++.6.dylib
0x90e6b000 - 0x90e9afe3  com.apple.AE 402.3 (402.3) <dba512e47f68eea1dd0ab35f596edb34> /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/AE.framework/Versions/A/AE
0x90edb000 - 0x90edbffa  com.apple.CoreServices 32 (32) <2fcc8f3bd5bbfc000b476cad8e6a3dd2> /System/Library/Frameworks/CoreServices.framework/Versions/A/CoreServices
0x91145000 - 0x9127eff7  libicucore.A.dylib ??? (???) <f2819243b278259b9a622ea111ea5fd6> /usr/lib/libicucore.A.dylib
0x927a7000 - 0x927defff  com.apple.SystemConfiguration 1.9.2 (1.9.2) <41d5aeffefc6d19d471f51ae0b15024f> /System/Library/Frameworks/SystemConfiguration.framework/Versions/A/SystemConfiguration
0x928f8000 - 0x92985ff7  com.apple.LaunchServices 292 (292) <a41286c7c1eb20ffd5cc796f791070f0> /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/LaunchServices.framework/Versions/A/LaunchServices
0x92dd7000 - 0x92ddffff  com.apple.DiskArbitration 2.2.1 (2.2.1) <ba64dd6ada417b5e7be736957f380bca> /System/Library/Frameworks/DiskArbitration.framework/Versions/A/DiskArbitration
0x92e9d000 - 0x92ea4fe9  libgcc_s.1.dylib ??? (???) <f53c808e87d1184c0f9df63aef53ce0b> /usr/lib/libgcc_s.1.dylib
0x92f52000 - 0x9300dfe3  com.apple.CoreServices.OSServices 228.1 (228.1) <9c640e79ad97f335730d8a49f6cb2032> /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/OSServices.framework/Versions/A/OSServices
0x93289000 - 0x9329ffff  com.apple.DictionaryServices 1.0.0 (1.0.0) <ad0aa0252e3323d182e17f50defe56fc> /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/DictionaryServices.framework/Versions/A/DictionaryServices
0x9338c000 - 0x93433fec  com.apple.CFNetwork 438.16 (438.16) <0a2f633dc532b176109547367f209ced> /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/CFNetwork.framework/Versions/A/CFNetwork
0x9465f000 - 0x94663fff  libmathCommon.A.dylib ??? (???) /usr/lib/system/libmathCommon.A.dylib
0x94676000 - 0x94703ff7  com.apple.framework.IOKit 1.5.2 (???) <7a3cc24f78f93931731203854ae0d891> /System/Library/Frameworks/IOKit.framework/Versions/A/IOKit
0x94777000 - 0x94857fff  libobjc.A.dylib ??? (???) <3ca288b625a47bbcfe378158e4dc328f> /usr/lib/libobjc.A.dylib
0x94858000 - 0x94ad4fe7  com.apple.Foundation 6.5.9 (677.26) <c68b3cff7864959becfc7fd1a384f925> /System/Library/Frameworks/Foundation.framework/Versions/C/Foundation
0x94b4a000 - 0x94c2bff7  libxml2.2.dylib ??? (???) <f274ba384fb55203873f9c17569ef131> /usr/lib/libxml2.2.dylib
0x951e5000 - 0x9522efef  com.apple.Metadata 10.5.8 (398.26) <e4d268ea45379200f03cdc7c8bedae6f> /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/Metadata.framework/Versions/A/Metadata
0x95471000 - 0x95478ffe  libbsm.dylib ??? (???) <d25c63378a5029648ffd4b4669be31bf> /usr/lib/libbsm.dylib
0x95799000 - 0x958ccfe7  com.apple.CoreFoundation 6.5.7 (476.19) <a332c8f45529ee26d2e9c36d0c723bad> /System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation
0x95eaa000 - 0x9607bfef  com.apple.security 5.0.7 (1) <44e26a9c40630a54d5a9f70c18483411> /System/Library/Frameworks/Security.framework/Versions/A/Security
0x96b4e000 - 0x96b5cffd  libz.1.dylib ??? (???) <5ddd8539ae2ebfd8e7cc1c57525385c7> /usr/lib/libz.1.dylib
0x96cde000 - 0x96d02fff  libxslt.1.dylib ??? (???) <c372568bd2f7169efa0faee6546eead3> /usr/lib/libxslt.1.dylib
0x96d03000 - 0x96e6aff3  libSystem.B.dylib ??? (???) <be7a9fa5c8a925578bddcbaa72e5bf6e> /usr/lib/libSystem.B.dylib
0x97355000 - 0x9762fff3  com.apple.CoreServices.CarbonCore 786.16 (786.16) <d2af3f75c3500c518c39fd00aed7f9b9> /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/CarbonCore.framework/Versions/A/CarbonCore
0x97682000 - 0x97701ff5  com.apple.SearchKit 1.2.2 (1.2.2) <3b5f3ab6a363a4d8a2bbbf74213ab0e5> /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/SearchKit.framework/Versions/A/SearchKit
0x97722000 - 0x97740fff  libresolv.9.dylib ??? (???) <0e26b308654f33fc94a0c010a50751f9> /usr/lib/libresolv.9.dylib
0xfffe8000 - 0xfffebfff  libobjc.A.dylib ??? (???) /usr/lib/libobjc.A.dylib
0xffff0000 - 0xffff1780  libSystem.B.dylib ??? (???) /usr/lib/libSystem.B.dylib