[115561] trunk/dports/audio/mpd/Portfile

[Ryan Schmidt]

On Jan 4, 2014, at 22:58, rmstonecipher at macports.org wrote:

> Revision
> 115561
> Author
> rmstonecipher at macports.org
> Date
> 2014-01-04 20:58:26 -0800 (Sat, 04 Jan 2014)
> Log Message
> 
> audio/mpd changed compiler on snow leopard per buildbot output <https://build.macports.org/builders/buildports-snowleopard-x86_64/builds/23750>
> Modified Paths
> 
> 	• trunk/dports/audio/mpd/Portfile
> Diff
> 
> Modified: trunk/dports/audio/mpd/Portfile (115560 => 115561)
> 
> --- trunk/dports/audio/mpd/Portfile	2014-01-05 03:32:11 UTC (rev 115560)
> +++ trunk/dports/audio/mpd/Portfile	2014-01-05 04:58:26 UTC (rev 115561)
> 
> @@ -73,6 +73,10 @@
> 
>  }
> 
>  default_variants    mad

Default variants must include “+” or “-“ as desired, e.g.:

default_variants +mad

if you want to enable the variant by default or:

default_variants -mad

if you want to disable it by default.


> +platform darwin 10 {
> +    configure.compiler  macports-gcc-4.6
> +}

The output from the buildbot log says:

src/Compiler.h:44:6: error: #error Sorry, your gcc version is too old. You need at least version 4.6.

So this will be a problem on Darwin 10 *and earlier* not just on Darwin 10.

A better way to handle this is with compiler.blacklist. Blacklist the compilers that won’t work (i.e. the old versions of GCC Xcode provided) so that MacPorts can pick a compiler that works, which will be clang. We would rather use a newer clang than a newer gcc.

compiler.blacklist *gcc-3.3 *gcc-4.0 *gcc-4.2