[macports-ports] 01/02: meson-1.0: new PortGroup

[Ryan Schmidt]

On Dec 19, 2017, at 14:01, Mojca Miklavec wrote:

> Mojca Miklavec (mojca) pushed a commit to branch master
> in repository macports-ports.
> 
> 
> https://github.com/macports/macports-ports/commit/b579e9f4eeb555c2fcf317650a43d94f0026dade
> 
> commit b579e9f4eeb555c2fcf317650a43d94f0026dade
> 
> Author: Mojca Miklavec <mojca at macports.org>
> AuthorDate: Thu Nov 9 10:00:48 2017 +0100
> 
> 
>     meson-1.0: new PortGroup
> 
>     
> 
>     The PortGroup supports building with the meson build system
> 
>     * http://mesonbuild.com
> 
> ---
>  _resources/port1.0/group/meson-1.0.tcl | 67 ++++++++++++++++++++++++++++++++++



> +# Meson's install_name currently seems to be broken, so workarounds might be needed to make ports actually work.
> +# See: https://github.com/mesonbuild/meson/issues/2121

Yeah something is going to have to get fixed there. I don't understand why they want to use @rpath which requires Mac OS X 10.5 or greater. I'd like to rip that out and replace it with plain old absolute-path install_names which we use almost everywhere in MacPorts and they work great on all macOS versions.


> +# meson builds need to be done out-of-source
> +default build_dir           {${workpath}/build}

MacPorts doesn't have an option called "build_dir" so I don't even know how this is working...


> +default configure.post_args {"${configure.dir} ${build_dir}"}
> +default build.dir           {${build_dir}}

Why do we need an additional level of indirection? Why can't we just:

default build.dir           {${workpath}/build}
default configure.post_args {"${configure.dir} ${build.dir}"}