<div dir="ltr">Hi Ryan,<div><br></div><div>Why is using a patchfile instead of reinplace preferable?</div><div><br></div><div>David</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Sun, Jun 8, 2014 at 3:33 PM, Ryan Schmidt <span dir="ltr"><<a href="mailto:ryandesign@macports.org" target="_blank">ryandesign@macports.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Jun 5, 2014, at 12:30 PM, <a href="mailto:mf2k@macports.org">mf2k@macports.org</a> wrote:<br>
<br>
> Revision<br>
> 120684<br>
> Author<br>
> <a href="mailto:mf2k@macports.org">mf2k@macports.org</a><br>
> Date<br>
> 2014-06-05 10:30:25 -0700 (Thu, 05 Jun 2014)<br>
> Log Message<br>
><br>
> srecord: Update to version 1.63. (#43916)<br>
> Modified Paths<br>
><br>
> • trunk/dports/devel/srecord/Portfile<br>
<br>
> @@ -30,8 +30,17 @@<br>
><br>
> offsets, split and unsplit for memory striping schemes.<br>
><br>
> homepage <a href="http://srecord.sourceforge.net/" target="_blank">http://srecord.sourceforge.net/</a><br>
> master_sites sourceforge<br>
><br>
> -checksums md5 8fce124d47f23b4aa187c3b8eebc9fd7<br>
><br>
> +checksums rmd160 668d5dc75960666a7c99509f39ecd2602891c384 \<br>
> + sha256 78fec76d04424506e319f59b19a520428a7449ed087a67e1779fa2996992bf1a<br>
> +depends_build port:libtool<br>
><br>
> configure.cflags-append "-I${prefix}/include"<br>
><br>
> -configure.args --mandir=${destroot}${prefix}/share/man<br>
><br>
> +configure.env-append "LIBTOOL=glibtool"<br>
<br>
Consider specifying the absolute path to glibtool i.e. ${prefix}/bin/glibtool, just in case the user has an unusual binpath configured.<br>
<br>
<br>
> destroot.destdir prefix=${destroot}${prefix}<br>
><br>
><br>
><br>
> +pre-configure {<br>
> + reinplace {s|@bindir@|$(prefix)/bin|} ${worksrcpath}/Makefile.in<br>
> + reinplace {s|@mandir@|$(prefix)/share/man|} ${worksrcpath}/Makefile.in<br>
> + reinplace {s|@datarootdir@|$(prefix)/share|} ${worksrcpath}/Makefile.in<br>
> + reinplace {s|@libdir@|$(prefix)/lib|} ${worksrcpath}/Makefile.in<br>
> + reinplace {s|@includedir@|$(prefix)/include|} ${worksrcpath}/Makefile.in<br>
> +}<br>
<br>
Could this be done as a normal patchfile instead? I notice you're using parentheses e.g. "$(prefix)" which is Makefile variable expansion syntax, not curly brackets e.g. "${prefix}" which would be the Tcl variable expansion syntax, so no variable substitution is happening here at reinplace time anyway.<br>
<br>
_______________________________________________<br>
macports-dev mailing list<br>
<a href="mailto:macports-dev@lists.macosforge.org">macports-dev@lists.macosforge.org</a><br>
<a href="https://lists.macosforge.org/mailman/listinfo/macports-dev" target="_blank">https://lists.macosforge.org/mailman/listinfo/macports-dev</a><br>
</blockquote></div><br></div>