<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Sun, Jun 22, 2014 at 6:55 PM, Ryan Schmidt <span dir="ltr"><<a href="mailto:ryandesign@macports.org" target="_blank">ryandesign@macports.org</a>></span> wrote:<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="">
On Jun 22, 2014, at 9:54 AM, Kurt Hindenburg wrote:<br>
> On 6/21/14, 7:20 PM, Ryan Schmidt wrote:<br>
>> Wouldn't this patch be safe to use on all OS X versions? If so, that should be done. This will ensure that someone updating the port on a version of OS X earlier than Mavericks does not inadvertently forget to update the patch, if needed.<br>
> I don't think so as the ticket was only for building on Mavericks. Also, the buildbots didn't throw up any errors. The only way I could test is to add it to all versions and see what the buildbot did.<br><br>
</div>I know the ticket was about a build failure only on Mavericks. The reason for the build failure was that daemon includes an unconditional definition of the function strlcat, but Mavericks now includes its own version of it, thus causing a conflict. The patch that you added fixes the problem by only defining strlcat if it is not already defined. Thus it seems like it should be safe to use that patch on all versions of OS X, which would be preferred for the above-stated reason.</blockquote>
<div><br></div><div>It's not so much Mavericks as Xcode 5, I think; at least, my 10.8 system has strlcat predeclared (it was causing compile warnings in a non-MacPorts program I build locally).</div><div><br></div></div>
-- <br><div dir="ltr"><div>brandon s allbery kf8nh sine nomine associates</div><div><a href="mailto:allbery.b@gmail.com" target="_blank">allbery.b@gmail.com</a> <a href="mailto:ballbery@sinenomine.net" target="_blank">ballbery@sinenomine.net</a></div>
<div>unix, openafs, kerberos, infrastructure, xmonad <a href="http://sinenomine.net" target="_blank">http://sinenomine.net</a></div></div>
</div></div>