<div dir="ltr">Hey Frank,<div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><span style="font-family:arial,sans-serif;font-size:13px">1. First, it found an inactive port, but the default action is not clear. </span></blockquote>
<div><br></div><div>Ah, good catch! I completely forgot that people might insert things besides a Y or an N. I'll make sure to clear that up! </div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<span style="font-family:arial,sans-serif;font-size:13px">2. The default output is *way* too verbose. </span></blockquote><div><br></div><div>Hm, yeah, that's a good point and should be a simple change to make as well.</div>
<div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"> <span style="font-family:arial,sans-serif;font-size:13px">3. It hit an error on mine:</span></blockquote>
<div><br></div><div>Right, yeah, that's because currently the code uses recursion to go through all the distfiles and delete them all. Which means if you have a lot of distfiles to delete and sort through, you'll get a stack overflow (i.e. the error you got). It's a known bug right now, and I'm trying to think up a way to still explore multi-layer directories without the use of recursion. On the plus side, doesn't necessarily mean anything went wrong, and you shouldn't get it on subsequent runs (unless you have A LOT of distfiles, I suppose).</div>
<div><br></div><div>Thanks for all the suggestions/bug catches!</div><div>-Kyle</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Aug 29, 2014 at 12:02 PM, Frank Schima <span dir="ltr"><<a href="mailto:mf2k@macports.org" target="_blank">mf2k@macports.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word">Hi Kyle,<div><br></div><div><br></div><div>Thanks for working on this! I have some comments below:</div>
<div><br><div><div><div class=""><div>On Aug 29, 2014, at 12:39 PM, Kyle Sammons <<a href="mailto:ksammons@macports.org" target="_blank">ksammons@macports.org</a>> wrote:</div><br><blockquote type="cite"><div dir="ltr">
<div>port reclaim - Removes all unneeded distfiles currently on the system, and offers to uninstall all inactive applications, if the user desires. </div></div></blockquote><div><br></div></div><div>I tried to use this for the first time today. Here are my observations:</div>
<div><br></div><div>1. First, it found an inactive port, but the default action is not clear. </div><div><br></div><div><font face="Monaco">$ sudo port reclaim<br>Found inactive ports: telepathy-glib.<br>Would you like to uninstall these apps? [Y/N]: </font></div>
<div><br></div><div>This is good but it is not clear what the default action is if you hit return. It is apparently “N”, so the “Y” should be lower case. i.e. <span style="font-family:Monaco">[y/N]</span></div><div><br></div>
<div>2. The default output is *way* too verbose. </div><div><font face="Monaco">Found distfile: ipython-2.1.0.tar.gz<br>Removing distfile: ipython-2.1.0.tar.gz<br>Found distfile: LightAquaBlue-framework-MacOS10.6.zip<br>Removing distfile: LightAquaBlue-framework-MacOS10.6.zip<br>
Found distfile: LightAquaBlue-python-MacOS10.6.zip<br>Removing distfile: LightAquaBlue-python-MacOS10.6.zip<br>Found distfile: lightblue-0.4.tar.gz<br>Removing distfile: lightblue-0.4.tar.gz<br>Found empty directory: /opt/local/var/macports/distfiles/py-lightblue. Attempting to delete.<br>
Found distfile: qutip-3.0.1.tar.gz<br>…</font></div><div><br></div><div>I think it should mention what it is doing in general at first because it will sit there working and then summarize in a manner such as "deleted X distfiles and Y empty directories” and maybe say how much space was saved?</div>
<div><br></div><div>The current output would be fine if using -v or -d. </div><div><br></div><div>3. It hit an error on mine:</div><div><font face="Monaco">...</font></div><div><font face="Monaco">Found empty directory: /Users/schimaf/.cpan/build/Moose-2.1210-ZIZYEB/bin. Attempting to delete.<br>
Found distfile: Changes<br>Removing distfile: Changes<br>Found distfile: Changes.Class-MOP<br>Removing distfile: Changes.Class-MOP<br>Found distfile: dist.ini<br>Removing distfile: dist.ini<br>Found distfile: moosex-compile<br>
Removing distfile: moosex-compile<br>too many nested evaluations (infinite loop?)<br> (procedure "ui_message" line 2)<br> invoked from within<br>"ui_msg "Found distfile: $item""<br> (procedure "walk_files" line 45)<br>
invoked from within<br>"walk_files $currentPath $delete $dist_paths"<br> (procedure "walk_files" line 37)<br> invoked from within<br>"walk_files $up_dir $delete $dist_paths"<br> (procedure "walk_files" line 27)<br>
invoked from within<br>"walk_files $dir $delete $dist_paths"<br> (procedure "walk_files" line 60)<br> invoked from within<br>"walk_files $currentPath $delete $dist_paths"<br> (procedure "walk_files" line 37)<br>
invoked from within<br>"walk_files $up_dir $delete $dist_paths"<br> (procedure "walk_files" line 27)<br> invoked from within<br>"walk_files $dir $delete $dist_paths"<br> (procedure "walk_files" line 60)<br>
invoked from within<br>"walk_files $currentPath $delete $dist_paths"<br> (procedure "walk_files" line 37)<br>...</font></div><div class=""><div><br></div><blockquote type="cite"><div dir="ltr"><div>
port doctor - Checks for common issues on the users system, and if found, suggests ways to fix the problem. Doctor accepts one flag (--quiet) which only shows warnings/errors rather than showing the status of each check. There is also a configuration file for doctor located in, "/opt/local/var/macports/port_doctor.ini", which allows the user to make changes to certain ways doctor operates, though currently the config file isn't used as much as it could be. </div>
</div></blockquote><div><br></div></div><div>I like “diagnose” out of the suggestions offered. </div><div><br></div><br></div><div>Cheers!</div><span class="HOEnZb"><font color="#888888"><div>Frank</div><br></font></span></div>
</div></div></blockquote></div><br></div>