<html><head><meta http-equiv="content-type" content="text/html; charset=utf-8"></head><body dir="auto"><div>This may require some revbumps. I'll work on that tomorrow.<br><br><div>vq</div>Sent from my iPhone</div><div><br>On May 27, 2015, at 3:03 AM, <a href="mailto:larryv@macports.org">larryv@macports.org</a> wrote:<br><br></div><blockquote type="cite"><div>
<meta http-equiv="content-type" content="text/html; charset=utf-8">
<title>[136794] trunk/dports/_resources/port1.0/group/select-1.0.tcl</title>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="https://trac.macports.org/changeset/136794">136794</a></dd>
<dt>Author</dt> <dd><a href="mailto:larryv@macports.org">larryv@macports.org</a></dd>
<dt>Date</dt> <dd>2015-05-27 00:03:53 -0700 (Wed, 27 May 2015)</dd>
</dl>
<h3>Log Message</h3>
<pre>select-1.0: Don't overwrite `name` (#47849)
Also rename some other common-word variables.
Bug introduced in <a href="https://trac.macports.org/changeset/136723">r136723</a>. I forgot that portfile options are visible as
global variables in pre/post scripts.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkdports_resourcesport10groupselect10tcl">trunk/dports/_resources/port1.0/group/select-1.0.tcl</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkdports_resourcesport10groupselect10tcl"></a>
<div class="modfile"><h4>Modified: trunk/dports/_resources/port1.0/group/select-1.0.tcl (136793 => 136794)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/dports/_resources/port1.0/group/select-1.0.tcl 2015-05-27 06:38:28 UTC (rev 136793)
+++ trunk/dports/_resources/port1.0/group/select-1.0.tcl 2015-05-27 07:03:53 UTC (rev 136794)
</span><span class="lines">@@ -75,23 +75,23 @@
</span><span class="cx"> select.entries-prepend [list ${select.group} ${select.file}]
</span><span class="cx"> }
</span><span class="cx"> ui_debug {PortGroup select: Installing select files to destroot}
</span><del>- foreach entry ${select.entries} {
- set extras [lassign $entry group file name]
</del><ins>+ foreach selectEntry ${select.entries} {
+ set extras [lassign $selectEntry selectGroup selectFile selectName]
</ins><span class="cx"> if {[llength $extras] > 0} {
</span><span class="cx"> ui_debug "PortGroup select:\
</span><del>- Ignoring entry with too many elements: '$entry'"
</del><ins>+ Ignoring entry with too many elements: '$selectEntry'"
</ins><span class="cx"> continue
</span><span class="cx"> }
</span><del>- if {$group eq ""} {
</del><ins>+ if {$selectGroup eq ""} {
</ins><span class="cx"> ui_debug "PortGroup select:\
</span><del>- Ignoring entry with missing group name: '$entry'"
</del><ins>+ Ignoring entry with missing group name: '$selectEntry'"
</ins><span class="cx"> continue
</span><span class="cx"> }
</span><del>- if {$file eq ""} {
</del><ins>+ if {$selectFile eq ""} {
</ins><span class="cx"> ui_debug "PortGroup select:\
</span><del>- Ignoring entry with missing file name: '$entry'"
</del><ins>+ Ignoring entry with missing file name: '$selectEntry'"
</ins><span class="cx"> continue
</span><span class="cx"> }
</span><del>- select::install $group $file $name
</del><ins>+ select::install $selectGroup $selectFile $selectName
</ins><span class="cx"> }
</span><span class="cx"> }
</span></span></pre>
</div>
</div>
</div></blockquote><blockquote type="cite"><div><span>_______________________________________________</span><br><span>macports-changes mailing list</span><br><span><a href="mailto:macports-changes@lists.macosforge.org">macports-changes@lists.macosforge.org</a></span><br><span><a href="https://lists.macosforge.org/mailman/listinfo/macports-changes">https://lists.macosforge.org/mailman/listinfo/macports-changes</a></span><br></div></blockquote></body></html>