<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">On Jun 23, 2015, at 1:06 PM, <a href="mailto:chunyang@macports.org" class="">chunyang@macports.org</a> wrote:<br class=""><div><div class=""><br class="Apple-interchange-newline"></div><blockquote type="cite" class=""><div class=""><div id="msg" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><dl class="meta" style="font-family: verdana, arial, helvetica, sans-serif; font-size: 10pt; border: 1px solid rgb(0, 0, 102); background-color: rgb(51, 102, 153); padding: 6px; color: rgb(255, 255, 255); background-position: initial initial; background-repeat: initial initial;"><dt style="font-family: verdana, arial, helvetica, sans-serif; font-size: 10pt; float: left; width: 6em; font-weight: bold;" class="">Revision</dt><dd class=""><a href="https://trac.macports.org/changeset/137943" style="font-weight: bold; color: rgb(204, 204, 102);" class="">137943</a></dd><dt style="font-family: verdana, arial, helvetica, sans-serif; font-size: 10pt; float: left; width: 6em; font-weight: bold;" class="">Author</dt><dd class=""><a href="mailto:chunyang@macports.org" style="font-weight: bold; color: rgb(204, 204, 102);" class="">chunyang@macports.org</a></dd><dt style="font-family: verdana, arial, helvetica, sans-serif; font-size: 10pt; float: left; width: 6em; font-weight: bold;" class="">Date</dt><dd class="">2015-06-23 10:06:03 -0700 (Tue, 23 Jun 2015)</dd></dl><h3 style="font-family: verdana, arial, helvetica, sans-serif; font-size: 10pt; font-weight: bold;" class="">Log Message</h3><pre style="overflow: auto; background-color: rgb(255, 255, 204); border: 1px solid rgb(255, 170, 0); padding: 6px; background-position: initial initial; background-repeat: initial initial;" class="">github2port: Simplify regexp use and use list rather than concat for making proc return</pre><h3 style="font-family: verdana, arial, helvetica, sans-serif; font-size: 10pt; font-weight: bold;" class="">Modified Paths</h3><ul style="font-family: verdana, arial, helvetica, sans-serif; font-size: 10pt;" class=""><li style="font-family: verdana, arial, helvetica, sans-serif; font-size: 10pt;" class=""><a href="x-msg://60/#branchesgsoc15portfilegithub2portgithub2port" class="">branches/gsoc15-portfile/github2port/github2port</a></li></ul></div></div></blockquote><br class=""><blockquote type="cite" class=""><div class=""><div id="patch" style="width: 706px; font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><div class="modfile" style="border: 1px solid rgb(204, 204, 204); margin: 10px 0px;"><pre class="diff" style="padding: 0px 0px 10px; line-height: 1.2em; margin: 0px; width: 704px; background-color: rgb(238, 238, 238); overflow: auto; background-position: initial initial; background-repeat: initial initial;"><span style="display: block; padding: 0px 10px;" class=""><ins style="background-color: rgb(221, 255, 221); text-decoration: none; display: block; padding: 0px 10px; background-position: initial initial; background-repeat: initial initial;" class="">+ set res {}
+
</ins><span class="cx" style="display: block; padding: 0px 10px;"> set path [split $urlparts(path) /]
</span><del style="background-color: rgb(255, 221, 221); text-decoration: none; display: block; padding: 0px 10px; background-position: initial initial; background-repeat: initial initial;" class="">- set author [lindex $path 0]
- set project [lindex $path 1]
</del><ins style="background-color: rgb(221, 255, 221); text-decoration: none; display: block; padding: 0px 10px; background-position: initial initial; background-repeat: initial initial;" class="">+ set author [lindex $path 0] ; lappend res $author
+ set project [lindex $path 1] ; lappend res $project
+
</ins><span class="cx" style="display: block; padding: 0px 10px;"> set tarball [lindex $path end]
</span><ins style="background-color: rgb(221, 255, 221); text-decoration: none; display: block; padding: 0px 10px; background-position: initial initial; background-repeat: initial initial;" class="">+ foreach i [parse_tarball_name $tarball] {
+ lappend res $i
+ }
</ins><span class="cx" style="display: block; padding: 0px 10px;">
</span><span class="cx" style="display: block; padding: 0px 10px;"> set tarball_from [expr {[string match */releases/download/* $url] ? "release" : ""}]
</span><ins style="background-color: rgb(221, 255, 221); text-decoration: none; display: block; padding: 0px 10px; background-position: initial initial; background-repeat: initial initial;" class="">+ lappend res $tarball_from
</ins><span class="cx" style="display: block; padding: 0px 10px;">
</span><del style="background-color: rgb(255, 221, 221); text-decoration: none; display: block; padding: 0px 10px; background-position: initial initial; background-repeat: initial initial;" class="">- return [concat $author $project [parse_tarball_name $tarball] $tarball_from]
</del><ins style="background-color: rgb(221, 255, 221); text-decoration: none; display: block; padding: 0px 10px; background-position: initial initial; background-repeat: initial initial;" class="">+ return $res
</ins><span class="cx" style="display: block; padding: 0px 10px;"> }
</span></span></pre></div></div></div></blockquote><div><br class=""></div><div>I think this would be clearer if you used the "list" command:</div><div><br class=""></div><div><span class="Apple-tab-span" style="white-space:pre"> </span>return [list $author $project {*}[parse_tarball_name $tarball] $tarball_from]</div><div><br class=""></div><div>vq</div></div></body></html>