<!DOCTYPE html>
<html>
<head>
<title></title>
</head>
<body><div>On Sat, Jul 4, 2015, at 11:53 PM, Brandon Allbery wrote:<br></div>
<blockquote type="cite"><div dir="ltr"><div><div><div>On Sat, Jul 4, 2015 at 11:51 PM, Ryan Schmidt <span dir="ltr"><<a href="mailto:ryandesign@macports.org">ryandesign@macports.org</a>></span> wrote:<br></div>
<blockquote style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0.8ex;border-left-width:1px;border-left-color:rgb(204, 204, 204);border-left-style:solid;padding-left:1ex;"><div style="overflow-y:hidden;overflow-x:hidden;"><div>> + fix correcting of .pc files for any install location, not just when in ${prefix}.<br></div>
<div> </div>
<div>
When would it not be in prefix?<br></div>
</div>
</blockquote></div>
<div> </div>
<div>When it's in a subdirectory of $prefix, so it can be installed at the same time as qt5. Note that that is also the case where the original reinplace would "succeed" but do the wrong thing.<br></div>
</div>
</div>
</blockquote><div> </div>
<div>Exactly; thanks Brandon for jumping in! I'm going through every port that seems to possibly depend on Qt4. After installing Qt4 into ${prefix}/libexec/qt4, doing a rev-bump on each port in turn, then seeing if it builds; I'm not generally testing for functionality though, so I expect after the "big commit" to do this switch there will still be some issues with functionality. Most ports work with just a rev-bump; but maybe 1 in 10 I come upon one that doesn't. So, I fix it to work with qt4-mac installed into ${prefix} or into the new location, figuring a generic fix is the best. This specific fix came from me fixing py-pyqt4 (to be checked in Monday, most likely), and is critical to having the pkg-config files work correctly. Internal to the Qt*.pc file, ${prefix} is set and used, and this reinplace just uses it more consistently when Qt fails to use it. Maybe the comment might have been more clear; hopefully it's good enough with this side commentary. - MLD<br></div>
<div> </div>
</body>
</html>