<p dir="ltr"><br>
On Sep 1, 2015 7:17 PM, "Mihai Moldovan" <<a href="mailto:ionic@macports.org">ionic@macports.org</a>> wrote:<br>
><br>
> On 01.09.2015 01:32 AM, Michael Beasley wrote:<br>
> > Attached are patches for sysutils/mkpwd v1.6. (current version 0.8)<br>
> > [...]<br>
><br>
> A couple of comments on that one:<br>
><br>
> Due to the project now using autotools, a lot of stuff can be simplified. For<br>
> instance, explicitly defining the universal variant is not required,<br>
> build.target needs not be set explicitly (will be "all" by default which fits<br>
> nicely), build.args can be dropped (will be handled through configure) and<br>
> destroot.args is obsolete, too.<br>
><br>
> Due to real_version not being needed anymore, distname, livecheck.version can be<br>
> omitted due to already using the default values.<br>
><br>
> Due to .tar.gz now being used instead of .tgz, which (.tar.gz) is the default,<br>
> this can also be omitted.<br>
><br>
> Regarding the patches:<br>
><br>
> Please avoid whitespace-only changes to the original code base. This is a<br>
> non-functional change. It probably isn't a bad idea to upstream some stuff<br>
> (albeit probably not changes to Makefile.in, which is generated by autotools),<br>
> but definitely changes to the copyright header.<br>
><br>
> Also, the version number fix should naturally be upstreamed.<br>
><br>
> The same goes for the man page file fix.<br>
><br>
><br>
> I've committed the changes and general simplification as<br>
> <a href="https://trac.macports.org/changeset/139915">https://trac.macports.org/changeset/139915</a><br>
><br>
><br>
><br>
> Mihai<br>
></p>
<p dir="ltr">Noted, thanks for the feedback.</p>
<p dir="ltr">-Mike<br>
</p>