<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Hello,<div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Sep 4, 2015, at 3:02 PM, Joshua Root &lt;<a href="mailto:jmr@macports.org" class="">jmr@macports.org</a>&gt; wrote:</div><br class="Apple-interchange-newline"><div class="">On 2015-9-4 07:43 , Kurt Hindenburg wrote:<br class=""><blockquote type="cite" class="">Hi,<br class=""> &nbsp;Can I get some feedback on these patches?<br class=""><br class=""><a href="https://trac.macports.org/ticket/38208" class="">https://trac.macports.org/ticket/38208</a> - add depends_test<br class=""></blockquote><br class="">r+<br class=""><br class="">LGTM. My one concern would be that end users may not want irrelevant (to<br class="">them) test deps showing up in depends:, rdeps and so forth, but we<br class="">should come up with a general solution to that, not just omit them.<br class=""><br class=""></div></blockquote><div><br class=""></div>committed r140488</div><div><br class=""><blockquote type="cite" class=""><div class=""><blockquote type="cite" class=""><a href="https://trac.macports.org/ticket/45010" class="">https://trac.macports.org/ticket/45010</a> - port test stops if test.run is<br class="">not yes<br class=""></blockquote><br class="">r-<br class=""><br class="">This shouldn't be checked in portmain but rather somewhere higher up in<br class="">the vicinity of mportexec, where the deps are being computed and the<br class="">target is known.<br class=""></div></blockquote><br class="">A new patch attached to&nbsp;<a href="https://trac.macports.org/ticket/45010" class="">https://trac.macports.org/ticket/45010</a></div><div><br class=""><blockquote type="cite" class=""><div class=""><br class=""><blockquote type="cite" class=""><a href="https://trac.macports.org/ticket/28640" class="">https://trac.macports.org/ticket/28640</a> - port lint check when should use<br class="">-append<br class=""></blockquote><br class="">r-<br class=""><br class="">Overriding the deps set by a portgroup is not always incorrect.<br class=""></div></blockquote><br class="">Do you mean to say that there are times that the Portfile should override the PortGroup? &nbsp;Do you think changing this lint to a warning suggesting they should verify if they should use ‘-append’ ?</div><div><br class=""></div><div>Thanks</div><div>&nbsp; Kurt</div><div><br class=""></div></div></body></html>